From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=JFaj=5C=seketeli.org=dodji@sourceware.org>
Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224])
	by sourceware.org (Postfix) with ESMTPS id A86B03858C50
	for <libabigail@sourceware.org>; Thu,  5 Jan 2023 12:08:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A86B03858C50
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
	by mail.gandi.net (Postfix) with ESMTPSA id 3CA16E0004;
	Thu,  5 Jan 2023 12:08:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org;
	s=gm1; t=1672920491;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2E37bLMmqcx15q8mY0n3oaWVU80or7xOE8apTjh3cqo=;
	b=pcLRGPAiQ0IfU+JPy6VrUJ7n38kKMa5eRSN1tFsNmpUpeld2flX4MT+bBfen8J69UoYGd9
	Rz0/CbS0ho2Xwol9mk4VPtuWg4lqtPSHlQjmiy5MUVbzVpmu+lhEXHk1gHtjEI+mStE1Bw
	1DrfZsMlyCvlmkMTpeTaNdYvGmA3zgFzull4IlXdRHtexIWUu+YOisXUXNOcef8j0E6qXl
	yzsRMKRwOBTlHTaHvK0z5QYKmZhJ7oFP57nVc1tMLOMxXUDwOKeLLxgVj3NYlYW2Oqhrjj
	5siBB8KuDD82La7pSz6LAY5/5JicocX9fer8OKAV55QBGytriPcgxRvQEuoDyQ==
Received: by localhost (Postfix, from userid 1000)
	id 35069581C59; Thu,  5 Jan 2023 13:08:10 +0100 (CET)
From: Dodji Seketeli <dodji@seketeli.org>
To: Petr Pavlu via Libabigail <libabigail@sourceware.org>
Cc: Petr Pavlu <petr.pavlu@suse.com>
Subject: Re: [PATCH] abidiff: Fix handling of linux-kernel-mode
Organization: Me, myself and I
References: <20230103102855.21686-1-petr.pavlu@suse.com>
X-Operating-System: Fedora 38
X-URL: http://www.seketeli.net/~dodji
Date: Thu, 05 Jan 2023 13:08:09 +0100
In-Reply-To: <20230103102855.21686-1-petr.pavlu@suse.com> (Petr Pavlu via
	Libabigail's message of "Tue, 3 Jan 2023 11:28:55 +0100")
Message-ID: <87y1qhkwuu.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libabigail.sourceware.org>

Hello Petr,

Petr Pavlu via Libabigail <libabigail@sourceware.org> a =C3=A9crit:

> This fixes 08e76022 ("Support Linux Kernel ABI whitelist files") and
> 8fd02e0a ("Use the CTF reader by default when applicable").
>
> The first commit removed handling of option --no-linux-kernel-mode. The
> second one stopped passing opts.linux_kernel_mode down to the library
> which also caused changing the default linux-kernel-mode of abidiff from
> true to false. Both changes look unintentional as they are not mentioned
> in either commit message.
>
> Restore handling of the linux-kernel-mode in abidiff to match what is
> described in doc/manuals/abidiff.rst and make it again consistent with
> abidw.
>
> 	* tools/abidiff.cc (parse_command_line): Recognize
> 	  --no-linux-kernel-mode.
> 	  (main): Pass opts.linux_kernel_mode down to the library.
>
> Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>

Applied to master, thanks!

[...]

Cheers,

--=20
		Dodji