From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [IPv6:2001:4b98:dc4:8::230]) by sourceware.org (Postfix) with ESMTPS id D73F7386F0F0 for ; Thu, 30 Jun 2022 16:40:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D73F7386F0F0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org Received: (Authenticated sender: dodji@seketeli.org) by mail.gandi.net (Postfix) with ESMTPSA id 81BCB24000B; Thu, 30 Jun 2022 16:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=seketeli.org; s=gm1; t=1656607238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fUwDsdVlP2dmuM2fmCT3y9T/+oDj0Y9CORzSEyObd70=; b=GJVO0ocLrJRTlUR66Tx/ptJQuct9WomnE8/4TV30w8e5JmhI3av9/pfnbKl36vrDaHOKh3 FwKfLfjIu66XsZXc587BdKoL0tTFeCe/tTnuuLnA+MkPDN5vdemcCpH1lDjYpMOgb8kGXe daqV6fIhhJ2kCv7IQMUo+a3BvRKne8R9ZPJEMcB7uEc0e9kZde1ZK7F5BAtPf9AFLH5yrI KGzZHmpiF+Ta0r+M6EyYvIcp/fSpknZfBs/+fwOFC/bKX70Od8mYAMeKk8V3H+xhSEpQjT sTS/Io6/B1Je8Ym8ast9DPBFCz2HNuZSYPrJgZa0ZrKxtqLPXW+DBIlZY97ACQ== Received: by localhost (Postfix, from userid 1000) id EF0BE5802B4; Thu, 30 Jun 2022 18:40:36 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH v5 2/4] optional: minor improvements Organization: Me, myself and I References: <20220321160221.1372398-1-gprocida@google.com> <20220613142533.3676501-3-gprocida@google.com> X-Operating-System: Fedora 37 X-URL: http://www.seketeli.net/~dodji Date: Thu, 30 Jun 2022 18:40:36 +0200 In-Reply-To: <20220613142533.3676501-3-gprocida@google.com> (Giuliano Procida's message of "Mon, 13 Jun 2022 15:25:31 +0100") Message-ID: <87y1xecdff.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 16:40:41 -0000 Hello, Giuliano Procida a =C3=A9crit: > This change makes minor improvements to the optional class used with > pre-C++17 compilers. > > - adds operator=3D=3D and operator!=3D > - adds various missing noexcept (but not constexpr) decorations > - defines operator bool in terms of has_value > > Note that some constexpr decorations would require C++17 anyway. > > * include/abg-cxx-compat.h (optional): Add operator=3D=3D and > operator!=3D. Add noexcept decorations. Tweak operator bool. > > Reviewed-by: Matthias Maennich > Signed-off-by: Giuliano Procida Applied to master, thanks! [...] Cheers, --=20 Dodji