From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dodji@seketeli.org>
Received: from relay11.mail.gandi.net (relay11.mail.gandi.net
 [IPv6:2001:4b98:dc4:8::231])
 by sourceware.org (Postfix) with ESMTPS id 7390B385355D;
 Mon, 13 Jun 2022 09:29:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7390B385355D
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=seketeli.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=seketeli.org
Received: (Authenticated sender: dodji@seketeli.org)
 by mail.gandi.net (Postfix) with ESMTPSA id 58756100008;
 Mon, 13 Jun 2022 09:29:34 +0000 (UTC)
Received: by localhost (Postfix, from userid 1000)
 id 1D05E5802B4; Mon, 13 Jun 2022 11:29:33 +0200 (CEST)
From: Dodji Seketeli <dodji@seketeli.org>
To: gprocida at google dot com via Libabigail <libabigail@sourceware.org>
Cc: gprocida at google dot com <sourceware-bugzilla@sourceware.org>
Subject: Re: [Bug default/29239] New: abidiff - possibly unintentionally
 harmless diffs
Organization: Me, myself and I
References: <bug-29239-9487@http.sourceware.org/bugzilla/>
X-Operating-System: Fedora 37
X-URL: http://www.seketeli.net/~dodji
Date: Mon, 13 Jun 2022 11:29:33 +0200
In-Reply-To: <bug-29239-9487@http.sourceware.org/bugzilla/> (gprocida at
 google dot com via Libabigail's message of "Fri, 10 Jun 2022 12:06:02
 +0000")
Message-ID: <87y1y0kj2a.fsf@seketeli.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2022 09:29:39 -0000

gprocida at google dot com via Libabigail <libabigail@sourceware.org> a
=C3=A9crit:

Hello,

> So struct foo has changed and the second half of struct boo has changed.
>
> abidiff treats 2 of the 6 changes as harmless. Is this intentional?

The two changes that are flagged harmless are these:

        type of 'foo& lref1' changed:
          referenced type 'struct foo' changed, as reported earlier
        type of 'foo&& rref1' changed:
          referenced type 'struct foo' changed, as reported earlier

They are actually "redundant" changes, meaning, the changes to struct
foo have already been reported earlier.  So these changes are just being
left out of the report for "compactness", thus, hopefully, better
legibility.

So yes, that is intentional.

Cheers,

--=20
		Dodji