From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 4615D3838025 for ; Mon, 29 Nov 2021 13:33:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4615D3838025 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1ATBxMW2025169 for ; Mon, 29 Nov 2021 13:33:10 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3cmrt7t1re-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 29 Nov 2021 13:33:08 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1ATDVZbl097899 for ; Mon, 29 Nov 2021 13:33:07 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2043.outbound.protection.outlook.com [104.47.66.43]) by aserp3030.oracle.com with ESMTP id 3ckaqcsprx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 29 Nov 2021 13:33:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E0SKdcRZfYyi6/cz4NzXQwanML7DQUp/rb2eyXzLaF7f6tF+7Ip7gKQOF9NoIyfkW3uAGH3KuxTSgHXWeLJDIygnrv7Bm9PjsAEPkmJOg2O5Imjjli01a9QJ3HbBsJ2pHvz7Uo6YNHCVBb4sHoPIfOGWGg9GMk/qM8QvcdvPV+p2Q9N6QUEi7Nd07HdaWCTkZk0FWLAjFDXkz32INuKBre8uhb5xJMtcoOSHzVNwiK+17apij9wf+jaziEgUI+uNJIWmERUT6f49ZStoDiPi1C8zO+xTiCrhKN4zCcHMN3Z2r7Ik1Qffvwkp4pBKgH98SFTHOh4MEtxc5kvnhf5HuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Dg6/9sWDBe3b74GuJLc1RhJAn8k8o0ddJo1g+7jhcQ=; b=lTocOmRI82xWXYwBkT9X/8Dqn7KmTKXuWVHuDwp7rfU2c1ussv/mb5KCXnb+E/frtrVnsOL8gx7+t3zozOqV5xbsc4UgNih7Nb2jr0CCKZlEEncpr/lrpaZCumL2keadm1bUNF6+y65v54vKWdZ2AORsosF7s44S2XoY0tU3A9A6TMaZQQrVX4RINrUoozS7313biJjU99cymXJi5yFE9uf8RARgsWoAExVH/QbcAUDjsdeFervmYufmq/5ZIAgepo3ufnEE5SCk+abzSmWkBuU8/6bEaQq/RxWwrwAVb95fSQk31Ib7MT33cq6tZo28iqgAtUDsF0kPXftIKyOwDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by BYAPR10MB3016.namprd10.prod.outlook.com (2603:10b6:a03:8e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 29 Nov 2021 13:33:05 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::48bf:86b4:32e1:6574]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::48bf:86b4:32e1:6574%4]) with mapi id 15.20.4734.024; Mon, 29 Nov 2021 13:33:05 +0000 From: "Jose E. Marchesi" To: "Guillermo E. Martinez via Libabigail" Subject: Re: [PATCH v2] ctf-reader: Fix length in dynamic array definition References: <20211126231718.119513-1-guillermo.e.martinez@oracle.com> <20211128015647.156104-1-guillermo.e.martinez@oracle.com> Date: Mon, 29 Nov 2021 14:32:54 +0100 In-Reply-To: <20211128015647.156104-1-guillermo.e.martinez@oracle.com> (Guillermo E. Martinez via Libabigail's message of "Sat, 27 Nov 2021 19:56:47 -0600") Message-ID: <87y257qe7t.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: AM0PR08CA0008.eurprd08.prod.outlook.com (2603:10a6:208:d2::21) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 Received: from termi.oracle.com (141.143.193.74) by AM0PR08CA0008.eurprd08.prod.outlook.com (2603:10a6:208:d2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend Transport; Mon, 29 Nov 2021 13:33:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 810c2f6c-0291-4e30-2d33-08d9b33cc5f8 X-MS-TrafficTypeDiagnostic: BYAPR10MB3016: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xpEXCCPhaO1mGVDBkSzRNo0EGfqrrpxw21PtQoX8ctpGH2Is0ACn0RXsI15ggJ9wpJoN3W5edX0vWGpqOd8MrKQlot28RVxJToJkOeZHaPYIlfgzVG5DWpDBiD8Pip1nrotWESjdgs36r8dKeP3uEpER0XE+LbRWMF7lJz3JGKjOTsKCmMVgvZfeL1PgJewaZRNiVKlyqhhqpilnRncHhxD/BvjXsqD2D3kJ9tlfbCuOJuOJ8bOSL2aP6xFE2ZfKmS3Jzg9OhmMVVV6CRK+AHDJcMQS8HEjAh2wmynIzQSB5SXExlJDSB2OAZT7g5+tOHPg3PycXedxZNWWgrrvtjVIhAQ9AGQmdN5A14EgvG2ZUsIW5O3FLmWSVFkBOOyLdsxTKDklqWNBUyxwcM4e+C/3tJJ4Pt1RpqC0Iu8gn42GdZkXvZRTqHhlgKOdR0UxwwUwsp1p8DzSo5VJeBcDXOH6w0B66R+jQ/5FCh3LhCiD7TS6TaYGCC2cvScMHdvVvOrzMAKDjAsLsLJFwYfZT6t6j99gawNfpnHqrlCygWUjMoqnTvAsJl2ZLKH2vZTmaf4+r59ncWhmGVhY3voRXpJZGFvWAbUfrn/R4fWAWxe3l5HpvJDXJg/T1w/mOavLo+qBCCWYM3nvSa6PI3KdEvXjSbNepkeuejpI2ym3cX6MZTe/BUefqYclrGDL1AcX9JAiLKIYJ7l6M1bvGTBZPzg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(6486002)(36756003)(316002)(2616005)(7696005)(86362001)(956004)(4326008)(8936002)(52116002)(2906002)(66946007)(6916009)(508600001)(107886003)(5660300002)(38100700002)(6666004)(26005)(66476007)(8676002)(66556008)(38350700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?udzEZ13WBF34Rt6AZhxtpOZpDVFvg9owjctWhnUF/fV+P27ey/e8UzR3gCzu?= =?us-ascii?Q?TdfD0amLyQ6P0tu+GkprQjHsGHipFNjvLD8LiSbWK/XhV0lIjsQNBM9IJpxh?= =?us-ascii?Q?SBxVD9CG72FkhWiQltP2IBHkYrv54lx7Sp3MHeAKMmLMuNGxv2h8nY1C2R0j?= =?us-ascii?Q?NBsvD0MuxWqTZWaHFFyB0NQ1GEnlEhdYy8XX5lYxPGsIZ/uqkEkZWurd8XJx?= =?us-ascii?Q?lS+FE149acS6Skj1mGUZb5xy/FaqAuvRxba2D8dTCxrUfxQUMYYyg0Nhluef?= =?us-ascii?Q?/pF25A3mdgz62Wkyns/gXDLj2H8reASAlUNSOToP1uXUdxigfarmWTEN8NzC?= =?us-ascii?Q?ANg7WB9HSSBUbxoD7kfCARIuhxr3YFJDC6s6OFnbiiMnqW7X4OY/ztfFtwko?= =?us-ascii?Q?Wlv5xxSaDlWXkOD+RBS6tKwE0Ij8DsO2ydoJhK61FdQMu5cmffi8/lhLNUgm?= =?us-ascii?Q?0czCeVDZkT3Hlrl7cHLBFVknZjI1OE2tY5Hg1IL20rAmQ/4gbn0VKclD3sr+?= =?us-ascii?Q?2ZZ2cgpmuOXGnIjD5KRPbpmyPNs0WzcXkcJ44GWeadib2waXFgD2Qw2kXxJW?= =?us-ascii?Q?vtIFlLuYLiU0afteoU36A3rujVnw7UsHnhXyVzkedfxlAImyul/VxhULR0o+?= =?us-ascii?Q?worBwAEH90TMkG9W2NVh6m84Gc2WIclRy5e9QgQbMoCW2sNtgFbi5HHYvGf/?= =?us-ascii?Q?cgwo+mLPOEyfpavSS4CGIbIvrL73EJoK+hat/OhKGI3WJeQ6R49Myhwh02Fy?= =?us-ascii?Q?HRebIpMLmYKL+G+2IrWiwOwv2dIhrTYZnv++L3cN/33+6KQI0nm996WmUvCQ?= =?us-ascii?Q?27ktaP6mQb7rGg+ye71AJ2WDeelTR9tyA7Zdslna4YXo2f2x4GUPL8gEWBUp?= =?us-ascii?Q?F/9YQSymLqKWH0BpE6NplfKUsEOuEmCSCoNc8QrNWnIaDFNUDzhVAiTRu6hN?= =?us-ascii?Q?JwquH70rOim6dug1C22mEU0JSrtqewzSr70FEmYt6aioJt+6jIaWeYKpBrlF?= =?us-ascii?Q?Wtf9Z9YEgnVotiFsRuA/rm8ux/YmZ14eDD4KNZZjcGyO+bWXruNU6xc+Y0Kr?= =?us-ascii?Q?OswMkQzdYl4zRkSPL31hm1fBrGGWtX3vyBypgVmyZ5NXRNGDSqMnEs9P6gzN?= =?us-ascii?Q?l6skhLkcSIqbnFsH/Urb+NqhDeH+QDqxo4Lkyhl31lljxDbYhDEu/uX6Jtvt?= =?us-ascii?Q?5fq3c6eOh6rf1xYVsN3X2KclRAG0KrkwqWsigI8FY8MZQheaxUKIDKywFKlR?= =?us-ascii?Q?4WauM6apC/dPbbKDWLXjeqRb+aSFwejNNNPXOdM3MNTqGBiKdpAPms1B8QVu?= =?us-ascii?Q?8bCgCr61XDtwEG/FMBF1EDKf1Vk1nxa6HTGCOJuPB6c8BEKYiYoxoaWq2SJx?= =?us-ascii?Q?BKaoypj3zqCNRtIqO+JMnRmFi1bTDiSmXcE6FNj9H9Nauh7QrdIqU+/tj4t/?= =?us-ascii?Q?unJoauPnFcUFFqsob2kNXeqypvxJ03+fCgqVBEW3BQadj5yPVu2Z/tRPKOuK?= =?us-ascii?Q?c3KIQdfo/fkGM/TqAJR0qU0AABnsVSZZlg4QeSnV5VF2mSqSbWZtBFFejVSR?= =?us-ascii?Q?IX43Ooz+E3yJ9O1OKgciFBS7kmF1cHgw78YIUPtte1WfchAQs8F2hFG2OEIY?= =?us-ascii?Q?WB6sH9HibtOVqDHuPliKgvutDHziaX08cyAOVJValuSOzYzv+brkX7dVDTwX?= =?us-ascii?Q?Jrcq1w=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 810c2f6c-0291-4e30-2d33-08d9b33cc5f8 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2021 13:33:05.3899 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0Bk8bZfaogg/kcSvnpRHambbxMZk4rqwi0aouV9oMgj+KDbGjMTdvNX+QvwMYJAOtlEiTn44RGuaKWzpJVCGFtzAlaAUw0w7c2NupHBwBaM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3016 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10182 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111290068 X-Proofpoint-ORIG-GUID: r2buiAxxMJJZq8xcxeVByqTwDrs7YZ3Y X-Proofpoint-GUID: r2buiAxxMJJZq8xcxeVByqTwDrs7YZ3Y X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Nov 2021 13:33:13 -0000 > Defining an array type with dynamic length, node `subrange' > in the abixml file doesn't write the accurate `length' > property `infinite', instead `1' is written: > > > So, member function `array_type_def::subrange_type::is_infinite' > is set when `upper_bound' value is equal to `0'. > > * src/abg-ctf-reader.cc (process_ctf_array_type): > set subrange_type::is_infinite when `upper_bound' value > is equal to `0'. > > Signed-off-by: Guillermo E. Martinez LGTM > --- > src/abg-ctf-reader.cc | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc > index c571d825..fbf6baef 100644 > --- a/src/abg-ctf-reader.cc > +++ b/src/abg-ctf-reader.cc > @@ -472,6 +472,7 @@ process_ctf_array_type(read_context *ctxt, > { > array_type_def_sptr result; > ctf_arinfo_t ctf_ainfo; > + bool is_infinite = false; > > /* First, get the information about the CTF array. */ > if (static_cast(ctf_array_info(ctf_dictionary, > @@ -507,6 +508,10 @@ process_ctf_array_type(read_context *ctxt, > lower_bound.set_unsigned(0); /* CTF supports C only. */ > upper_bound.set_unsigned(nelems > 0 ? nelems - 1 : 0U); > > + /* for VLAs number of array elements is 0 */ > + if (upper_bound.get_unsigned_value() == 0) > + is_infinite = true; > + > subrange.reset(new array_type_def::subrange_type(ctxt->ir_env, > "", > lower_bound, > @@ -517,6 +522,7 @@ process_ctf_array_type(read_context *ctxt, > if (!subrange) > return result; > > + subrange->is_infinite(is_infinite); > add_decl_to_scope(subrange, tunit->get_global_scope()); > canonicalize(subrange); > subranges.push_back(subrange);