From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com
Subject: Re: [PATCH 2/3] test-diff-suppr.cc: Add missing tests.
Date: Wed, 01 Apr 2020 18:46:44 +0200 [thread overview]
Message-ID: <87y2rfp30r.fsf@seketeli.org> (raw)
In-Reply-To: <20200329170121.188147-2-gprocida@google.com> (Giuliano Procida's message of "Sun, 29 Mar 2020 18:01:20 +0100")
Giuliano Procida <gprocida@google.com> a écrit:
> Commit 79383f937ca5cd8b3b0cd9e8a5c28871172e7bf1 added many tests but
> didn't actually execute three of them.
>
> Commit fe9fa7a05f88cf73b3f53c188a7682467901d12d added many tests but
> didn't actually execute one of them.
>
> This patch corrects these issues.
>
> * tests/test-diff-suppr.cc: Add stanzas for
> test6-fn-suppr-report-4, test16-suppr-removed-fn-report-5 and
> test22-suppr-removed-var-sym-report-5 and
> test23-alias-filter-report-4 tests.
> * tests/data/test-diff-suppr/test6-fn-suppr-report-4.txt:
> Number parameters from 1 and update expected output to current
> formatting.
> * tests/data/test-diff-suppr/test16-suppr-removed-fn-report-5.txt:
> Update expected output to current formatting.
> * tests/data/test-diff-suppr/test22-suppr-removed-var-sym-report-5.txt:
> Update expected output to current formatting.
Applied to master, thanks!
Cheers,
--
Dodji
next prev parent reply other threads:[~2020-04-01 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 17:01 [PATCH 1/3] abidiff: Remove blank line after typedef changes Giuliano Procida
2020-03-29 17:01 ` [PATCH 2/3] test-diff-suppr.cc: Add missing tests Giuliano Procida
2020-03-29 17:30 ` Matthias Maennich
2020-04-01 16:46 ` Dodji Seketeli [this message]
2020-03-29 17:01 ` [PATCH 3/3] abidiffpkg: Remove stray test report file Giuliano Procida
2020-03-29 17:31 ` Matthias Maennich
2020-04-01 17:31 ` Dodji Seketeli
2020-03-29 17:30 ` [PATCH 1/3] abidiff: Remove blank line after typedef changes Matthias Maennich
2020-04-01 16:21 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2rfp30r.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).