From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by sourceware.org (Postfix) with ESMTPS id C07D3385BF92 for ; Wed, 1 Apr 2020 16:46:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C07D3385BF92 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=seketeli.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dodji@seketeli.org X-Originating-IP: 91.166.131.130 Received: from localhost (91-166-131-130.subs.proxad.net [91.166.131.130]) (Authenticated sender: dodji@seketeli.org) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id E5851FF804; Wed, 1 Apr 2020 16:46:45 +0000 (UTC) Received: by localhost (Postfix, from userid 1000) id 1C841581890; Wed, 1 Apr 2020 18:46:45 +0200 (CEST) From: Dodji Seketeli To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH 2/3] test-diff-suppr.cc: Add missing tests. Organization: Me, myself and I References: <20200329170121.188147-1-gprocida@google.com> <20200329170121.188147-2-gprocida@google.com> X-Operating-System: Fedora 33 X-URL: http://www.seketeli.net/~dodji Date: Wed, 01 Apr 2020 18:46:44 +0200 In-Reply-To: <20200329170121.188147-2-gprocida@google.com> (Giuliano Procida's message of "Sun, 29 Mar 2020 18:01:20 +0100") Message-ID: <87y2rfp30r.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 16:46:49 -0000 Giuliano Procida a =C3=A9crit: > Commit 79383f937ca5cd8b3b0cd9e8a5c28871172e7bf1 added many tests but > didn't actually execute three of them. > > Commit fe9fa7a05f88cf73b3f53c188a7682467901d12d added many tests but > didn't actually execute one of them. > > This patch corrects these issues. > > * tests/test-diff-suppr.cc: Add stanzas for > test6-fn-suppr-report-4, test16-suppr-removed-fn-report-5 and > test22-suppr-removed-var-sym-report-5 and > test23-alias-filter-report-4 tests. > * tests/data/test-diff-suppr/test6-fn-suppr-report-4.txt: > Number parameters from 1 and update expected output to current > formatting. > * tests/data/test-diff-suppr/test16-suppr-removed-fn-report-5.txt: > Update expected output to current formatting. > * tests/data/test-diff-suppr/test22-suppr-removed-var-sym-report-5.txt: > Update expected output to current formatting. Applied to master, thanks! Cheers, --=20 Dodji