public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Dodji Seketeli <dodji@redhat.com>
To: libabigail@sourceware.org
Subject: [PATCH] ctf-reader: Remove useless parameter from fill_ctf_section
Date: Mon, 22 Nov 2021 17:21:12 +0100	[thread overview]
Message-ID: <87zgpwtb47.fsf@redhat.com> (raw)

Hello,

While looking at something else, I noticed fill_ctf_section now has a
useless parameter that was making compiling with some "tight" options
cringe.

Fixed thus.

	* src/abg-ctf-reader.cc (fill_ctf_section): Remove the now useless
	context parameter.  Adjust the comment accordingly.
	(slurp_elf_info): Adjust the invocation of fill_ctf_section.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
 src/abg-ctf-reader.cc | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/abg-ctf-reader.cc b/src/abg-ctf-reader.cc
index 2c2c204d..fd53f8a1 100644
--- a/src/abg-ctf-reader.cc
+++ b/src/abg-ctf-reader.cc
@@ -992,12 +992,11 @@ close_elf_handler (read_context *ctxt)
 /// Fill a CTF section description with the information in a given ELF
 /// section.
 ///
-/// @param ctxt the read context.
 /// @param elf_section the ELF section from which to get.
 /// @param ctf_section the CTF section to fill with the raw data.
 
 static void
-fill_ctf_section(read_context *ctxt, Elf_Scn *elf_section, ctf_sect_t *ctf_section)
+fill_ctf_section(Elf_Scn *elf_section, ctf_sect_t *ctf_section)
 {
   GElf_Shdr section_header_mem, *section_header;
   Elf_Data *section_data;
@@ -1046,9 +1045,9 @@ slurp_elf_info(read_context *ctxt, corpus_sptr corp)
   if (ctf_scn == NULL || symtab_scn == NULL || strtab_scn == NULL)
     return 0;
 
-  fill_ctf_section(ctxt, ctf_scn, &ctxt->ctf_sect);
-  fill_ctf_section(ctxt, symtab_scn, &ctxt->symtab_sect);
-  fill_ctf_section(ctxt, strtab_scn, &ctxt->strtab_sect);
+  fill_ctf_section(ctf_scn, &ctxt->ctf_sect);
+  fill_ctf_section(symtab_scn, &ctxt->symtab_sect);
+  fill_ctf_section(strtab_scn, &ctxt->strtab_sect);
 
   return 1;
 }
-- 
2.33.1


-- 
		Dodji


             reply	other threads:[~2021-11-22 16:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 16:21 Dodji Seketeli [this message]
2021-11-22 18:23 ` Jose E. Marchesi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgpwtb47.fsf@redhat.com \
    --to=dodji@redhat.com \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).