From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com
Subject: Re: [PATCH v2 1/2] abidiff: More compact references to prior diffs.
Date: Tue, 14 Apr 2020 12:42:30 +0200 [thread overview]
Message-ID: <87zhbenyax.fsf@seketeli.org> (raw)
In-Reply-To: <20200407213314.248613-1-gprocida@google.com> (Giuliano Procida's message of "Tue, 7 Apr 2020 22:33:13 +0100")
Hello Giuliano,
Giuliano Procida <gprocida@google.com> a écrit:
[...]
>
> * src/abg-reporter-priv.cc (represent): In the var_diff_sptr
> overload, use consistent punctuation and keep to a single line
> of output when referring back to an existing type diff report.
> Remove unnecessary braces around single line conditional
> blocks.
> * src/abg-reporter-priv.h: In the macro
> RETURN_IF_BEING_REPORTED_OR_WAS_REPORTED_EARLIER, use
> consistent punctuation when referring back to an existing type
> diff report.
> * tests/data/test-abidiff/test-PR18791-report0.txt: Adjust
> formatting of back references to existing type diff reports.
> * tests/data/test-diff-dwarf/PR25058-liblttng-ctl-report-1.txt:
> Ditto.
> * tests/data/test-diff-filter/test16-report-2.txt: Ditto.
> * tests/data/test-diff-filter/test17-1-report.txt: Ditto.
> * tests/data/test-diff-filter/test25-cyclic-type-report-1.txt:
> Ditto.
> * tests/data/test-diff-pkg/spice-server-0.12.4-19.el7.x86_64-0.12.8-1.el7.x86_64-report-2.txt:
> Ditto.
> * tests/data/test-diff-suppr/test36-leaf-report-0.txt: Ditto.
Applied to master, thanks!
Cheers,
--
Dodji
prev parent reply other threads:[~2020-04-14 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 21:53 [PATCH " Giuliano Procida
2020-04-03 21:53 ` [PATCH 2/2] abidiff: Fix anonymous member size change reports Giuliano Procida
2020-04-06 16:08 ` Matthias Maennich
2020-04-07 13:55 ` Dodji Seketeli
2020-04-07 21:31 ` Giuliano Procida
2020-04-07 21:45 ` Giuliano Procida
2020-04-06 15:29 ` [PATCH 1/2] abidiff: More compact references to prior diffs Matthias Maennich
2020-04-07 13:47 ` Dodji Seketeli
2020-04-07 21:32 ` Giuliano Procida
2020-04-07 21:33 ` [PATCH v2 " Giuliano Procida
2020-04-07 21:33 ` [PATCH v2 2/2] abidiff: Fix anonymous member size change reports Giuliano Procida
2020-04-14 10:42 ` Dodji Seketeli
2020-04-14 10:42 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhbenyax.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).