public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Trilok Soni <quic_tsoni@quicinc.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
	John Moon <quic_johmoo@quicinc.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nicolas@fjasle.eu>,
	<linux-kbuild@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-arm-msm@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Bjorn Andersson <andersson@kernel.org>,
	Todd Kjos <tkjos@google.com>,
	Matthias Maennich <maennich@google.com>,
	Giuliano Procida <gprocida@google.com>, <kernel-team@android.com>,
	<libabigail@sourceware.org>, Jordan Crouse <jorcrous@amazon.com>,
	Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>,
	Elliot Berman <quic_eberman@quicinc.com>
Subject: Re: [PATCH v2 0/2] Validating UAPI backwards compatibility
Date: Wed, 1 Mar 2023 15:35:53 -0800	[thread overview]
Message-ID: <8cedfaea-b8b5-30a4-969c-205af5193ce6@quicinc.com> (raw)
In-Reply-To: <CAKwvOdmUm8oEiiYt64oe0MY+H3U0TxpzVhWbhfvptTDkKHUFcA@mail.gmail.com>

On 3/1/2023 3:33 PM, Nick Desaulniers wrote:
> On Wed, Mar 1, 2023 at 2:33 PM John Moon <quic_johmoo@quicinc.com> wrote:
>>
>> With some additional help from Nick offline, we determined that the
>> issue isn't with clang, but with libdw (from elfutils). You need at
>> least libdw version 0.171 for the abidiff tool to work correctly with
>> clang (in this particular case). Ubuntu 18.04 ships with version 0.170.
>>
>> If there's any interest, it'd be fairly easy to add a check for this
>> condition under the check_deps() function in the script.
> 
> Good job John; mind sending a v3 with that addition, and the commit
> message updated?

I would prefer to wait to get more reviews on v2 from Greg/Masahiro and 
then combine above checks in the v3. If there are no comments by next 
Monday then we can send v3, sounds good?

---Trilok Soni

  reply	other threads:[~2023-03-01 23:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01  7:54 John Moon
2023-03-01  7:54 ` [PATCH v2 1/2] check-uapi: Introduce check-uapi.sh John Moon
2023-03-03 21:09   ` Dodji Seketeli
2023-03-05  4:22   ` Masahiro Yamada
2023-03-05 17:08     ` John Moon
2023-03-01  7:54 ` [PATCH v2 2/2] docs: dev-tools: Add UAPI checker documentation John Moon
2023-03-05  6:20   ` Masahiro Yamada
2023-03-06 16:56     ` John Moon
2023-03-01 17:50 ` [PATCH v2 0/2] Validating UAPI backwards compatibility Nick Desaulniers
2023-03-01 18:03   ` John Moon
2023-03-01 19:24     ` John Moon
2023-03-01 22:33       ` John Moon
2023-03-01 23:33         ` Nick Desaulniers
2023-03-01 23:35           ` Trilok Soni [this message]
2023-03-01 23:52         ` Mark Wielaard
2023-03-01 23:59           ` John Moon
2023-03-10  8:09 ` Christoph Hellwig
2023-03-10 18:20   ` Trilok Soni
2023-03-20  6:26     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8cedfaea-b8b5-30a4-969c-205af5193ce6@quicinc.com \
    --to=quic_tsoni@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=gprocida@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jorcrous@amazon.com \
    --cc=kernel-team@android.com \
    --cc=libabigail@sourceware.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maennich@google.com \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nicolas@fjasle.eu \
    --cc=quic_eberman@quicinc.com \
    --cc=quic_johmoo@quicinc.com \
    --cc=quic_satyap@quicinc.com \
    --cc=rdunlap@infradead.org \
    --cc=tkjos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).