From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97558 invoked by alias); 17 Jan 2019 14:42:59 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 97086 invoked by uid 89); 17 Jan 2019 14:42:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Jan 2019 14:42:57 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 2DFD93000425; Thu, 17 Jan 2019 15:42:54 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id D513C40350DF; Thu, 17 Jan 2019 15:42:54 +0100 (CET) Message-ID: <91ab2ad3ca3a9c941066caeac01c9d5183397916.camel@klomp.org> Subject: Re: Buildbot failure in Wildebeest Builder on whole buildset From: Mark Wielaard To: Dodji Seketeli Cc: libabigail@sourceware.org Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: <86tvi7bdeb.fsf@seketeli.org> References: <20190117100851.0E597800729@builder.wildebeest.org> <86tvi7bdeb.fsf@seketeli.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-2.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q1/txt/msg00005.txt.bz2 Hi Dodji, On Thu, 2019-01-17 at 14:51 +0100, Dodji Seketeli wrote: > diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc > index c9cffc3..aa9d147 100644 > --- a/src/abg-dwarf-reader.cc > +++ b/src/abg-dwarf-reader.cc > @@ -12199,9 +12199,6 @@ dwarf_language_to_tu_language(size_t l) > case DW_LANG_Ada83: > return translation_unit::LANG_Ada83; > case DW_LANG_C_plus_plus: > - case DW_LANG_C_plus_plus_03: > - case DW_LANG_C_plus_plus_11: > - case DW_LANG_C_plus_plus_14: > return translation_unit::LANG_C_plus_plus; aha, I see below that 11 and 14 were also handled there. Are you sure you need to distinguish these? For example C++03 is just C++98 with some DRs and no changes in language/abi. Maybe there are abi differences between the other c++ variants though? > @@ -12229,7 +12226,9 @@ dwarf_language_to_tu_language(size_t l) > return translation_unit::LANG_ObjC; > case DW_LANG_ObjC_plus_plus: > return translation_unit::LANG_ObjC_plus_plus; > +#ifdef DW_LANG_Rust > case DW_LANG_Rust: > +#endif > return translation_unit::LANG_Rust; > #ifdef DW_LANG_UPC > case DW_LANG_UPC: That endif should probably be added after the return. Cheers, Mark