Re: [PATCH v2] ctf-reader: add support to looking debug information in external path

["Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>]

On Tuesday, May 17, 2022 9:33:43 AM CDT Dodji Seketeli wrote:
> Hello,
Hello Dodji,
> "Guillermo E. Martinez via Libabigail" <libabigail@sourceware.org> a
> écrit:
> 
> 
> > When an ELF `stripped' file is used to get CTF debug information the ELF
> > symbols used by ctf reader (`symtab_reader::symtab') is split in a
> > separate file and even though CTF was designed to be in ELF file after
> > be `stripped' this .ctf section can be 'loaded'  from and external
> > .debug file, for instance the script `find-debuginfo' used to generate
> > RPM debug packages split debug information in .debug files. The location
> > of such files is pass as a standard argument from libabigail tools and
> > the name of the file is gathering from the `.gnu_debuglink' section.
> >
> > 	* include/abg-ctf-reader.h (ctf_reader::create_read_context):
> > 	Add `debug_info_root_paths' argument.
> > 	(ctf_reader::reset_read_context): Likewise.
> > 	* src/abg-ctf-reader.cc: Add `read_context::elf_{handler,fd}_dbg',
> > 	data members.
> > 	(read_context::read_context): Add new `debug_info_root_paths'
> > 	argument.
> > 	(read_context::initialize): Likewise.
> > 	(ctf_reader::create_read_context): Likewise.
> > 	(ctf_reader::close_elf_handler): Release
> > 	`read_context::elf_{handler,fd}_dbg' members.
> > 	(ctf_reader::find_alt_debuginfo): Add new function.
> > 	(ctf_reader::slurp_elf_info): Add new argument `status'. Use
> > 	`find_alt_debuginfo' and `elf_helpers::find_section_by_name'
> > 	to read the symtab and ctf information from an external .debug
> > 	file, the `status' reference is updated.
> > 	(ctf_reader::read_corpus): Verify `status' after `slurp_elf_info'.
> > 	(ctf_reader::reset_read_context): Add new `debug_info_root_path'
> > 	argument.
> > 	* src/abg-elf-helpers.cc (elf_helpers::find_section_by_name): Update
> > 	comment.
> > 	* src/abg-tools-utils.cc (maybe_load_vmlinux_ctf_corpus):
> > 	Adjust `ctf_reader::{create,reset}_read_context'.
> > 	* tests/test-read-ctf.cc: Likewise.
> > 	* tools/abidiff.cc (display_usage): Add `--ctf' command line
> > 	option.
> > 	(main): Adjust `ctf_reader::create_read_context'.
> > 	Likewise.
> > 	* tools/abidw.cc (load_corpus_and_write_abixml): Adjust
> > 	`ctf_reader::create_read_context'.
> > 	* tools/abilint.cc: Likewise.
> 
> I have also adjusted the use of the ctf reader in abipkgdiff.
> 
> Please find below the resulting patch that was applied to master.
> Thanks!
Thanks to you!!
> 
> >
> > Signed-off-by: Guillermo E. Martinez <guillermo.e.martinez@oracle.com>
> 
> Applied to master.
> 
> [...]
> 
> From 1ebd5ff0eb09e6fe78d45065d3bb9bb02468d37c Mon Sep 17 00:00:00 2001
> From: "Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>
> Date: Mon, 16 May 2022 13:32:54 -0500
> Subject: [PATCH] ctf-reader: add support to looking debug information in
>  external path
> [...]
guillermo