From: John Moon <quic_johmoo@quicinc.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
"Nicolas Schier" <nicolas@fjasle.eu>,
Jonathan Corbet <corbet@lwn.net>, <linux-kbuild@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>, <kernel@quicinc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rob Herring" <robh@kernel.org>,
Carlos O'Donell <carlos@redhat.com>,
Randy Dunlap <rdunlap@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Andersson <andersson@kernel.org>,
Todd Kjos <tkjos@google.com>,
Matthias Maennich <maennich@google.com>,
Giuliano Procida <gprocida@google.com>, <kernel-team@android.com>,
<libabigail@sourceware.org>, Dodji Seketeli <dodji@redhat.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
"Satya Durga Srinivasu Prabhala" <quic_satyap@quicinc.com>,
Jordan Crouse <jorcrous@amazon.com>
Subject: Re: [PATCH v7 3/3] check-module-params: Introduce check-module-params.sh
Date: Tue, 12 Dec 2023 08:58:16 -0800 [thread overview]
Message-ID: <93ee22bc-b357-4291-b3d9-07ff2cd6c87b@quicinc.com> (raw)
In-Reply-To: <ZXgOpRzNYGtiE35T@infradead.org>
On 12/11/2023 11:41 PM, Christoph Hellwig wrote:
> On Mon, Dec 11, 2023 at 06:02:59PM -0800, John Moon wrote:
>> One part of maintaining backwards compatibility with older
>> userspace programs is avoiding changes to module parameters.
>
> Really? I don't think module parameters are a UAPI in the traditional
> sense.
Agreed, they're not UAPI in the traditional sense. But, we're trying to
establish tooling to help the community stabilize all interfaces that
cross the kernel <-> userspace boundary and module params do fall into
that bucket.
> Now if you break a heavily used one you got to fix it, but
> applying strict stability guarantees on module options which are not
> availble to normal users or even normal programs doesn't make a whole
> lot of sense.
>
True, but unfortunately we don't have any heuristic to determine if a
param is "heavily used". However, in this rev, we added the ability to
parse the permissions of a module param, so we could add a filter which
does not flag change/removal of params with 0{0,4,6}000 permissions.
It's also obviously fine if the community has no interest in the script.
We just wanted to share it as we find it to be a useful supplement to
our code reviews and thought maintainers may find it useful as well.
Cheers,
John
next prev parent reply other threads:[~2023-12-12 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 2:02 [PATCH v7 0/3] Validating UAPI backwards compatibility John Moon
2023-12-12 2:02 ` [PATCH v7 1/3] check-uapi: Introduce check-uapi.sh John Moon
2023-12-22 17:50 ` Masahiro Yamada
2024-01-10 17:24 ` John Moon
2023-12-12 2:02 ` [PATCH v7 2/3] docs: dev-tools: Add UAPI checker documentation John Moon
2023-12-12 2:02 ` [PATCH v7 3/3] check-module-params: Introduce check-module-params.sh John Moon
2023-12-12 7:41 ` Christoph Hellwig
2023-12-12 16:58 ` John Moon [this message]
2023-12-22 17:57 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93ee22bc-b357-4291-b3d9-07ff2cd6c87b@quicinc.com \
--to=quic_johmoo@quicinc.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=carlos@redhat.com \
--cc=corbet@lwn.net \
--cc=dodji@redhat.com \
--cc=gprocida@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jorcrous@amazon.com \
--cc=kernel-team@android.com \
--cc=kernel@quicinc.com \
--cc=libabigail@sourceware.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=quic_satyap@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).