Re: [PATCH] Remove defined but not used functions pointed out by GCC6.

[Ben Woodard <woodard@redhat.com>]

I don’t know if these are the kinds of functions that I would get rid of. They don’t look like much but even though they aren’t being used now, they are the kinds of data access and type conversion functions that C++ is known for. Dodji is the final arbiter in this but I think that removing these functions just to silence a warning isn’t the right approach in this case.

Other opinions?

-ben

> On Jan 26, 2016, at 2:46 AM, Mark Wielaard <mjw@redhat.com> wrote:
> 
> abg-ir.cc:6041:1: warning: ‘abigail::ir::decl_base_sptr abigail::ir::convert_node_to_decl(std::tr1::shared_ptr<_Tp>) [with NodeKind = abigail::ir::decl_base]’ defined but not used [-Wunused-function]
> convert_node_to_decl(decl_base_sptr node)
> ^~~~~~~~~~~~~~~~~~~~
> 
> abg-ir.cc:5990:1: warning: ‘const string& abigail::ir::get_node_name(std::tr1::shared_ptr<_Tp>) [with NodeKind = abigail::ir::decl_base]’ defined but not used -Wunused-function]
> get_node_name(decl_base_sptr node)
> ^~~~~~~~~~~~~
> 
> 	* src/abg-ir.cc (convert_node_to_decl(decl_base_sptr)): Remove
> 	definition.
> 	(get_node_name(decl_base_sptr)): Likewise.
> 
> Signed-off-by: Mark Wielaard <mjw@redhat.com>
> ---
> src/abg-ir.cc | 20 --------------------
> 1 file changed, 20 deletions(-)
> 
> diff --git a/src/abg-ir.cc b/src/abg-ir.cc
> index 8a959f7..4b34916 100644
> --- a/src/abg-ir.cc
> +++ b/src/abg-ir.cc
> @@ -5980,16 +5980,6 @@ template<typename NodeKind>
> static const string&
> get_node_name(shared_ptr<NodeKind> node);
> 
> -/// Gets the name of a decl_base node.
> -///
> -/// @param node the decl_base node to get the name from.
> -///
> -/// @return the name of the node.
> -template<>
> -const string&
> -get_node_name(decl_base_sptr node)
> -{return node->get_name();}
> -
> /// Gets the name of a class_decl node.
> ///
> /// @param node the decl_base node to get the name from.
> @@ -6031,16 +6021,6 @@ template<typename NodeKind>
> static decl_base_sptr
> convert_node_to_decl(shared_ptr<NodeKind> node);
> 
> -/// Get the declaration of a given decl_base node
> -///
> -/// @param node the decl_base node to consider.
> -///
> -/// @return the declaration of the node.
> -template<>
> -decl_base_sptr
> -convert_node_to_decl(decl_base_sptr node)
> -{return node;}
> -
> /// Get the declaration of a given class_decl node
> ///
> /// @param node the class_decl node to consider.
> -- 
> 2.5.0
>