From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22530 invoked by alias); 3 Mar 2020 11:54:17 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Id: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 22454 invoked by uid 89); 3 Mar 2020 11:54:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-22.4 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 spammy=HTo:U*dodji, HX-Languages-Length:1037, HX-HELO:sk:mail-yw, HX-Received:a81 X-Spam-Status: No, score=-22.4 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mail-yw1-f47.google.com Received: from mail-yw1-f47.google.com (HELO mail-yw1-f47.google.com) (209.85.161.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Mar 2020 11:54:15 +0000 Received: by mail-yw1-f47.google.com with SMTP id a132so3073534ywb.2 for ; Tue, 03 Mar 2020 03:54:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=ozCBnnilNHRh1+mm7n8/+UfnaA6xnxuOr7A8WzsoIyQ=; b=E2w/8sHBWQjzJHSWeyJUzkg2E6HIC1uXSucRHBcdeYFUEZqPPUlfla0lRX6iRckTKu pMoiHB3JLWOUF9UrhsPXbYytc6KnH76SPpgiaQGiSb+u3DS6Oe53h8eOxrTwNDHrrosO uXi5FZ9BF3TED2FVRSYHPZG6QGY/0xex6emSx65MTOszis+CQLKpLGO8BqGQ+FamSytg XmIogqU615glI4ESBlEaBoKK9CfdfTBbXIZ3TBUzotWjkl/zTmMK+KcBtwgvtZgP+Dog /M7c2G7QSwD+l9WNdl9Ec+oP+l3h2ncngjQ5mMgbHJk/UvojFHhN5/c7LdbDLgUcPOSu WdkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=ozCBnnilNHRh1+mm7n8/+UfnaA6xnxuOr7A8WzsoIyQ=; b=Hjd78Sux1WJyHGCLI/8st6ncU/7dd9SuNjYSoL7HrMfEDqDY/xGb4KEd/DmVFRVEL8 WDuUT7O0UYMGkJWy4N4TwXAu/drpiueJN/fx45HNgoqwFwH9F5jsTnKn43kJUYPu2vY4 q4dIFpnY0+7poza9pEvZZiBPgtU9g1nguhzx2MFzQjbyWwU1KjoPwHe9xWOb6VNiW6Q2 6BDRPlzY2fpfeOLQQgIlk4VwRpsYS3s2zeIL0l5HkNb+VgTgMJMwV5BRQc8FBQAgkbtj B/cWRQvpKGEt1qGoDFQh+d+03/0J8o8B6W8VjeAdOXwZIruQS2SfAyeCuLGXIjgyVSEw Nc0g== X-Gm-Message-State: ANhLgQ1yV5fK+fCbBrUhMO3rMQbTfqQSyy3vaP1IdarD+OlaQR5+GNzY /sTVWpKd4vqQPYHre7ugua5qC98CgEiw7i3znqAN6A== X-Google-Smtp-Source: ADFU+vuInnUlfDHiXIXFrdOShE1GcTfHfUWb6rA2WOx8njD7/ibZxY6aqNGsmBjTB4QBrkyrfiKguwgWQ3SM4QoZNNQ= X-Received: by 2002:a81:9250:: with SMTP id j77mr4445532ywg.34.1583236452993; Tue, 03 Mar 2020 03:54:12 -0800 (PST) MIME-Version: 1.0 From: "Giuliano Procida via libabigail" Reply-To: Giuliano Procida Date: Wed, 01 Jan 2020 00:00:00 -0000 Message-ID: Subject: abidiff: Added/Deleted/Changed markers To: Dodji Seketeli , =?UTF-8?Q?Matthias_M=C3=A4nnich?= Cc: libabigail@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2020-q1/txt/msg00097.txt Added/Deleted/Changed markers appear in abidiff output under various circumstances. In --leaf-changes-only mode, "[A]", "[D]", "[C]" appear unconditionally to prefix each of the changes (and notably, this is what we see when doing kernel ABI diffs). In normal mode, they only appear if there are more than 100 changes in the given section. "[C]" is also not always followed by a space character. The markers are redundant in that they can be determined from their context. They would be most useful if doing something like line-by-line processing of abidiff output, but they are not always emitted so that's not happening. I'd like to do one of two things to make abidiff output more consistent and predictable. Either option will require the scripted adjustment of test cases. It's straightforward (I've already done it). 1. Emit them unconditionally, always followed by a space character. 2. Remove them altogether. What option would be best? I don't have strong opinions here. Giuliano.