From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) by sourceware.org (Postfix) with ESMTPS id 0F6593858020 for ; Thu, 25 Mar 2021 16:34:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0F6593858020 Received: by mail-ua1-x92a.google.com with SMTP id e1so697435uaa.4 for ; Thu, 25 Mar 2021 09:34:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WTtw3MKoWj4MVs6UvfTXJLvRXJf8OTa44+XNg4Nlu+g=; b=fR464fNoPhAtm5sgL/v8itNgNHJ4NQ+FttFsQ1peNTXXylTnMrkv38A7NfIx848+wl qGE8aGsOCmck8LFaJoodL/k1dDfIRhFCe1wW8JeQYm00ET8xwInX4jSOyNsySdMuERZd kHMvPsAfrCRCOgtvJtupSclDYFtgjeaLxWnhlftt1Ix3yokY5CdoRHWZ3jUhBzQyno1P g+rN/MnfHZdKJIcZeydZn6biINzZl24sLr4YRBCJSXFGbjrJlIX9glmY3nNAZb1oZd8r ND3iUuiXkmTDHFra/GOp4E8op0vdrROfIY1yTycKayMjbUdKQ5VboEguuffl2qyEMpFC 0yAQ== X-Gm-Message-State: AOAM532fRn/tfR8QmGeF1DFSfsjS9avxwF4US5Iw+a+Pm5t72uqPgy14 4vYaq44m87CpNd7ks9vwdAlRlBYnWvCZtrAQqPyWcf1PZy/log== X-Google-Smtp-Source: ABdhPJyw4MYO7/NFmk739X2kjpZjiJK/CeEU6Y9efzjLjj2DhwyDx/6jx1bMbNyRQisXG6GHY1EhKkcwdC2w00Bjf04= X-Received: by 2002:ab0:60c5:: with SMTP id g5mr5232781uam.5.1616690063373; Thu, 25 Mar 2021 09:34:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Giuliano Procida Date: Thu, 25 Mar 2021 16:33:48 +0000 Message-ID: Subject: Re: [Bug default/27569] abidiff misses a function parameter addition To: dodji at redhat dot com Cc: Giuliano Procida via Libabigail X-Spam-Status: No, score=-22.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2021 16:34:25 -0000 Hi. On Thu, 25 Mar 2021 at 11:22, dodji at redhat dot com via Libabigail < libabigail@sourceware.org> wrote: > https://sourceware.org/bugzilla/show_bug.cgi?id=27569 > > --- Comment #7 from dodji at redhat dot com --- > I have posted this tentative patch > https://sourceware.org/pipermail/libabigail/2021q1/003301.html. > > Could you please try it in your environment to see if it addresses the > issue > and review it? > > I had a quick look. It seems to do the trick. I don't think you need to include new test files as at least one existing test is affected by the change. A couple of questions: Can any other function level changes be missed? I'm guessing not, from looking at the XML attributes on a function-decl. In the bug, I wrote: I also think the only reason problems have not been noticed before is that is_filtered_out contains the suspicious-looking: if (category == NO_CHANGE_CATEGORY) return false; If I remove this line and re-run tests, some other diffs disappear, such as: --- /usr/local/google/home/gprocida/android/libabigail/build/../tests/data/test-diff-suppr/test10-changed-parm-c-report-0.txt 2021-02-03 10:29:34.846116830 +0000 +++ /usr/local/google/home/gprocida/android/libabigail/build/tests/output/test-diff-suppr/test10-changed-parm-c-report-0.txt 2021-03-25 16:28:56.472979039 +0000 @@ -1,16 +1,3 @@ -Functions changes summary: 0 Removed, 1 Changed, 0 Added function +Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function Variables changes summary: 0 Removed, 0 Changed, 0 Added variable -1 function with some indirect sub-type change: - - [C] 'function int foo(int, int)' has some indirect sub-type changes: - return type changed: - type name changed from 'int' to 'float' - type size hasn't changed - parameter 1 of type 'int' changed: - type name changed from 'int' to 'float' - type size hasn't changed - parameter 2 of type 'int' changed: - type name changed from 'int' to 'float' - type size hasn't changed - Does this mean you are also missing a category for "has changed to a different type"? Or is that somehow the residual meaning of NO_CHANGE_CATEGORY? Thanks in advance. > > You're welcome. > -- > You are receiving this mail because: > You are on the CC list for the bug.