From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gprocida@google.com>
Received: from mail-il1-x144.google.com (mail-il1-x144.google.com
 [IPv6:2607:f8b0:4864:20::144])
 by sourceware.org (Postfix) with ESMTPS id 11FA0386F477
 for <libabigail@sourceware.org>; Tue,  9 Jun 2020 17:43:48 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 11FA0386F477
Received: by mail-il1-x144.google.com with SMTP id l6so21238923ilo.2
 for <libabigail@sourceware.org>; Tue, 09 Jun 2020 10:43:48 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=l1Wc1hB41b5nUHbOPsC64sM+AOYhKNae/ZmULARKj08=;
 b=tQ4w950DzsDpxSqx47GDzxD/jPEY1yfMEaRk3Ikluklt3THpI0o26AFnaPmEQe0BWY
 GoQxxD6GUkLY14YKuLTJW0TKvIR46kB/GWzx8f6kC14Hg7r/o8+2yN5h4iWnHsheIu2R
 47DOSUhbl1NG+V3YU/nWmxxXQFshnXKQsk3RIhvF+ofyrHPWzBJkxtNYecZrhj5muOQT
 maeFdQ+YfyJg9BcJr4VX+aWgr6f6dSSHWXqGBeLlH99uD/SZrIV6Bhd+M3JzvCZgKXK0
 DG3t5s76nQLg/o2yYiMbfw+YTltcQk7vymZe7gUF1ig2nfBuKJ9+nkGZEZRaKY+I6u9j
 neKw==
X-Gm-Message-State: AOAM532Hb6gMA6ANY6HEpZ6gy7xTMst5zy7XPRkSJv7iOwfjyhkcR5oX
 XWzuzlHo32IxSZg6YXDZ2RsazyNd5Qu9PNaZ4geKtQ==
X-Google-Smtp-Source: ABdhPJyDykMk2o/720wkvl2Zo+956cx4MXMHaz6EcdlgNJzv0yz5xSVw/wKaeEXkVok44bvv9aGok0qTA2em0lJOAMg=
X-Received: by 2002:a92:c812:: with SMTP id v18mr28536823iln.178.1591724627255; 
 Tue, 09 Jun 2020 10:43:47 -0700 (PDT)
MIME-Version: 1.0
References: <20200609113827.204571-1-maennich@google.com>
In-Reply-To: <20200609113827.204571-1-maennich@google.com>
From: Giuliano Procida <gprocida@google.com>
Date: Tue, 9 Jun 2020 18:43:30 +0100
Message-ID: <CAGvU0H=ivWxTS_C-_pP-0kdw94Qk+YR9wQdoOfyOwSe8bgK9Zg@mail.gmail.com>
Subject: Re: [PATCH] abipkgdiff: remove unused includes of elfutils/libdw.h
 and elf.h
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org, Dodji Seketeli <dodji@seketeli.org>,
 kernel-team@android.com
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-29.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jun 2020 17:43:49 -0000

Hi.

On Tue, 9 Jun 2020 at 12:38, Matthias Maennich <maennich@google.com> wrote:
>
> Definitions from those headers are not actually used. Yet the includes
> create unnecessary dependencies.
>
>         * tools/abipkgdiff.cc: Drop unused includes.
>

Reviewed-by: Giuliano Procida <gprocida@google.com>

> Signed-off-by: Matthias Maennich <maennich@google.com>
> ---
>  tools/abipkgdiff.cc | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/abipkgdiff.cc b/tools/abipkgdiff.cc
> index 7d946e72b3c8..445e2406830b 100644
> --- a/tools/abipkgdiff.cc
> +++ b/tools/abipkgdiff.cc
> @@ -72,8 +72,6 @@
>  #include <assert.h>
>  #include <fcntl.h>
>  #include <sys/stat.h>
> -#include <elf.h>
> -#include <elfutils/libdw.h>
>
>  // If fts.h is included before config.h, its indirect inclusions may
>  // not give us the right LFS aliases of these functions, so map them
> --
> 2.27.0.278.ge193c7cf3a9-goog
>