public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Giuliano Procida <gprocida@google.com>
To: Matthias Maennich <maennich@google.com>
Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com
Subject: Re: [PATCH 1/2] optional: add operator== and operator!=
Date: Wed, 16 Mar 2022 09:31:18 +0000	[thread overview]
Message-ID: <CAGvU0H=jahAUitG9TwD1Jcd3KUybd-vs4hy0QxnJvrpdPdeb0g@mail.gmail.com> (raw)
In-Reply-To: <YjByVRVyj7DNdhk4@google.com>

Hi.

On Tue, 15 Mar 2022 at 11:02, Matthias Maennich <maennich@google.com> wrote:
>
> On Mon, Mar 14, 2022 at 06:13:11PM +0000, Giuliano Procida wrote:
> >       * include/abg-cxx-compat.h (optional): Add operator== and
> >       operator!=.
> >
> >Signed-off-by: Giuliano Procida <gprocida@google.com>
> >---
> > include/abg-cxx-compat.h | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> >diff --git a/include/abg-cxx-compat.h b/include/abg-cxx-compat.h
> >index 443905c7..a2cf9095 100644
> >--- a/include/abg-cxx-compat.h
> >+++ b/include/abg-cxx-compat.h
> >@@ -91,6 +91,22 @@ public:
> >   }
> >
> >   explicit operator bool() const { return has_value_; }
>
>      std signature is (at least make it noexcept):
>        > constexpr explicit operator bool() const noexcept;
>

Will do. I could add some, but not all, the constexpr as C++11
complains about ambiguous overloads.

> >+
> >+  bool
> >+  operator==(const optional<T>& other) const
> >+  {
> >+    if (!has_value_ && !other.has_value_)
> >+      return true;
> >+    if (!has_value_ || !other.has_value_)
> >+      return false;
> >+    return value_ == other.value_;
> >+  }
> >+
> >+  bool
> >+  operator!=(const optional<T>& other) const
> >+  {
> >+    return !operator==(other);
> >+  }
>
> I believe C++17 defines those as non-member functions. Should we follow
> that for compatibility. Eventually, when switching to C++17 or later we
> would want to just replace abg_compat:: with std:: and things should
> "just work".
>

Sure.

> Cheers,
> Matthias
>

v2 will follow.

Giuliano.

> > };
> >
> > #endif
> >--
> >2.35.1.723.g4982287a31-goog
> >

  reply	other threads:[~2022-03-16  9:31 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 18:13 [PATCH 0/2] Bug 28954 - add Linux Kernel symbol namespace support Giuliano Procida
2022-03-14 18:13 ` [PATCH 1/2] optional: add operator== and operator!= Giuliano Procida
2022-03-15 11:02   ` Matthias Maennich
2022-03-16  9:31     ` Giuliano Procida [this message]
2022-03-14 18:13 ` [PATCH 2/2] add Linux kernel symbol namespace support Giuliano Procida
2022-03-15 11:25   ` Matthias Maennich
2022-03-16 16:30 ` [PATCH v2 0/4] add symbol namespace support, update symbol CRC support Giuliano Procida
2022-03-16 16:30   ` [PATCH v2 1/4] optional: minor improvements Giuliano Procida
2022-03-17 10:56     ` Matthias Maennich
2022-03-16 16:30   ` [PATCH v2 2/4] crc_changed: eliminate copying of shared_ptr values Giuliano Procida
2022-03-17 11:01     ` Matthias Maennich
2022-03-16 16:30   ` [PATCH v2 3/4] add Linux kernel symbol namespace support Giuliano Procida
2022-03-17 11:57     ` Matthias Maennich
2022-03-16 16:30   ` [PATCH v2 4/4] Linux symbol CRCs: support 0 and report presence changes Giuliano Procida
2022-03-17 12:01     ` Matthias Maennich
2022-03-17 16:38   ` [PATCH v3 0/4] add symbol namespace support, update symbol CRC support Giuliano Procida
2022-03-17 16:38     ` [PATCH v3 1/4] crc_changed: eliminate copying of shared_ptr values Giuliano Procida
2022-03-17 16:38     ` [PATCH v3 2/4] optional: minor improvements Giuliano Procida
2022-03-17 16:38     ` [PATCH v3 3/4] Linux symbol CRCs: support 0 and report presence changes Giuliano Procida
2022-03-17 16:38     ` [PATCH v3 4/4] add Linux kernel symbol namespace support Giuliano Procida
2022-03-21 12:53       ` Matthias Maennich
2022-03-21 15:52         ` Giuliano Procida
2022-03-21 16:02     ` [PATCH v4 0/4] add symbol namespace support, update symbol CRC support Giuliano Procida
2022-03-21 16:02       ` [PATCH v4 1/4] crc_changed: eliminate copying of shared_ptr values Giuliano Procida
2022-03-21 16:02       ` [PATCH v4 2/4] optional: minor improvements Giuliano Procida
2022-03-21 16:02       ` [PATCH v4 3/4] Linux symbol CRCs: support 0 and report presence changes Giuliano Procida
2022-03-21 16:02       ` [PATCH v4 4/4] add Linux kernel symbol namespace support Giuliano Procida
2022-06-13 14:25       ` [PATCH v5 0/4] add symbol namespace support, update symbol CRC support Giuliano Procida
2022-06-30 16:39         ` Dodji Seketeli
2022-06-13 14:25       ` [PATCH v5 1/4] crc_changed: eliminate copying of shared_ptr values Giuliano Procida
2022-06-30 16:40         ` Dodji Seketeli
2022-06-13 14:25       ` [PATCH v5 2/4] optional: minor improvements Giuliano Procida
2022-06-30 16:40         ` Dodji Seketeli
2022-06-13 14:25       ` [PATCH v5 3/4] Linux symbol CRCs: support 0 and report presence changes Giuliano Procida
2022-06-30 16:41         ` Dodji Seketeli
2022-06-13 14:25       ` [PATCH v5 4/4] add Linux kernel symbol namespace support Giuliano Procida
2022-07-01 12:54         ` Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGvU0H=jahAUitG9TwD1Jcd3KUybd-vs4hy0QxnJvrpdPdeb0g@mail.gmail.com' \
    --to=gprocida@google.com \
    --cc=dodji@seketeli.org \
    --cc=kernel-team@android.com \
    --cc=libabigail@sourceware.org \
    --cc=maennich@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).