From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by sourceware.org (Postfix) with ESMTPS id C34383858C54 for ; Wed, 7 Jun 2023 06:53:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C34383858C54 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-yb1-xb2b.google.com with SMTP id 3f1490d57ef6-ba81f71dfefso8070459276.0 for ; Tue, 06 Jun 2023 23:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686120817; x=1688712817; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tB/bWEN56vICSydNkmcs6qC/GfzTQpODKUxr3f5u2hU=; b=ajWMJYv+TIjQIEvhwf98WHyTFSpxg36xQs92d69RR3zh8yUDcMXnkw2TAfEeF3GdZA 9pzsBTuGep+RvcJv5OFUWBxjOEBIYp5x+FuC0ACUWGEfgO0wu4xIuYx6qSkQ7fGLwAz/ m6aaXH7if3WWS8ckMbYnN69HRt8wJsdr5kZeU+F8lDvz6NwdGDhnaZ0ljS/6YdTiVK6m 3IHz7/m0is9nRPWMqjwNJicDjDK0lSuH6+Q2ixpq47PwTEG9cazzprTgYj3+B7pqjRzJ WScEUgdAdAxgwwIa69hS3R64vaCF6FnWydoX7unplBu5X9pVVD3kcfIak78YBoH4OITd 9X5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686120817; x=1688712817; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tB/bWEN56vICSydNkmcs6qC/GfzTQpODKUxr3f5u2hU=; b=ILS0Kpx7Cxd/GGEKDMqzhuHu57AlGeGw9R0HGNw6ERJy3NhOMlyNMwOmZmTzVEbxCR GuNfRq+5QjfHke0OxyyTQkRp63QzcMdC504cppvsNB9fkfbSIgqdLw9rR5jnTZ4CKJOE u5Hm/Ga8jPu8IkfqRb611AiwbJd3mKkHXNmUtv+//kHwFI3+lkpemAuG51X0AW9wpQ2K 2gc+ezNOTpcpef8QzdWV9mBBxgVVJElElT1F3liveqYofPbTJ9SBj/ektOXmriEUAuTQ jx/IR8yWRsrc3PW/OqfIIsWC9NbYELQRQarkHpQWZT2T9taa39ZR83ggmLgaLM9v8a/C 50zw== X-Gm-Message-State: AC+VfDwQ2BWinJDpxmAMGK6NgLF4xn814HUPV8EZSmB9mR7/yw9oOZMz iXi9QMqfqOKz0m6ueRuuVn9aB0itHy/+cpEm5SikMw== X-Google-Smtp-Source: ACHHUZ6q3RnR5dsSEJE80mIS9gb0/YHVMmt+afyxNPGxs6Op2ePAx2/AR3tYwk1fjb5GAdXwhbzgs84kqFl2sxO/KTI= X-Received: by 2002:a25:25d7:0:b0:b9a:7df5:4f26 with SMTP id l206-20020a2525d7000000b00b9a7df54f26mr5001584ybl.30.1686120816935; Tue, 06 Jun 2023 23:53:36 -0700 (PDT) MIME-Version: 1.0 References: <20230606085132.1894137-3-maennich@google.com> In-Reply-To: <20230606085132.1894137-3-maennich@google.com> From: Giuliano Procida Date: Wed, 7 Jun 2023 07:52:59 +0100 Message-ID: Subject: Re: [PATCH 1/2] symtab reader: use C++11 `using` syntax instead of typedefs To: =?UTF-8?Q?Matthias_M=C3=A4nnich?= Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-25.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 6 Jun 2023 at 09:52, Matthias M=C3=A4nnich wr= ote: > > From: Matthias Maennich > > That is to increase readability and to incrementally modernize the code b= ase. > > * abg-symtab-reader.h: replace typedefs by corresponding using > declarations. > > Signed-off-by: Matthias Maennich Reviewed-by: Giuliano Procida > --- > src/abg-symtab-reader.h | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/src/abg-symtab-reader.h b/src/abg-symtab-reader.h > index 2e13e7f9976f..7477cca5a6f0 100644 > --- a/src/abg-symtab-reader.h > +++ b/src/abg-symtab-reader.h > @@ -99,7 +99,7 @@ private: > /// Base iterator for our custom iterator based on whatever the const_it= erator > /// is for a vector of symbols. > /// As of writing this, std::vector::const_iterator. > -typedef elf_symbols::const_iterator base_iterator; > +using base_iterator =3D elf_symbols::const_iterator; > > /// An iterator to walk a vector of elf_symbols filtered by symtab_filte= r. > /// > @@ -110,11 +110,11 @@ typedef elf_symbols::const_iterator base_iterator; > class symtab_iterator : public base_iterator > { > public: > - typedef base_iterator::value_type value_type; > - typedef base_iterator::reference reference; > - typedef base_iterator::pointer pointer; > - typedef base_iterator::difference_type difference_type; > - typedef std::forward_iterator_tag iterator_category; > + using value_type =3D base_iterator::value_type; > + using reference =3D base_iterator::reference; > + using pointer =3D base_iterator::pointer; > + using difference_type =3D base_iterator::difference_type; > + using iterator_category =3D std::forward_iterator_tag; > > /// Construct the iterator based on a pair of underlying iterators and= a > /// symtab_filter object. Immediately fast forward to the next element= that > @@ -172,7 +172,7 @@ private: > > /// Convenience declaration of a unique_ptr > class symtab; > -typedef std::unique_ptr symtab_ptr; > +using symtab_ptr =3D std::unique_ptr; > > /// symtab is the actual data container of the symtab_reader implementat= ion. > /// > @@ -201,7 +201,7 @@ typedef std::unique_ptr symtab_ptr; > class symtab > { > public: > - typedef std::function symbol_predicate; > + using symbol_predicate =3D std::function= ; > > /// Indicate whether any (kernel) symbols have been seen at constructi= on. > /// > @@ -215,7 +215,7 @@ public: > > /// The (only) iterator type we offer is a const_iterator implemented = by the > /// symtab_iterator. > - typedef symtab_iterator const_iterator; > + using const_iterator =3D symtab_iterator; > > /// Obtain an iterator to the beginning of the symtab according to the= filter > /// criteria. Whenever this iterator advances, it skips elements that = do not > @@ -271,12 +271,12 @@ private: > bool has_ksymtab_entries_; > > /// Lookup map name->symbol(s) > - typedef std::unordered_map> > - name_symbol_map_type; > + using name_symbol_map_type =3D > + std::unordered_map>; > name_symbol_map_type name_symbol_map_; > > /// Lookup map addr->symbol > - typedef std::unordered_map addr_symbol_map= _type; > + using addr_symbol_map_type =3D std::unordered_map; > addr_symbol_map_type addr_symbol_map_; > > /// Lookup map function entry address -> symbol > -- > 2.41.0.rc0.172.g3f132b7071-goog >