From: Giuliano Procida <gprocida@google.com>
To: libabigail@sourceware.org
Cc: "Dodji Seketeli" <dodji@seketeli.org>,
kernel-team@android.com, "Matthias Männich" <maennich@google.com>
Subject: Re: [PATCH 3/3] test24-soname-suppr*txt: Fix suppression syntax.
Date: Mon, 20 Apr 2020 18:20:29 +0100 [thread overview]
Message-ID: <CAGvU0HmBJknjpF3k-12Ben+qzzPZtXVNN_-scZJERpceaWiuKQ@mail.gmail.com> (raw)
In-Reply-To: <20200420164153.5213-3-gprocida@google.com>
v2 of this on the way - more typos found
On Mon, 20 Apr 2020 at 17:42, Giuliano Procida <gprocida@google.com> wrote:
>
> The property name "reached_through" should have been
> "accessed_through".
>
> * tests/data/test-diff-suppr/test24-soname-suppr-0.txt: Fix
> typo, change "reached_through" to "accessed_through".
> * tests/data/test-diff-suppr/test24-soname-suppr-1.txt: Ditto.
> * tests/data/test-diff-suppr/test24-soname-suppr-2.txt: Ditto.
> * tests/data/test-diff-suppr/test24-soname-suppr-3.txt: Ditto.
> * tests/data/test-diff-suppr/test24-soname-suppr-4.txt: Ditto.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
> ---
> tests/data/test-diff-suppr/test24-soname-suppr-0.txt | 2 +-
> tests/data/test-diff-suppr/test24-soname-suppr-1.txt | 2 +-
> tests/data/test-diff-suppr/test24-soname-suppr-2.txt | 2 +-
> tests/data/test-diff-suppr/test24-soname-suppr-3.txt | 2 +-
> tests/data/test-diff-suppr/test24-soname-suppr-4.txt | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-0.txt b/tests/data/test-diff-suppr/test24-soname-suppr-0.txt
> index 2fb72ef3..19125bc7 100644
> --- a/tests/data/test-diff-suppr/test24-soname-suppr-0.txt
> +++ b/tests/data/test-diff-suppr/test24-soname-suppr-0.txt
> @@ -2,4 +2,4 @@
> soname_regexp = ^libtest24-soname$
> name = S
> type_kind = struct
> - reached_through = reference_or_pointer
> + accessed_through = reference_or_pointer
> diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-1.txt b/tests/data/test-diff-suppr/test24-soname-suppr-1.txt
> index 34ec72c0..a59000a5 100644
> --- a/tests/data/test-diff-suppr/test24-soname-suppr-1.txt
> +++ b/tests/data/test-diff-suppr/test24-soname-suppr-1.txt
> @@ -1,4 +1,4 @@
> [suppress_type]
> soname_regexp = ^libtest24-soname-<wrong-soname>$
> name = S
> - reached_through = reference_or_pointer
> + accessed_through = reference_or_pointer
> diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-2.txt b/tests/data/test-diff-suppr/test24-soname-suppr-2.txt
> index 65b50fbb..2c4b1fc9 100644
> --- a/tests/data/test-diff-suppr/test24-soname-suppr-2.txt
> +++ b/tests/data/test-diff-suppr/test24-soname-suppr-2.txt
> @@ -1,4 +1,4 @@
> [suppress_type]
> file_name_regexp = (^|/)libtest24-soname-v0\\.so$
> name = S
> - reached_through = reference_or_pointer
> + accessed_through = reference_or_pointer
> diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-3.txt b/tests/data/test-diff-suppr/test24-soname-suppr-3.txt
> index f72fd141..e1c299ac 100644
> --- a/tests/data/test-diff-suppr/test24-soname-suppr-3.txt
> +++ b/tests/data/test-diff-suppr/test24-soname-suppr-3.txt
> @@ -1,4 +1,4 @@
> [suppress_type]
> file_name_regexp = (^|/)libtest24-soname-v1\\.so$
> name = S
> - reached_through = reference_or_pointer
> + accessed_through = reference_or_pointer
> diff --git a/tests/data/test-diff-suppr/test24-soname-suppr-4.txt b/tests/data/test-diff-suppr/test24-soname-suppr-4.txt
> index 29a0b6ec..01cd9f0b 100644
> --- a/tests/data/test-diff-suppr/test24-soname-suppr-4.txt
> +++ b/tests/data/test-diff-suppr/test24-soname-suppr-4.txt
> @@ -1,4 +1,4 @@
> [suppress_type]
> file_name_regexp = (^|/)libtest24-soname-<wrong-file-name>\\.so$
> name = S
> - reached_through = reference_or_pointer
> + accessed_through = reference_or_pointer
> --
> 2.26.1.301.g55bc3eb7cb9-goog
>
next prev parent reply other threads:[~2020-04-20 17:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 16:41 [PATCH 1/3] test-diff-suppr: Improve regexes in tests Giuliano Procida
2020-04-20 16:41 ` [PATCH 2/3] test35-leaf.suppr: fix regex typo Giuliano Procida
2020-04-21 10:20 ` Matthias Maennich
2020-04-22 13:56 ` Dodji Seketeli
2020-04-20 16:41 ` [PATCH 3/3] test24-soname-suppr*txt: Fix suppression syntax Giuliano Procida
2020-04-20 17:20 ` Giuliano Procida [this message]
2020-04-20 17:23 ` [PATCH 3/3 v2] " Giuliano Procida
2020-04-21 10:24 ` Matthias Maennich
2020-04-22 15:05 ` Dodji Seketeli
2020-04-21 10:19 ` [PATCH 1/3] test-diff-suppr: Improve regexes in tests Matthias Maennich
2020-04-21 10:57 ` Giuliano Procida
2020-04-22 13:48 ` Dodji Seketeli
2020-04-22 19:11 ` Giuliano Procida
2020-05-01 15:56 ` Giuliano Procida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGvU0HmBJknjpF3k-12Ben+qzzPZtXVNN_-scZJERpceaWiuKQ@mail.gmail.com \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).