From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by sourceware.org (Postfix) with ESMTPS id 2B9183851C05 for ; Wed, 13 May 2020 15:56:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B9183851C05 Received: by mail-io1-xd44.google.com with SMTP id u11so18592051iow.4 for ; Wed, 13 May 2020 08:56:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sUi+XUG69wRcZgKjVy+XjBO6aBKiHxM1Z/dniJwXmqs=; b=GSXdDBJOLDJKjgHkC72UHERk/IQXWt4/Jburwx1hvBJIDbcxstdWobUWWJXFmq/5kB OsbOGHK8W+uKLsOj0lU2f4Ykqk/reWULKq5/zX3avFUfaF9rK50TvlEgDDdyBXrkhfLq Ch37GquamPbIRMTBfKETDatCuE8pFL28yXi29qOyON37dmMGgOO7kh0WgjpmRvlNxdwd IOO4RnSgs0EDRjh90xlAi67g6Ty1n0ndU1DGmL7L0hmHg+MWYkmtMS1Mh9TGYhzPSITF YP5vSd3X0g1PuN8O0gP/bdmYlSO80DMcrDTrEKjibYHHbQcrpipDI11su0nGk5JXVZ+d Oc5w== X-Gm-Message-State: AGi0PubsqAP3AOEGkCVhaIxn8OCB0xlf8gFaZwWctSApSrAGYCnSSf7c IZ6DhLH6KuwPCr5D2v7xOP4LqRh3X3dm3LVCjueYK6PkOAU= X-Google-Smtp-Source: APiQypI3brAo17At4zGJihiFV1u73D/8/9y9TKGr3Pd2noIH4Hccfe4DaoJhe1k7guRWLYJmFiOc/R4dcGkLdmzoDCM= X-Received: by 2002:a02:a608:: with SMTP id c8mr187045jam.95.1589385378439; Wed, 13 May 2020 08:56:18 -0700 (PDT) MIME-Version: 1.0 References: <20200504162439.74028-1-gprocida@google.com> <20200504162439.74028-2-gprocida@google.com> <86mu6ccbwq.fsf@seketeli.org> In-Reply-To: <86mu6ccbwq.fsf@seketeli.org> From: Giuliano Procida Date: Wed, 13 May 2020 16:56:01 +0100 Message-ID: Subject: Re: [PATCH 1/3] abidiff.cc: tidy using directives and declarations To: Dodji Seketeli Cc: libabigail@sourceware.org, kernel-team@android.com, =?UTF-8?Q?Matthias_M=C3=A4nnich?= X-Spam-Status: No, score=-25.6 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2020 15:56:21 -0000 Hi. On Wed, 13 May 2020 at 12:27, Dodji Seketeli wrote: > Giuliano Procida a =C3=A9crit: > > > This patch replaces a using directive with a couple of specific using > > declarations, moves a couple of globally-scoped using declarations to > > the top of the file and alphabetically sorts all the using > > declarations. > > Are these kinds of patches really necessary? I mean, I am not sure why > this kind of sorting is useful. Besides, it adds unnecessary noise to > the history, making "git blame" less useful. > > Just like for the #include patch earlier, I am not for enforcing > alphabetical sorting for of the using declarations accross the project. > > Or am I missing something? > Thanks for calling this out, it deserves some discussion. I should have put more justification into the commit message. I think this comes from a couple of things. Firstly, it is part of an internal coding standard that has received thousands of hours of review and has been tested on very large scale code bases. We probably follow parts of it by habit. Not all of it makes sense outside of Google (where there a lot more than the Standard Library is available and we have linting tools that help enforce compliance), but a lot does and quite a bit will be non-controversial. The external version is https://google.github.io/styleguide/cppguide.html and includes rationales. Secondly, I was asked to do this in a review comment. This is probably just the point above, by proxy, but it could be Matthias following his own internal or some other style guide. I think the right thing to do (initially) is to push back and say "this is not Google" in the cases where there's no benefit. You may want to consider adopting or adapting some of the style guide, where you feel it would be a good match for the project, and brings some value (such as increased readability, safety or performance). Do let me know if I should drop this change and fix up the remaining ones. Thanks! Regards, Giuliano. > Cheers, > > -- > Dodji > > -- > To unsubscribe from this group and stop receiving emails from it, send an > email to kernel-team+unsubscribe@android.com. > >