From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 7AB9B3858D32 for ; Thu, 13 Apr 2023 17:13:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7AB9B3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-wr1-x430.google.com with SMTP id e7so4848186wrc.12 for ; Thu, 13 Apr 2023 10:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681405979; x=1683997979; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=C+FOcVtrauGavkqeapsQUvV5l07pjdAtC6oPi4RZzFQ=; b=j+VH1iNZWqjXmS3+7tDbVgP7esu3h0D3XU1Saiv5tHD3GyBEL6bC7b4Vd8TJhw0QOq vxqeFGmDVT0cxNiSksBRym6+FwYAx/WesPAfJ2s2jz8MKUDhoX+WpEqAZyMXmAaydjRw gQ2g46UH+N60ApsGFv8BY70yyg4XYVVZO1+A/SqshPGNuA24Ta56ZFklWVQX0HgYF5J2 S9BXyXuybF93xBK+djOI9rpfpWTSpVud8k5mlMzKkwVR8iBP+doSh7/86dcvhF4mQJPE L51Xqw1UGbY3GlC3dZ457WZWuieCxZRG1aOTvgIuxv3o7FZMUzBY0IPt+++ZDHZ0uT3V /npg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681405979; x=1683997979; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C+FOcVtrauGavkqeapsQUvV5l07pjdAtC6oPi4RZzFQ=; b=joQpbEk2mM/JTvDb04TBFUOD6fXDzvD6u3RjY1hu28jnQ2s+ofHZJ+dYK4jGhbYaHd ze5+JLipCRhp192+VhzLigpa/yoTsXhzlPj6xOfNGYflt8wM/eUZo8d2tx8iY89KdIKb g/4FCtMFAVNpsZZYRWBqUclE6Az2EZL+8jCldvPp7JjnMEKjCqN5OBIpTXTGnDSTGMvD LgUCH3J3GWOq0LwsOk4UeH3oXx8Mj8KwxaL8YZ3SzOA6iikxYX8Q91SbNj0Ctce5qoL9 3RL/2J2mUhQzPQOJnbmb+Q6APT9iuhvf/FIqnmpHHEKoEBiIoeHPqvpxVWH+S8qnfwgv CfPg== X-Gm-Message-State: AAQBX9cefxpb+4jvngqyqJOeO92eGcr649aotGCD9bcJ5UozdA2vCzIn Yyk68Cfuj1eBdfsGNgFh3p454/DGbogjse+g1vELsQ== X-Google-Smtp-Source: AKy350bTQbDoNKIbxE6adRwcuataNMOj/xqDkMYGf4f4RKRZ4x5eVnwYFxjdMKI9fwBPSmKo0RM78CmlM1i63DavlsA= X-Received: by 2002:a5d:4b87:0:b0:2f1:c72f:fa43 with SMTP id b7-20020a5d4b87000000b002f1c72ffa43mr547318wrt.14.1681405979130; Thu, 13 Apr 2023 10:12:59 -0700 (PDT) MIME-Version: 1.0 References: <20230407203456.27141-1-quic_johmoo@quicinc.com> <20230407203456.27141-2-quic_johmoo@quicinc.com> <2023041015-lunar-dandelion-1b4e@gregkh> <2023041136-donator-faceplate-5f91@gregkh> <2023041209-armed-overlaid-3d3d@gregkh> <718c102205750a00b86e8d33748e9bfb3c485ee1.camel@klomp.org> In-Reply-To: <718c102205750a00b86e8d33748e9bfb3c485ee1.camel@klomp.org> From: Giuliano Procida Date: Thu, 13 Apr 2023 18:12:21 +0100 Message-ID: Subject: Re: [PATCH v5 1/2] check-uapi: Introduce check-uapi.sh To: Mark Wielaard Cc: John Moon , Greg Kroah-Hartman , Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , kernel-team@android.com, libabigail@sourceware.org, Jordan Crouse , Trilok Soni , Satya Durga Srinivasu Prabhala , Elliot Berman , Guru Das Srinagesh Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-21.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi all. On Thu, 13 Apr 2023 at 15:37, Mark Wielaard wrote: > > Hi, > > On Wed, 2023-04-12 at 09:37 -0700, John Moon via Libabigail wrote: > > On 4/11/2023 11:14 PM, Greg Kroah-Hartman wrote: > > > > Would you find the tool more useful if it simply filtered out all instances > > > > where the size of the type did not change? This would filter out the > > > > following which the tool currently flags: > > > > > > > > - enum expansions > > > > - reserved field expansions > > > > - expansions of a struct with a flex array at the end > > > > - type changes > > > > - re-ordering of existing members > > > > - ...others? > > > > > > Obviously not, as some of those are real breakages, and some are not at > > > all. > > > > > > Please understand what is an abi breakage. Adding new enums is not. > > > Using a reserved field is not. Reording existing members IS. > > > > > > > Yes, understood that method would miss certain classes of breakages. I > > was suggesting it as a way to improve the signal-to-noise ratio of the > > tool since we don't currently have an algorithm for determining > > breakages with 100% accuracy. > > Note that you can check the exit code of libabigail's abidiff to see > whether something is an incompatible abi change or not, see: > https://sourceware.org/libabigail/manual/abidiff.html#return-values > > You can also of course use suppressions to instruct abidiff to avoid > reporting changes involving certain ABI artifacts: > https://sourceware.org/libabigail/manual/libabigail-concepts.html#suppr-spec-label libabigail's abidiff already hides certain differences by default. You can turn this behaviour off with --harmless. Note that abidiff without --harmless treats certain ABI differences asymmetrically, hiding them one way around but not the other. The ABI diff tool I designed for Android always treats differences symmetrically and will only suppress certain kinds of diff if specially requested (which we don't do any more in production). [Technically, we also ignore qualifier changes on function parameter and return types, but we achieve that by stripping them out unconditionally.] Once we get around to UAPI monitoring, we'll do the same there. We can always review the SNR later. Regards, Giuliano. > Cheers, > > Mark > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >