From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by sourceware.org (Postfix) with ESMTPS id CF279398B425 for ; Fri, 12 Mar 2021 09:39:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CF279398B425 Received: by mail-vs1-xe29.google.com with SMTP id f1so2069264vsl.0 for ; Fri, 12 Mar 2021 01:39:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UwuETCFwxbnNyvAlACp17W6GDesDKv/ra0qBbVWP+rk=; b=udRem6gaOjL+suJ6H4NyKcM03UhBVOYnRWQXk6KxmIIdsnFPj62wjM2PGcFjIf+pO6 yl2KDSmO23iPMEfDEZqnUXmLyKo9SoOJoxsftTU/QZxqc0GK9t08sTDuJbCyicnFqHuh CbPQ/KNWaUj9CN1mpczLIIYjjjDGbTO1YNZbxwk4W3xTt5wi+XVPf7ymNW7ppdeFMu0I sWI8BnvXGySVl+4QXk2+IxDFU0PBigiBCmX9sY7Ek1q+BlaMLA8q3GTG3eZVo4j2h9Fy imFFJwuZF+a0bkyDWUIhG8EyzcjaZBJTeLcEB0UbT4NLAcB05PAOE+/rozrYZ7nAZpra HCLQ== X-Gm-Message-State: AOAM530YO4v+rAjQsuYDcMJoyLQUiOcBz8eImMfNEzrgXclrE3eKHHbo C5UjRtYOdsM56N0YJeDXmI37tylAyEB7Q0dnxt5Qbg== X-Google-Smtp-Source: ABdhPJwxcsYdMChdfxVSHBdKH+u0qxUB1FE5h/yH3wMFbA5WQ3swtf5soUhsfjStf07OwogdAXtu2gLo4USC42oweFA= X-Received: by 2002:a67:eb99:: with SMTP id e25mr7582807vso.24.1615541998130; Fri, 12 Mar 2021 01:39:58 -0800 (PST) MIME-Version: 1.0 References: <20210310122254.2860952-1-gprocida@google.com> <6fb8e0f870686efc61715588510cccb70aa05eff.camel@klomp.org> In-Reply-To: <6fb8e0f870686efc61715588510cccb70aa05eff.camel@klomp.org> From: Giuliano Procida Date: Fri, 12 Mar 2021 09:39:21 +0000 Message-ID: Subject: Re: [PATCH] DWARF reader: Comment ARM32 ELF address interpretation To: Mark Wielaard Cc: Giuliano Procida via Libabigail , Dodji Seketeli , kernel-team@android.com, =?UTF-8?Q?Matthias_M=C3=A4nnich?= X-Spam-Status: No, score=-23.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2021 09:40:00 -0000 Hi. On Thu, 11 Mar 2021 at 17:16, Mark Wielaard wrote: > Hi, > > On Wed, 2021-03-10 at 12:22 +0000, Giuliano Procida wrote: > > Bug 27552 - libabigail needs to interpret ARM32 symbol addresses > > specially > > BTW. I tried to get this correct for elfutils when using the libdwfl > dwfl_module_addrsym and dwfl_module_addrinfo functions: > https://sourceware.org/bugzilla/show_bug.cgi?id=27564 > Has a proposed patch that needs a bit more testing (and maybe a tweak). > > Having a library layer that does all the fixups seems a lot better than having the logic in libabigail. > libabigail doesn't use these functions, but one benefit of them is that > they also handle the case of ppc function descriptors (that is old > style ppc32 and ppc64be). > > Hopefully, they are relatively straightforward to drop in. However, Matthias has symbol table reader changes still queued up; once these are done, we can take a look. libabibgail would become dependent on libdwfl version >= X for correctness, so we'd need to assert that at compile time. Thanks, Giuliano. > Cheers, > > Mark >