From: Giuliano Procida <gprocida@google.com>
To: Dodji Seketeli <dodji@seketeli.org>
Cc: Matthias Maennich <maennich@google.com>,
libabigail@sourceware.org, kernel-team@android.com
Subject: Re: [PATCH 2/2] abidiff: Fix anonymous member size change reports.
Date: Tue, 7 Apr 2020 22:31:56 +0100 [thread overview]
Message-ID: <CAGvU0Hnp0qQ=VQxr_yLECAEemFM497DqT+d=PABm_Qdy4sza9A@mail.gmail.com> (raw)
In-Reply-To: <877dyrpfgw.fsf@seketeli.org>
Agreed.
I spotted this on rebase.
On Tue, 7 Apr 2020 at 14:56, Dodji Seketeli <dodji@seketeli.org> wrote:
>
> Matthias Maennich <maennich@google.com> a écrit:
>
> [...]
>
> >
> > This broke one test case on my machine, that needs trivial adjusting:
> >
> > test-leaf-peeling-report-indirect.txt:
> >
> > | @@ -9,7 +9,6 @@
> > | type 'int' of 'foo::z' changed:
> > | type name changed from 'int' to 'long int'
> > | type size changed from 32 to 64 (in bits)
> > | - and size changed from 32 to 64 (in bits) (by +32 bits)
> > |
> > | 'struct ops1 at test-leaf-peeling-v0.cc:5:1' changed:
> > | type size hasn't changed
> > | FAIL runtestabidiffexit (exit status: 1)
>
> Right. Also, I think you'll need to rebase this patch on top of current
> master as I have committed a patch from you that renames
> test-abidiff-exit/test-leaf1-report.txt.
>
> Thanks.
>
> Cheers,
>
> --
> Dodji
>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
>
next prev parent reply other threads:[~2020-04-07 21:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 21:53 [PATCH 1/2] abidiff: More compact references to prior diffs Giuliano Procida
2020-04-03 21:53 ` [PATCH 2/2] abidiff: Fix anonymous member size change reports Giuliano Procida
2020-04-06 16:08 ` Matthias Maennich
2020-04-07 13:55 ` Dodji Seketeli
2020-04-07 21:31 ` Giuliano Procida [this message]
2020-04-07 21:45 ` Giuliano Procida
2020-04-06 15:29 ` [PATCH 1/2] abidiff: More compact references to prior diffs Matthias Maennich
2020-04-07 13:47 ` Dodji Seketeli
2020-04-07 21:32 ` Giuliano Procida
2020-04-07 21:33 ` [PATCH v2 " Giuliano Procida
2020-04-07 21:33 ` [PATCH v2 2/2] abidiff: Fix anonymous member size change reports Giuliano Procida
2020-04-14 10:42 ` Dodji Seketeli
2020-04-14 10:42 ` [PATCH v2 1/2] abidiff: More compact references to prior diffs Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGvU0Hnp0qQ=VQxr_yLECAEemFM497DqT+d=PABm_Qdy4sza9A@mail.gmail.com' \
--to=gprocida@google.com \
--cc=dodji@seketeli.org \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).