From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by sourceware.org (Postfix) with ESMTPS id 7CC533887006 for ; Tue, 7 Apr 2020 21:32:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7CC533887006 Received: by mail-il1-x144.google.com with SMTP id j69so4720640ila.11 for ; Tue, 07 Apr 2020 14:32:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=OPTbuN04Bx4KJhTM+7kdpMZ/WuqryaGiuAqXBtEDWbg=; b=ejlCdTJKXbFOj0CyJiHJmUcfMnOgZDPPTC0jEZwg4TCHNCOSBDPptDLuGTUWhIOUwA 2kd870J3eFmEa9cSR8RvSGB5ogfAUEaUgVh1CRJXQmglqHuYdNmB9U3SVmTUSiRqSsV7 B95NjgE3xgupXksMo83fxjszHuT8Xwb/f7EQYYhbCbfaMrBdZX5zu/vvAj9QtkLk+pW/ 7hkY5XHIKhreLAWQ3Pe+gbOgrsJqr0QCE9KLnEW0QvmefcfkDJR+ZCqfJFNuBdP7fXVY nBaioaNgJ7kv1I0vlE5GluCOPBep5itZDwTmi4CCz7b9lwya5Z5Vu9LDA8X1SQ7ngq34 OkeA== X-Gm-Message-State: AGi0PuauWSAY114kMxdGXmVgvQKIBODMbUsJ5+SCYQ4eOOlI9Ky0gDa+ BIiJ9Gz7bYdT2CkjyCsP0/whcfBG5P9ZOkw8r2MxEw== X-Google-Smtp-Source: APiQypJ4MTsVWnBdaBFElqgapGLAct89AqoeDBhWicS+NtAShxawQSlLU73BTDZmPtHfI847cmiLAe07WGoS3Pnw7yU= X-Received: by 2002:a92:24f:: with SMTP id 76mr4778669ilc.178.1586295133777; Tue, 07 Apr 2020 14:32:13 -0700 (PDT) MIME-Version: 1.0 References: <20200403215356.186742-1-gprocida@google.com> <20200403215356.186742-2-gprocida@google.com> <20200406160831.GB189388@google.com> <877dyrpfgw.fsf@seketeli.org> In-Reply-To: <877dyrpfgw.fsf@seketeli.org> From: Giuliano Procida Date: Tue, 7 Apr 2020 22:31:56 +0100 Message-ID: Subject: Re: [PATCH 2/2] abidiff: Fix anonymous member size change reports. To: Dodji Seketeli Cc: Matthias Maennich , libabigail@sourceware.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-26.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libabigail mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 21:32:15 -0000 Agreed. I spotted this on rebase. On Tue, 7 Apr 2020 at 14:56, Dodji Seketeli wrote: > > Matthias Maennich a =C3=A9crit: > > [...] > > > > > This broke one test case on my machine, that needs trivial adjusting: > > > > test-leaf-peeling-report-indirect.txt: > > > > | @@ -9,7 +9,6 @@ > > | type 'int' of 'foo::z' changed: > > | type name changed from 'int' to 'long int' > > | type size changed from 32 to 64 (in bits) > > | - and size changed from 32 to 64 (in bits) (by +32 bits) > > | > > | 'struct ops1 at test-leaf-peeling-v0.cc:5:1' changed: > > | type size hasn't changed > > | FAIL runtestabidiffexit (exit status: 1) > > Right. Also, I think you'll need to rebase this patch on top of current > master as I have committed a patch from you that renames > test-abidiff-exit/test-leaf1-report.txt. > > Thanks. > > Cheers, > > -- > Dodji > > -- > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >