From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 9E5CC3989085 for ; Thu, 15 Jul 2021 16:21:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9E5CC3989085 Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-B86dEXzlMQONbjtJUTL1WA-1; Thu, 15 Jul 2021 12:21:13 -0400 X-MC-Unique: B86dEXzlMQONbjtJUTL1WA-1 Received: by mail-ua1-f72.google.com with SMTP id x1-20020ab038010000b02902a206a03857so1998410uav.3 for ; Thu, 15 Jul 2021 09:21:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FQ2qz6KCyJt8/1pLfnVfYCVHbCsJ/y5G6ay7/ddBp1M=; b=PLLN/ZiXTQ59usyWRKmwMO1P4h/Krz4WLDVlPggep3WhjdWG/Z8Lj6HxwTJzgBn2L5 rg9BogReRSPV7Uu0LyIWwTiH13MFDfb6eP/5v2074LjOrE9RZRe/JQmScfX5KZGyVAq4 wcSnfALGAh7mXLLmPPt5rFLd0LlMHZxdk+A8VH9EwNLcXeoOlWmAatijl8+m5zLK8tou hQu9USRwiBKOX0/9+HO3xfl8ihKiElnMUxxCj7+YtN+lMI2jzLkFXTV1uH/Hrm9QwbfE yaqVIZEVgomkDmyAQnsLq4DfgBrq5CF2vecsUPwryhfZcbZ1Ds6ZjtvwuFS8KlF7kD+z 2iOQ== X-Gm-Message-State: AOAM530auTVzpEK+2V9lYF4fi/jBPzHZq5G+N4EB7Ie/OhSxsFRAWkYH G5F2DhI1BDDC3FHay8XtQ8QGDh3K9qgEKyymOmNZrR+jhlIY33TuIHWZsEbhk1Sy/uw9Tn2PbL+ MWnbgcy2oWwzbwSdnfph3EhGR+y06nU/TkfAY X-Received: by 2002:ab0:7e94:: with SMTP id j20mr8247893uax.87.1626366073372; Thu, 15 Jul 2021 09:21:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxVqd5uVQaPO82WzU5gVqmKs5fw9xUWtWi1I/CcgX6Hekuq2/N4aY1Yk7IulNuR3sdgTfD1mIORtOfUJanTjY= X-Received: by 2002:ab0:7e94:: with SMTP id j20mr8247869uax.87.1626366073167; Thu, 15 Jul 2021 09:21:13 -0700 (PDT) MIME-Version: 1.0 References: <20210709231649.2969609-2-gprocida@google.com> <20210710165232.3071638-1-gprocida@google.com> In-Reply-To: <20210710165232.3071638-1-gprocida@google.com> From: David Marchand Date: Thu, 15 Jul 2021 18:21:01 +0200 Message-ID: Subject: Re: [PATCH v2] DWARF reader: fix bitfield offset calculations To: Giuliano Procida Cc: libabigail@sourceware.org, Dodji Seketeli , kernel-team@android.com, maennich@google.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2021 16:21:19 -0000 On Sat, Jul 10, 2021 at 6:52 PM Giuliano Procida wrote: > > PR28060 - Invalid offset for bitfields > > Bitfield and other member offsets can be specified in DWARF using: > > - DW_AT_data_bit_offset, or > - DW_AT_data_member_location and optionally DW_AT_bit_offset. > > The code would only use the value DW_AT_data_member_location if there > was no DW_AT_bit_offset. This commit fixes this and adjusts > documentation and affected tests. > > * src/abg-dwarf-reader.cc (read_and_convert_DW_at_bit_offset): > Update documentation. > (die_member_offset): Treat DW_AT_bit_offset as an optional > adjustment to DW_AT_data_member_location. > * tests/data/test-annotate/test13-pr18894.so.abi: Update. > * tests/data/test-annotate/test15-pr18892.so.abi: Update. > * tests/data/test-annotate/test17-pr19027.so.abi: Update. > * tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi: > Update. > * tests/data/test-annotate/test21-pr19092.so.abi: Update. > * tests/data/test-diff-dwarf-abixml/PR25409-librte_bus_dpaa.so.20.0.abi: > Regenerate. > * tests/data/test-diff-pkg/libcdio-0.94-1.fc26.x86_64--libcdio-0.94-2.fc26.x86_64-report.1.txt: > Report now empty. > * tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Update. > * tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi: > Update. > * tests/data/test-read-dwarf/test13-pr18894.so.abi: Update. > * tests/data/test-read-dwarf/test15-pr18892.so.abi: Update. > * tests/data/test-read-dwarf/test17-pr19027.so.abi: Update. > * tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi: > Update. > * tests/data/test-read-dwarf/test21-pr19092.so.abi: Update. > * tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi: > Update. > > Signed-off-by: Giuliano Procida Forgot to send: Tested-by: David Marchand Thanks for the fix. -- David Marchand