From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by sourceware.org (Postfix) with ESMTPS id 4C8EB3858C29 for ; Fri, 22 Dec 2023 17:57:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C8EB3858C29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4C8EB3858C29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=139.178.84.217 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703267859; cv=none; b=cURrPvmGtHYisuJ/45zvMdu0U+oV8edTRbBOkDw+CQomNXR5x4SIZAYkJfDhCR4Ej/uRlf2hkz36dGlRLiAAdEfqrGV4k1j3MUwN6pi+QlddtuTmpkgPeU5D7curOJnVN/c9aT16hXcMvVnmTvErgifAhYUdfRbNy+zKv9QCPug= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703267859; c=relaxed/simple; bh=m4PmBJoc2QgJBZKQaB/vYcP8WBPPEuhKuwezCH8Kcrw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=DNqycXeMuPX3dNs3qKiPN9ccUeMQbhTvrzihLQOEQIhd8+yInJ96eEkbemscAgR7ZAiiPymD7qMNp1qRSGcHYy9SMxF4ntyIdYFos1HckLRD7rbxQV4yKc9QBTwdBaEiOIe9iKQWry2IsBayzbp2jRrIx6wfFER/w8apOquNhWk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DD8AF61B00 for ; Fri, 22 Dec 2023 17:57:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D4BCC433CB for ; Fri, 22 Dec 2023 17:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703267857; bh=m4PmBJoc2QgJBZKQaB/vYcP8WBPPEuhKuwezCH8Kcrw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=rtbQqxlUpwiNlXB65dGhn+BSi0lyJ6K4d26pR5L7WRilWt9ADVrB5Jfv26QgNKACp bOTJFDLgjG7+0frVS7XBHSETrNu6Q3tUJFtNdu2XAPOUVt0FgnnyiKk3f6ss7hxG62 yERCXVb6wWDY1El7z1Slpcd7bFXj4SFPquph1gi1y8G9k/4Zd6UfgffpLnhgSTCKdA 1BOxukP+hA7fw3TzfOgRPItsTCVwyh8F2muxPCLuUfzVscz5RXeDh7cbJ3txKZ5Vzi 82fS+Iz9dj1qs3eANeWJ5Vyi7oCTvFdj9DLewfGzuRLHZH6F8HcPy7NgijTdI7AJYl My4u/m4P0jGBA== Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-2041bb80cb3so1344063fac.2 for ; Fri, 22 Dec 2023 09:57:37 -0800 (PST) X-Gm-Message-State: AOJu0YwBta7khGdYFGLE2AfXTJ8qL++h2m7NvjIgT88+vmVNMkmqjw9x gknKw2SyXAXwcXklCenrEr9wa0lDrvk0nhHHirQ= X-Google-Smtp-Source: AGHT+IE3vXI8QLgM4TOkSSY7LCRj8PTha6F6b0XPpJWv+vhSS5keg8e+tn9GSrBNWa9DXTATrIftUFm+PiAfqJtIisM= X-Received: by 2002:a05:6871:a690:b0:1fa:1f3e:b8a7 with SMTP id wh16-20020a056871a69000b001fa1f3eb8a7mr1939357oab.20.1703267856913; Fri, 22 Dec 2023 09:57:36 -0800 (PST) MIME-Version: 1.0 References: <20231212020259.2451253-1-quic_johmoo@quicinc.com> <20231212020259.2451253-4-quic_johmoo@quicinc.com> <93ee22bc-b357-4291-b3d9-07ff2cd6c87b@quicinc.com> In-Reply-To: <93ee22bc-b357-4291-b3d9-07ff2cd6c87b@quicinc.com> From: Masahiro Yamada Date: Sat, 23 Dec 2023 02:57:00 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 3/3] check-module-params: Introduce check-module-params.sh To: John Moon Cc: Christoph Hellwig , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Jonathan Corbet , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, kernel@quicinc.com, Greg Kroah-Hartman , Rob Herring , "Carlos O'Donell" , Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , kernel-team@android.com, libabigail@sourceware.org, Dodji Seketeli , Trilok Soni , Satya Durga Srinivasu Prabhala , Jordan Crouse Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 13, 2023 at 1:58=E2=80=AFAM John Moon = wrote: > > On 12/11/2023 11:41 PM, Christoph Hellwig wrote: > > On Mon, Dec 11, 2023 at 06:02:59PM -0800, John Moon wrote: > >> One part of maintaining backwards compatibility with older > >> userspace programs is avoiding changes to module parameters. > > > > Really? I don't think module parameters are a UAPI in the traditional > > sense. > > Agreed, they're not UAPI in the traditional sense. But, we're trying to > establish tooling to help the community stabilize all interfaces that > cross the kernel <-> userspace boundary and module params do fall into > that bucket. > > > Now if you break a heavily used one you got to fix it, but > > applying strict stability guarantees on module options which are not > > availble to normal users or even normal programs doesn't make a whole > > lot of sense. > > > > True, but unfortunately we don't have any heuristic to determine if a > param is "heavily used". However, in this rev, we added the ability to > parse the permissions of a module param, so we could add a filter which > does not flag change/removal of params with 0{0,4,6}000 permissions. > > It's also obviously fine if the community has no interest in the script. > We just wanted to share it as we find it to be a useful supplement to > our code reviews and thought maintainers may find it useful as well. > > Cheers, > John I am with Christoph. This tool detects some changes and removals, but I think the community intentionally changed them. To merge this tool in the mainline, I need more people who are interested in this. --=20 Best Regards Masahiro Yamada