From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by sourceware.org (Postfix) with ESMTPS id 2A0923858D28 for ; Fri, 22 Dec 2023 17:51:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A0923858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A0923858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=139.178.84.217 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703267495; cv=none; b=WqoybeMnyAa7mbMO7m1iK3Bem1dE1HqKWSIyW6DRhaJI1pHemVPLl+sFSbt+NbPXN2UgnrhChRX8B4CqGGE3WBkIb4Je4Ah9MRrhpk5K+cn1dsMpEHy3lotevbdb54C6aLmDrkWa2DxDP/LlujrEt4gdXWuJsiEqj9M3Lw0V6nM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703267495; c=relaxed/simple; bh=XYkTLXz5sCIMHIvk5gdWCMmheYIQY9KRL0JQbfxvslI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=GadDmetWt/FqlJ0XVFVLBvOE3R+rsVxufNvLK2exMJ8GOFd0XcIkrHygttXdX2dfHt/MmFAAVvTjW4tRMyg7gpKpH90Px6BGM5KBi7o7R+nejtDCBUyS9Lftdns5DxU9KYMCzzm5d9gasVxF8NF5VRvwis9B8w8u9cnORwX7Cds= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CE64761CC6 for ; Fri, 22 Dec 2023 17:51:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CCEEC433CD for ; Fri, 22 Dec 2023 17:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703267492; bh=XYkTLXz5sCIMHIvk5gdWCMmheYIQY9KRL0JQbfxvslI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Nr2eYg5XhFfecvofEEo9kZFq7DfnsBe+/6hFphrLrcFbiu7c7WohO4GUR/jhpV7Ts Xs5eaKFHowaj6xgl+jE5q0jx0z/HNIQ1nct/VWhFEWzCDDp6Bm400mZA6T2psQRlOM Zf/WwftRTXv+6CRkT0KjsGSFsB89ORKE6xcGE9MEKiHj3ICkyds4QP3TVOt4PUQG3R nvZNHkj6BMBJKbx4RNR6UR5pVfiXQA/B+DL7UJgH3ngfbUW4p1AB5h4zzuPLDkbx6U T61IC0JFKzF6b2WWUY33j6Oj/lU04ASLBu/XPn32PgQ8gnxQpekD+3SEfx+z4+zdID 0wDD5qg/jSHFw== Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-6dbcc5d78eeso262668a34.3 for ; Fri, 22 Dec 2023 09:51:32 -0800 (PST) X-Gm-Message-State: AOJu0Yy99Jc3so76CibZVmt68G9PgNS2f57ASK5M6Se0xeWYuUTinzce Ma73qYbGXHhAhFFN2UDPpHhIloQlACuPhr2ucsY= X-Google-Smtp-Source: AGHT+IEdTqRIJ7Gv05JO4Bo5uaKKyusxndbX6ra2AjsNcR1TKiHk5jtMvR8vQ+0RXHbnQwbv3GodgDg+2HqbVSvskA0= X-Received: by 2002:a05:6870:b4a0:b0:204:5a14:c4c6 with SMTP id y32-20020a056870b4a000b002045a14c4c6mr340753oap.50.1703267491808; Fri, 22 Dec 2023 09:51:31 -0800 (PST) MIME-Version: 1.0 References: <20231212020259.2451253-1-quic_johmoo@quicinc.com> <20231212020259.2451253-2-quic_johmoo@quicinc.com> In-Reply-To: <20231212020259.2451253-2-quic_johmoo@quicinc.com> From: Masahiro Yamada Date: Sat, 23 Dec 2023 02:50:55 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 1/3] check-uapi: Introduce check-uapi.sh To: John Moon Cc: Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Jonathan Corbet , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, kernel@quicinc.com, Greg Kroah-Hartman , Rob Herring , "Carlos O'Donell" , Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , kernel-team@android.com, libabigail@sourceware.org, Dodji Seketeli , Trilok Soni , Satya Durga Srinivasu Prabhala , Jordan Crouse Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 12, 2023 at 11:04=E2=80=AFAM John Moon wrote: > > While the kernel community has been good at maintaining backwards > compatibility with kernel UAPIs, it would be helpful to have a tool > to check if a commit introduces changes that break backwards > compatibility. > > To that end, introduce check-uapi.sh: a simple shell script that > checks for changes to UAPI headers using libabigail. > > libabigail is "a framework which aims at helping developers and > software distributors to spot some ABI-related issues like interface > incompatibility in ELF shared libraries by performing a static > analysis of the ELF binaries at hand." > > The script uses one of libabigail's tools, "abidiff", to compile the > changed header before and after the commit to detect any changes. > > abidiff "compares the ABI of two shared libraries in ELF format. It > emits a meaningful report describing the differences between the two > ABIs." > > The script also includes the ability to check the compatibility of > all UAPI headers across commits. This allows developers to inspect > the stability of the UAPIs over time. > > Signed-off-by: John Moon > --- > - Applied minor code style suggestions from v6 review. The code looks OK. I think it should work as designed. Line 197 is inconsistently indented by spaces instead of a space, but I can fix it up locally. I just thought requiring target commits as positional parameters ("check-uapi.sh treeA treeB" just like "git diff treeA treeB") might be intuitive, but I guess everything is specified by a short option is a design. I can live with that. I will wait a few days, and if there is nothing more, I will pick up 1/3 and 2/3. --=20 Best Regards Masahiro Yamada