public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Ketan Patil <ketanp@nvidia.com>
To: "libabigail@sourceware.org" <libabigail@sourceware.org>
Cc: Sachin Nikam <Snikam@nvidia.com>, Nicolin Chen <nicolinc@nvidia.com>
Subject: abidw for non-exported structures
Date: Thu, 25 Feb 2021 11:25:53 +0000	[thread overview]
Message-ID: <CH2PR12MB415133134B58D7683E09DAF2AD9E9@CH2PR12MB4151.namprd12.prod.outlook.com> (raw)

Hi,

I was experimenting with abidw and abidiff tools to check ABI changes in linux kernel.
I had performed few experiments:

  1.  Changing exported structures:
     *   I changed few structures (added some dummy members in between) which were exported and build the kernel and created abi xml file using abidw tool.
     *   Then I compared this xml with the baseline xml (kernel without any changes) using abidiff tool and I found that it catches this ABI change.
  2.  Changing non-exported structures:
     *   I changed few non-exported structures e.g. struct dm_ioctl In https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/include/uapi/linux/dm-ioctl.h?h=v5.10.18
     *   This struct is being used by a number of ioctls. So I think, changing this struct should be flagged as an ABI change.
     *   Then I build the kernel and created the new abi xml file using abidw tool and compared with baseline xml using abidiff tool.
     *   abidiff tool is not able to catch this. Also, I don't see any entry for dm_ioctl in the xml generated using abidw.


Does it mean that, abidw tool does not work for the non exported symbols? If yes, are you planning to add this feature?
Can you please let me know or redirect?

Thanks,
Ketan Patil


             reply	other threads:[~2021-02-25 11:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 11:25 Ketan Patil [this message]
2021-02-25 13:41 ` Matthias Maennich
2021-03-03  7:15   ` Ketan Patil
2021-03-05 15:00     ` Sachin Nikam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH2PR12MB415133134B58D7683E09DAF2AD9E9@CH2PR12MB4151.namprd12.prod.outlook.com \
    --to=ketanp@nvidia.com \
    --cc=Snikam@nvidia.com \
    --cc=libabigail@sourceware.org \
    --cc=nicolinc@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).