From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2086.outbound.protection.outlook.com [40.107.244.86]) by sourceware.org (Postfix) with ESMTPS id 2FE2C3836C62 for ; Tue, 9 Mar 2021 16:17:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2FE2C3836C62 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NuDQ/PhmXgqXZhekwns1iAXlQXyuv+OjlG9aFai9xslwOZfIVmsNRdDxh91xK9XX5s/C3LC8Qu8ecUYxtwlaj2CoyCDA3qgYZb/6zMttIWJWA6FxoUX0kZPwAKGlEibZMcNPUxfmztDFbU6iGOSEl+AlTTAJ0z4LyakExTD2IHrlqcAt4YkZrbE3s+JMVzD41/vYOL01D8+78/+jyHHLysGJv0eNLN1edgGfNF95GUNozI13HTkkxgPOIyZC1KGXgbdDQQbogkhvN8jBkEhLHOtgSObUvzFxsJD4X3Fz1VhlmKPvtnbw/jfsmbcT+HZRhWNZcKSKis9G/x8A6maMhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VehjXKak9rBQFO0piHy6zeLAh+Gl+SPwZxCfpEJ2wk8=; b=mzsOe1Wp8xzGUWyol9viNTNqMCsZgriDxNPbGrF24oi6y52nG4iGetXb2unFh0BG2UEuiX3GmoY7rECErVCHm5G8DPlvWAZinPvGOILAQBVvgNghrOf5VaJQ/OBfTzc2aSYEKPqrgRKFfsMTqY9de6GhQdpgrTCAQA71R/OmqaIoWUp5g7Ak12DiXgd8M4lORzIzSXOfLvUx+76m+Kdf8tJ2m+lqOl571jF+kwra7tHiPsoDDpm1ra8NmD5qpmB+bUh4FriRBUuRopYlSYm87VrGETenxZeC2v00emsEDvRBIa6UUceHGxwOd3kK1m7GmcChN3WGYngKzWISOGT1OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MN2PR12MB3278.namprd12.prod.outlook.com (2603:10b6:208:ac::19) by MN2PR12MB2957.namprd12.prod.outlook.com (2603:10b6:208:100::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Tue, 9 Mar 2021 16:16:58 +0000 Received: from MN2PR12MB3278.namprd12.prod.outlook.com ([fe80::bc9f:2909:934c:3584]) by MN2PR12MB3278.namprd12.prod.outlook.com ([fe80::bc9f:2909:934c:3584%3]) with mapi id 15.20.3912.029; Tue, 9 Mar 2021 16:16:58 +0000 From: Sachin Nikam To: Matthias Maennich CC: Android Kernel Team , Ketan Patil , Nicolin Chen , Bharat Nihalani , Bryan Huntsman , "libabigail@sourceware.org" , "dodji@redhat.com" Subject: RE: libabigail tool - Android vs. Sourceware Thread-Topic: libabigail tool - Android vs. Sourceware Thread-Index: AdcRz34gEsYQ7AfUTvGHBH50TFrXMgABkr2AAMRT1DAABO8sAAABGskA Date: Tue, 9 Mar 2021 16:16:58 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=SNIKAM@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2021-03-09T16:14:38.7162694Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=5ff9ab1c-8374-458f-b81c-57ce117d7214; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic x-originating-ip: [115.114.90.35] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88ac1077-928e-4860-0295-08d8e316c3e4 x-ms-traffictypediagnostic: MN2PR12MB2957: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0krcmQCG3JbZ30Bb4Db1LTTXjMU+FAamlSMrodBp1bZ6B8+Fs3dt7lWRLsw5m8ISYKLj6yJN/29mPFTGMLVxcT866Q3aGrmEf3PBaptztxSz2djbt2aU9roLjQ8rL5ithB+wndOL0E784TU21MDK7AKV2W2nwfddHQXQRH0iMuxoe8e4N1FWdVeJDoXkm+mndqOvu29F6+FIPwmYNzFb7gV5JWgBGir+bYMGxswnwNKjRdHpn0RUD9njWfLHq2D1HiF81R7yad9LwzLsierLwfxM7n4GlKGtrfYWuFMLcfV7nowSJq3LE8ffnQl78ITR+oRny4g9M5KS/bMbKPOqPwolYqZKWaBlhfk0UvfjFQba4m3fBzMEMkgvMFehe+a+MG2/PgdnT8lxh79AfG6HhkIh6hjq3/oHZsRrqAqu8cxU2nH2denL/SVTETQeTBNh1oPfFCKKpt8J3Y/KWDhvJaHqr5HuetwlraoTLVi7XpGiFC6Wab8LJQ0ZqGDTpDaxRfoHLfMJCM4OW0uxLOlByt+1Y2sdunQEzpPtdK7pzV1zCLlFbcp2zxi1eyMAkICngq6sWaTGXuREsff4hswwaZ2M5NvEO50bnD7UraXVFR4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3278.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(55016002)(54906003)(316002)(5660300002)(66556008)(66446008)(64756008)(8936002)(8676002)(4326008)(2906002)(33656002)(186003)(55236004)(52536014)(66476007)(7696005)(26005)(6916009)(9686003)(6506007)(83380400001)(66946007)(76116006)(53546011)(86362001)(71200400001)(966005)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?tEDCWrxTC7t6dbLiEvcMzGdcrTJKONgHkvpe+JUlwqU639InQvTDWm42SCPu?= =?us-ascii?Q?gzoYtTyS0960GxEcZdqNdPdh2DjaFX8WeGLQLegFH0BYKP5hAKgJnCDyKAep?= =?us-ascii?Q?Q2T02aFxvCXxG43qZcleWYwY5TbIfMZso6+xAQU2uGrxndFSpZiZTji8hQnY?= =?us-ascii?Q?zdsSHMiCDZ8m6paSuxybfFPUn7EY1deqbGjqWFsXVoPyvOVKDWdpPnoqlsrR?= =?us-ascii?Q?IMj/SiKIME27BrFRvKF6FExx7U2g6pWLHUVAqTCgVntpgo3grfqg4PY7+0YU?= =?us-ascii?Q?HYoua1qTA3LpzbtzPeI+SrHW7VJvbegqu1fXzyRgYsgfK9UGMLbK46d2GIQl?= =?us-ascii?Q?pgb0Y3iFJZPho0F+qdh7vfgokS9LG35Dr7mALCOqduNFiXOj3z0rvPjlgFCY?= =?us-ascii?Q?k7KaDkKRmP/bTAvmJ3coJB4SlViaHF5+TWBYFs3DBIwMbeznMYmBUOMXrYg2?= =?us-ascii?Q?p0itFu1iK82S2PsRCCD+0cgaCRlmoXLfLgNF3Y8wVc6w4UydVmfFoJWldxK4?= =?us-ascii?Q?fskMoxzkxOuEOacmMqG6kAu3b1Nbp/DM5zcrz2tamWdetk05LzpWGp86hm4H?= =?us-ascii?Q?QBeYdSX2N+pW6u+pUuKAaU4uLD4fSPQix5Ua0VSceW+ci8u/ipJ3zPGZVGzi?= =?us-ascii?Q?Cgfn/ce8lYg/XM00YADALaTYivsT4RPmLv4xRH++Vyl3SjQ/VDODzDyoBO4w?= =?us-ascii?Q?SRxDm6+Zzg8Kym78cEgOwmMHw+cDay0DvEMs0qF46XJA9n5Gk3q9bno7XDSW?= =?us-ascii?Q?CgjY3Qiu8LZqadFVxqmrM5TkvmJuApVhk7SJ7UvJB3S+VWo1XqdvDyA/PAHJ?= =?us-ascii?Q?6auB36tX755teA51rmkPu/mFwFQehTwumNWM3oBquhszeP9dV7jgDZAA4iHf?= =?us-ascii?Q?VDpprdHC6LfIGodicfvt4qTF6Ec6ik/A1Gs7d07m9gYIo+AKPyZazSRrG4ox?= =?us-ascii?Q?LT/aemw+wXi4HKV6tkH8w71vfE796lcWBFYjvjUp33B26sDiBatZ1kITk9wV?= =?us-ascii?Q?N1/ONUsij1ekwOew5DFcHrjYHoOhakuo19/J7bHZ4Q/KBgwxO6XpLomcQLbx?= =?us-ascii?Q?ZHu/O7750SrnOQSDmovEdhm65Gbbpqmc32R/lsL+NLKFd0v2xnCpcmlGUDS1?= =?us-ascii?Q?q9SB9nAxypzrhSB4RiJndxZiZjEl73hVJPfkwOJbaQBqr+4Zna68mbxuRcM3?= =?us-ascii?Q?Tjoi+WBdS3hZZlTrgYh03ik3CUsOsRGfirLfTllxux7u9HjX1x4GM4DB5jv8?= =?us-ascii?Q?gEe0gkpA1dF6Y6viRr0NaLE+sLKIq8mM3U5mGr2w/Ro64vdX+uIJbcwIJ4x8?= =?us-ascii?Q?d8MjahhEXGZEORHMGb5u66JY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3278.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88ac1077-928e-4860-0295-08d8e316c3e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2021 16:16:58.6701 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cS0T0+wVtIbFJfCBCevtfGtdg/f+I4GUncmTFTuMgo9gC9GX79jltZPZEVqS2h8zvHx+XGXnF6s3qDyTMlyjIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB2957 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2021 16:17:04 -0000 Thanks for the info Matthias! -----Original Message----- From: Matthias Maennich =20 Sent: Tuesday, March 9, 2021 9:13 PM To: Sachin Nikam Cc: Android Kernel Team ; Ketan Patil ; Nicolin Chen ; Bharat Nihalani ; Bryan Huntsman ; libabigail@sourceware.org;= dodji@redhat.com Subject: Re: libabigail tool - Android vs. Sourceware External email: Use caution opening links or attachments On Tue, Mar 09, 2021 at 01:26:28PM +0000, Sachin Nikam wrote: >Which libabigail tool do you recommend us to use to monitor and enforce AB= I: >from https://android.googlesource.com/ or https://www.sourceware.org/liba= bigail/ ? It very much depends on what you want to do. :-) The Android version of libabigail is downstream of sourceware and receives = regular merges. At the same time, our patches are posted to the list and ge= t integrated over time. At the time of writing this, the first two patches = of the "Symtab reader" series have been merged upstream. If you are working on Android Kernels, the Android version of libabigail mi= ght be required. Similarly, if you are making use of Clang compilers to bui= ld your kernels. If you do not care about the above, you might be just fine with the latest = (released) version of upstream libabigail. Cheers, Matthias > > >-----Original Message----- >From: Matthias Maennich >Sent: Friday, March 5, 2021 9:10 PM >To: Sachin Nikam >Cc: Android Kernel Team ; Ketan Patil=20 >; Nicolin Chen ; Bharat=20 >Nihalani ; Bryan Huntsman ;=20 >libabigail@sourceware.org; dodji@redhat.com >Subject: Re: libabigail tool - Android vs. Sourceware > >External email: Use caution opening links or attachments > > >Hi, > >Cc: libabigail@sourceware.org, since you asked there first. > >On Fri, Mar 05, 2021 at 02:57:49PM +0000, Sachin Nikam wrote: >>Hi, >> >>I want to know how much android >>libabigail>m aster/abi/README.md> tool is diverged from=20 >>https://www.sourceware.org/libabigail/wiki >> >>What are the enhancements or bug fixes done in android libabigail t= ool from sourceware tool? > >It is not too much different actually. The biggest chunk is the replaced s= ymtab reader implementation. For the clang-built Android kernels with LTO/C= FI and some more interesting features, we needed to rework the (k)symtab re= ader. The patch series has been posted and is currently up for review, see = https://sourceware.org/pipermail/libabigail/2021q1/003089.html. >Those are alone 20 patches. > >Here is roughly what we have on top in >https://android.googlesource.com/platform/external/libabigail/: > >Android specific patches for integration, compliance, build: > 3e7ace7f4dce Initial empty repository # empty > 7d03a8db4b76 Add metadata files > c4c81432a780 Add support for external_updater automatic updates > a1a321d23b91 Add soong build description for building abidiff and abidw > 03dcda4bebc0 fix build for abidw > a28258465e4c Limit to 64-bit binaries. > 4d5ac23a458d Disable libabigail for darwin. > 16afa280a204 Drop unnecessary upstream files that impose RESTRICTED lic= ensing > 6b3d6ad6fa31 Add LOCAL_LICENSE_KINDS to external/libabigail > >Alternative Symtab reader: > 5f49f81f2850 abg-cxx-compat: add simplified version of std::optional > 204eaf651a17 abg-ir: elf_symbol: add is_in_ksymtab field > bda7f9443f09 abg-ir: elf_symbol: add is_suppressed field > 8adb9b8ee052 dwarf-reader split: create abg-symtab-reader.{h,cc} and te= st case > 66d2bede37c6 Refactor ELF symbol table reading by adding a new symtab r= eader > 5a745592194d Integrate new symtab reader into corpus and read_context > 97308e77a945 corpus: make get_(undefined_)?_(var|fun)_symbols use the n= ew symtab > cb24effa3948 corpus: make get_unreferenced_(function|variable)_symbols = use the new symtab > 4b5a95c4a5f3 abg-reader: avoid using the (var|function)_symbol_map > ab9401599724 dwarf-reader: read_context: use new symtab in *_symbols_is= _exported > 4d7075fd0b22 Switch kernel stuff over to new symtab and drop unused cod= e > 76e19dbc66c8 abg-elf-helpers: migrate ppc64 specific helpers > 96872a3abb46 symtab_reader: add support for ppc64 ELFv1 binaries > ede9a107a71f abg-corpus: remove symbol maps and their setters > 4dcbf6520983 dwarf reader: drop (now) unused code related symbol table = reading > a4015cf2f9ef test-symtab: add tests for whitelisted functions > a82212c4152f symtab/dwarf-reader: allow hinting of main symbols for ali= ases > 51bac872c0bb dwarf-reader/writer: consider aliases when dealing with su= ppressions > 7ac9bb8f1181 symtab: Add support for MODVERSIONS (CRC checksums) > 1b4e95ec43c2 abg-writer.cc: fix write_elf_symbol_reference loop > c1db8a7be692 abidiff: better whitespace in symbol diff report > >Misc additions and fixes: > 7e7a9979bc8a KMI Whitelists: allow alternative section suffix 'symbol_l= ist' > 3b707b3e8e13 abidiff: Flag indirect struct/union changes. > >Cheers, >Matthias > >> >>Best Regards, >>Sachin Nikam. >> >>-- >>To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com.