From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id D7B393951C8E for ; Wed, 7 Jul 2021 12:47:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D7B393951C8E Received: by mail-wm1-x335.google.com with SMTP id j39-20020a05600c1c27b029020028e48b8fso4167724wms.0 for ; Wed, 07 Jul 2021 05:47:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9EN+rs/Ve4YNw0oODItdzZWMLYztZIr9jSv0PndzNqo=; b=oWoXnjbNFWhvCDVyKJyCO47l1s+wKrZYE26PDUJ/1gdPTVdak5LljZHC3pFb5/fhBZ L0r/MW9GdagW+y5SmuUm6AQf9BGFESSfezvLjvT9ZRK904waUdNgQbnjP/URaGirPSgU n7QEy9HH9x8nfR2wM0yQKUzvnaMmiRcZFHRR5Uz/ijU9W3C8kBmyzJszpXnFMm1qbCW5 A/tKAZibkBl9h4+Ulr8tmolXkuffrvPceNRhQBVbXkGbF+u3IstSGrhYPWtoDk4+WTaa CS4+QB/etEf08BuepgJxa05K9kWXvwv/gPZ0hBzR+qpu6a1F7UAo9bLV3Zjb2NT5gD5C 9aPA== X-Gm-Message-State: AOAM532kc7SwPUv1X3w9h9XaJ0ALN8zC6AT76z2sGSiwGJJKAcM+YoZi yCzF7wSqjVwBWcWrZtA3Zam8eA== X-Google-Smtp-Source: ABdhPJw4nFjtzBjxV3I5/VjiPbonlTApXoVq5oGbuZ0jjNbCBCGAtZecZNxxpp4estRN1acbEWeP9g== X-Received: by 2002:a1c:1bd0:: with SMTP id b199mr9460364wmb.108.1625662063438; Wed, 07 Jul 2021 05:47:43 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:67d9:6937:aa95:70a4]) by smtp.gmail.com with ESMTPSA id j1sm5965900wms.7.2021.07.07.05.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 05:47:42 -0700 (PDT) Date: Wed, 7 Jul 2021 13:47:42 +0100 From: Matthias Maennich To: Giuliano Procida Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com Subject: Re: [PATCH] abg-ir.h: add declaration of operator<< for elf_symbol::visibility Message-ID: References: <20210707102222.725766-1-gprocida@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210707102222.725766-1-gprocida@google.com> X-Spam-Status: No, score=-30.2 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jul 2021 12:47:46 -0000 On Wed, Jul 07, 2021 at 11:22:22AM +0100, Giuliano Procida wrote: >There is a formatted output operator for elf_symbol::visibility in >abg-ir.cc. However, it had no visibile declaration and was not usable >by library users. This commit adds the declaration. > > * include/abg-ir.h (operator<<(elf_symbol::visibility): Add > declaration. > >Signed-off-by: Giuliano Procida Reviewed-by: Matthias Maennich Cheers, Matthias >--- > include/abg-ir.h | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/include/abg-ir.h b/include/abg-ir.h >index da43727f..641ce514 100644 >--- a/include/abg-ir.h >+++ b/include/abg-ir.h >@@ -1107,6 +1107,9 @@ operator<<(std::ostream& o, elf_symbol::type t); > std::ostream& > operator<<(std::ostream& o, elf_symbol::binding t); > >+std::ostream& >+operator<<(std::ostream& o, elf_symbol::visibility t); >+ > bool > string_to_elf_symbol_type(const string&, elf_symbol::type&); > >-- >2.32.0.93.g670b81a890-goog >