Hi Vanessa,

On Sun, Oct 17, 2021 at 08:53:52PM +0000, Sochat, Vanessa via Libabigail wrote:
> A symbol in elfutils was renamed (see line 7 here) in elfutils:
> 
> https://chromium.googlesource.com/external/elfutils/+/515dd0acc77673c953380bcf5ccfb05b83c5a3ab/NEWS
>
> This results in this error when trying to install the 2.0 libabigail
> release (and I suspect others depending on the version of elfutils
> used): error: 'DW_LANG_PL1' was not declared in this scope; did you
> mean 'DW_LANG_PLI'

Although that typo was indeed fixed, an compatibility define was left
if libdw/dwarf.h:

/* Old (typo) '1' != 'I'.  */
#define DW_LANG_PL1 DW_LANG_PLI

So I am slightly surprised you are getting that error, every version
of elfutils really should have DW_LANG_PL1 (even though the correct
name is DW_LANG_PLI) precisely to prevent any such compile errors.

Are you sure you are using the correct dwarf.h from elfutils/libdw ?

> And after some poking I figured out that this line
> https://sourceware.org/git/?p=libabigail.git;a=blob;f=src/abg-dwarf-reader.cc;h=1d6ad24cbfcc2d94c07311bb04112f14f4f0e71c;hb=HEAD#l11056
> needs to be DW_LANG_PLI instead of DW_LANG_PL1.  I am attaching the
> patch I used to make the fix in spack:
> https://github.com/spack/spack/blob/03f84fb440770101816dad61ca59cf1bebf1997b/var/spack/repos/builtin/packages/libabigail/package.py#L37

I think the patch itself is correct, but you probably want to fix the
typo in libabigail itself (see attached - this might be an api break
for libabigail though without compatibility symbols).

Note that this would mean libabigail won't compile with elfutils
versions before 0.168, but that is probably no problem given that
version is from 2016.

Cheers,

Mark