From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 331373858D28 for ; Tue, 23 Nov 2021 19:59:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 331373858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x10.wildebeest.org [172.31.17.146]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id D13313000346; Tue, 23 Nov 2021 20:59:43 +0100 (CET) Received: by reform (Postfix, from userid 1000) id 3CB232E80EBC; Tue, 23 Nov 2021 20:59:43 +0100 (CET) Date: Tue, 23 Nov 2021 20:59:43 +0100 From: Mark Wielaard To: Dodji Seketeli Cc: Giuliano Procida , maennich@google.com, libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH v3] Bug 28191 - Interpret DWARF 5 addrx locations Message-ID: References: <20210827185755.953243-1-gprocida@google.com> <20211119150138.2930800-1-gprocida@google.com> <87ilwiu72o.fsf@seketeli.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ilwiu72o.fsf@seketeli.org> X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 19:59:47 -0000 Hi, On Tue, Nov 23, 2021 at 06:15:27PM +0100, Dodji Seketeli wrote: > It seems to me that we can also do away with the use of eval_last_constant_dwarf_sub_expr from > die_member_offset. Would that work on your testing binaries? > > From what I am seeing, dwarf_getlocation_attr and dwarf_getlocation are > present in elfutils 0.176 which is the oldest version that we need to > support, so we should be able to ditch eval_last_constant_dwarf_sub_expr > and its dependencies altogether. I don't know the libabigail code too well, but eval_last_constant_dwarf_sub_expr seem to be a partial Dwarf Expression evaluator. elfutils libdw doesn't export one (it really should though). So I think you still need that code when you get a non-trivial location expression. Cheers, Mark