From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id BFD393858C39 for ; Thu, 9 Dec 2021 12:13:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFD393858C39 Received: by mail-wr1-x435.google.com with SMTP id d24so9444964wra.0 for ; Thu, 09 Dec 2021 04:13:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m62h18ghFUTOfh+4eYx2Z6QGi8esQXDiQJm0CpjPtpQ=; b=BtAS8Os9QHRF5EZ9HMGIGsb1rggZNNwSsNMtSlxzOwr/aB6a28l/ckNVRV0c0zOpAk wz3vyijXpDSTMs71fWQqnfdsUldUJk6BWa7KNcRWl88Mnnqs/sNXIPT59VCwjuMPHC7g tLvGhJhFFH+SHUJz44NCErH1rR0moshTfvQRlBoPwuBKBkzvn7Xg5BPyWkOf9wct/wCO UYYRGRFVIMryTEo+nQN0vXi7yUyTrIm7e4EYcasB3SbtPGbfSr6rZiQKPgOabCkrO3aI pt+OPOJcY6fOKW5tr56o2oNl8yPWXliP2giqzRNRpYhTX8uofK0mhmcILnT9+bo8LW/d ovIg== X-Gm-Message-State: AOAM5309s+aummPrUPb44mrx3z52k7FEVcD65zWm6u+nTv+OVZqAAdNB cjlScEHaBFvaqpmVRSwj3nBfDg== X-Google-Smtp-Source: ABdhPJxhOX296I4JA2/5bEyPPxFgOc2tOE6FgDBXVn8r2gzfsBlYgSmG9G1KKi9YHTA5Q7SzftHclA== X-Received: by 2002:adf:e7c2:: with SMTP id e2mr5680210wrn.349.1639052013517; Thu, 09 Dec 2021 04:13:33 -0800 (PST) Received: from google.com ([2a00:79e0:d:210:9076:76fc:3e4b:1d79]) by smtp.gmail.com with ESMTPSA id i17sm5610761wmq.48.2021.12.09.04.13.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 04:13:32 -0800 (PST) Date: Thu, 9 Dec 2021 12:13:32 +0000 From: Matthias Maennich To: Thomas Schwinge Cc: libabigail@sourceware.org Subject: Re: [PATCH] Better highlight 'make distcheck-fast' Message-ID: References: <20211209120701.1606881-1-thomas@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20211209120701.1606881-1-thomas@codesourcery.com> X-Spam-Status: No, score=-29.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2021 12:13:37 -0000 On Thu, Dec 09, 2021 at 01:07:01PM +0100, Thomas Schwinge wrote: >... for the reasons stated. > > * CONTRIBUTING: Better highlight 'make distcheck-fast'. > >Signed-off-by: Thomas Schwinge >--- Thanks! That makes totally sense. :-) > CONTRIBUTING | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > >diff --git CONTRIBUTING CONTRIBUTING >index 7e3e8561..4e70d381 100644 >--- CONTRIBUTING >+++ CONTRIBUTING >@@ -63,25 +63,27 @@ is important, because that is how we do to actually release the > tarball of the project that you can download from the internet) then > you can do: > >- make distcheck >+ make distcheck-fast > > This actually builds the tarball, then untars it, configure/compile > the untarred source code and launches the regression checks from > there. > >+Here, "make distcheck-fast" is a variant of the standard "make distcheck". >+It compresses with "--fast" instead of default "--best", and is >+significantly faster, given the size of the distribution. You very likely >+want to use that one for local regression testing. >+ > You can also launch this in parallel by doing: > >- make -jN -lN distcheck >+ make -jN -lN distcheck-fast > > with N being the number of processor core you have on your system. > >-Please make sure you always launch "make distcheck" before sending a >+Please make sure you always launch "make distcheck-fast" before sending a > patch, so that you are sure that we can always build a tarball after > your patch is applied to the source tree. > >-A variant of distcheck is "make distcheck-fast". It's like "make >-distcheck" but it's faster. You can just use that one. >- Instead mention that `make distcheck-fast` is not supposed to be used to create artifacts for distribution, because it creates _different_ results. > A complementary regression checking target is "check-self-compare". > You invoke it by doing "make check-self-compare". That target > analyzes the ABI of the libabigail.so shared object, serializes it >@@ -89,11 +91,11 @@ into the ABIXML format and then compares the ABI internal > representation gathered from the libabigail.so binary against the one > gathered from the ABIXML format. The two should be equal if > everything goes right. This is an important regression test. The >-problem is that it can takes twice as much time as make distcheck. So >-we've put it into its own separate target. >+problem is that it can takes twice as much time as "make distcheck-fast". >+So we've put it into its own separate target. I would skip this occurrence or talke about "the `make distcheck*` targets". With the above: Reviewed-by: Matthias Maennich Cheers, Matthias > > So, to be complete the regression checking command to run against your >-patch should be: "make check-self-compare distcheck -j16", if you have >+patch should be: "make check-self-compare distcheck-fast -j16", if you have > a machine with a 16 threads processors, for instance. > > Coding language and style >-- >2.25.1 >