From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id F0272395200A for ; Thu, 17 Mar 2022 11:01:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F0272395200A Received: by mail-wr1-x431.google.com with SMTP id j26so6838238wrb.1 for ; Thu, 17 Mar 2022 04:01:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JG41v93GW/4RqTeYS9fpeIzonpWLfNMceYuxtK8zbsc=; b=uPHo73wN230JYeYpo/tekH7FR8FY3dXnGZwGDMJOBZJcjKNmN08u39pv+2moj+EsJn 2eyn6JfTAXfpfUB+gs+iRQLUxMqoEjNbuznArMNdxJtbuVavg/tcxamnDEXszDy6LCkp CEZzRbfIPZJZNax0Ep5F1cKI3X1PzLAyWypD8ABxKXGj7WgDpSQyvuApeRfxV2cBLxdQ YIjQA8pkR0+E5/nCewssY/B+dA+31w0iRhz09O4RjGOzIiFH2oybHk2niBwdJSK43nn1 /He+wesWtKzvqa+ZugzgId6Hsb5ifw5h76J2S8Aia72IH7dWVrBbZirR8UIBfeCrN569 +kyw== X-Gm-Message-State: AOAM530Ybr2aSmf7PmYmvIm/4CVbf9YRPQokbw/vowoIpNkWaHl92nZg 9XRNov5zrf3Gd2sm6LiGU9BVIONiOL2Rqg== X-Google-Smtp-Source: ABdhPJwpaPm6kGIDMSYHp2SCC2XxLlL2DXT8p9Nlk0C5SzWMxXAixV+33D5rDnqJ/nT3NANP3kKl0Q== X-Received: by 2002:a05:6000:1acf:b0:1f0:5e62:9b28 with SMTP id i15-20020a0560001acf00b001f05e629b28mr3351963wry.448.1647514866248; Thu, 17 Mar 2022 04:01:06 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:8b6c:955c:c308:5566]) by smtp.gmail.com with ESMTPSA id n16-20020a5d4010000000b001f07772457csm3680758wrp.101.2022.03.17.04.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 04:01:05 -0700 (PDT) Date: Thu, 17 Mar 2022 11:01:05 +0000 From: Matthias Maennich To: Giuliano Procida Cc: libabigail@sourceware.org, kernel-team@android.com Subject: Re: [PATCH v2 2/4] crc_changed: eliminate copying of shared_ptr values Message-ID: References: <20220314181312.3436802-1-gprocida@google.com> <20220316163055.4127796-1-gprocida@google.com> <20220316163055.4127796-3-gprocida@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20220316163055.4127796-3-gprocida@google.com> X-Spam-Status: No, score=-29.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 11:01:13 -0000 On Wed, Mar 16, 2022 at 04:30:53PM +0000, Giuliano Procida via Libabigail wrote: >As pointed out in a review of similar code, it is possible to avoid >copying a couple of shared pointers in this function, by taking >references instead. > >This commit also splits declarations to one per line and removes the >unnecessary parentheses around the return expression. > > * src/abg-comp-filter.cc (crc_changed): Take references to > avoid std::shared_ptr copying. Split declarations into one per > line. Remove unnecessary return expression parentheses. > >Signed-off-by: Giuliano Procida Reviewed-by: Matthias Maennich Cheers, Matthias >--- > src/abg-comp-filter.cc | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/src/abg-comp-filter.cc b/src/abg-comp-filter.cc >index 56251274..f90fdc78 100644 >--- a/src/abg-comp-filter.cc >+++ b/src/abg-comp-filter.cc >@@ -230,11 +230,13 @@ static bool > crc_changed(const function_or_var_decl_sptr& f, > const function_or_var_decl_sptr& s) > { >- const auto symbol_f = f->get_symbol(), symbol_s = s->get_symbol(); >+ const auto& symbol_f = f->get_symbol(); >+ const auto& symbol_s = s->get_symbol(); > if (!symbol_f || !symbol_s) > return false; >- const auto crc_f = symbol_f->get_crc(), crc_s = symbol_s->get_crc(); >- return (crc_f != 0 && crc_s != 0 && crc_f != crc_s); >+ const auto crc_f = symbol_f->get_crc(); >+ const auto crc_s = symbol_s->get_crc(); >+ return crc_f != 0 && crc_s != 0 && crc_f != crc_s; > } > > /// Test if the current diff tree node carries a CRC change in either a >-- >2.35.1.894.gb6a874cedc-goog >