From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by sourceware.org (Postfix) with ESMTPS id A19033858D20 for ; Thu, 13 Apr 2023 17:05:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A19033858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=fjasle.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fjasle.eu Received: from leknes.fjasle.eu ([46.142.97.232]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MKsf5-1q3qmO31kz-00LIxD; Thu, 13 Apr 2023 19:03:25 +0200 Received: by leknes.fjasle.eu (Postfix, from userid 1000) id 476813C0EE; Thu, 13 Apr 2023 19:03:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fjasle.eu; s=mail; t=1681405402; bh=prF/9k2Xus4Gm9F26joQ49+N2+VxW+Wm+lPAuwRp3dc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dWQ6fAU3wvVnrinGJLkjxvqSon1S0SVzZW5AcGXighRgxgZiYYmHDiL2A1IkifD+o hsuVrD+WosyjaO2AwMJcNqGA0EnoQHvB0nCqQFQ5+cJzBjnAHRzTVnZwXj474Y6r97 785SyyD1yi+ohEHMz1L7R5JktSQEAIUsNBk+VsJs= Date: Thu, 13 Apr 2023 19:03:22 +0200 From: Nicolas Schier To: John Moon Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Greg Kroah-Hartman , Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , kernel-team@android.com, libabigail@sourceware.org, Jordan Crouse , Trilok Soni , Satya Durga Srinivasu Prabhala , Elliot Berman , Guru Das Srinagesh Subject: Re: [PATCH v5 1/2] check-uapi: Introduce check-uapi.sh Message-ID: References: <20230407203456.27141-1-quic_johmoo@quicinc.com> <20230407203456.27141-2-quic_johmoo@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:bO1rw56I77aHqH/VCK3YAqnRlsHmHlJPegGsTHf6wVQeF9YdNeJ BX3WJOp72K1UoDLThrwGftGd8Tou6vI7+bFnsDkSM4a0cjjzr5bUQwvX/Qa0dLBZwd+I9Q1 AbVv5/6hFwpVX5/Onm0auumhAvtx6eYUlwrhEcx2meg3ZxNOmmE3dRq6t0bH3Z40+sKBWu0 oeR7zTDfws8wScvscxvjg== UI-OutboundReport: notjunk:1;M01:P0:fa520UNgWXc=;8FOl1iK4C45pcNI0FlwShKu27eu AR1PbR3UET4azRwIN69vPZrhsdhu/TboQH3jYuaixatTTKsxsrw/KY/3J7YiT4nHQ7ouKLeTK o2aMGIsgAYtWIok8YtDmPzzuOKvoZjiTFGVEI0/lEXk+WxlnkSr9BmsrrsdmLpCCjfcpXHvvT L5rpnFig3FIO45uSJR9CBcDPqtSP2lTtXuyMXRT9PMfaxGeQntIvINiDxp0R2u0EzPWrMiCi9 TJ8vxu2Y5CUsnksiErOdqLZqjGcs0kbiEdeMTx/zkzNQwjDIvTiesy7oXB4RBNeewiTRAOAAE udl9PC2nzs2B2OrjKu1YwuKQDKk80xKquTAzSPkAvCgclMqCGvoNBDjq5iZC3FVfJRkMGwxVR GuMpQO54FfgpkfmYqf1x7WNZAdxdUgcNgN4UDE4eXLRAklz/2mN+fyTq0j2ZQZgn2RdGMWzo0 eEFiiZX+C7oqD7pHmBbf8kevY7dEagD+h9Hawg7oo2SCxzAPaSUD5O9OhCs414C4OYXvQUWvl x5u2TbyCwDQ7Ru7JNZFxZ/wKPt97lr+C8HVl0jciEHjA020Gs9yx8IWUnplQHUjpSQwQa4HpD +eVlfQMFgpYS9ifiBoFhPFm0ud7IcanC/flGF9ZVLh6gR2sEWMf+CsBIwxYMe4HvXz59QsavW ppf6tgPmY+MiGlqWXVean94SHi4S+PxUJ2gKsT4DUQ== X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 10, 2023 at 07:03:05PM +0900 Masahiro Yamada wrote: [...] > [2] Be careful! > > > While testing the patch submissions of this, > I messed up my repository multiple times. > > The script takes some time because it builds many objects > internally. > > However, once this script starts running, you must not hit Ctrl-C. > If you do it, your repository will be sprinkled with a ton > of untracked files. > > Apply this patch, and run "./scripts/check-uapi.sh -p v6.0" > and hit Ctrl-C. > > Repeat it a couple of times, and "git status" will show you > something horrible. > > > You will never know when git is checking out a commit > because this script hides it by 'git checkout --quiet'. > > > So, this tool should show a caveat at least. > > > 'git checkout' should not be hidden, or > maybe a caveat message should be shown. > > > CAVEAT > This tool runs 'git checkout' a couple of times internally. > If you interrupt it, your worktree might be messed up. John, did you consider using git export for obtaining a source tree that can be used for headers_install and the following comparison, instead of git stash+checkout? AFACS the script does not depend on any other git functionality than providing a specific version of the source tree. I am pretty sure that leaving the original working copy in its original state is supporting the script's popularity. Kind regards, Nicolas