From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by sourceware.org (Postfix) with ESMTPS id CC5473858C2A for ; Tue, 12 Dec 2023 07:41:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC5473858C2A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: sourceware.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC5473858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:7c80:54:3::133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702366903; cv=none; b=U9w0AUSyKHckma0YamkqP4FjjcAw28ik8kz/IYnBPdH8c7Dhnfxk40atRiNH0ldoWYcNLnIzh16xaEtEpgj5uLpYaYSzhDa9m8c1J3QPXI0tEsKiIPGrT9XKIVTduJXfXHJNHzBeJW+N+qvsObr67C63phG0Wg7GfaR0hjxAo1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702366903; c=relaxed/simple; bh=oAergxIz3AfAiod3N7GVP6QnGjc7tkODu39jLGycQBc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=rQkKhrFK0gYAZdR5DGOhROITY0np68oF20ImqhxU1gnbpwLAtELJ8yVawnALtHeiHPG1ADVCtqKxP++4/Q0U4r/XtyXfuKyVWJ9Z3vHWmvBANzD+6GrHAOYsXyxz1kPE2xlpjGmPzpHzqIcauoeS4pOfZzrbtWiIH6qvej9p6ng= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BR0GaKh1S4JeZ9xjnS0mdRlav8bDaJHAovNcXYJH2Vo=; b=NwcMeZFZ0khJl1V+L+Wl4YRXrd SxUF0Pjlux4EICl+LyraoIkrBjSjaIKVORnpUeoanTFTkehRAb+zVFSXUB8k3Ua5JjkGxA8iHLqhy OCDQer6cxLVIbNo0Q9E4hzOnd08VpZQOZjXRXseM6DcueKjp1VTULYURG3ZFw5beS8MgE7XryCng2 ln8fm0nC01FYPjKzNFvgMDDaZNvUEu/lyG9ciDjbFaMHyB8kfkywdNLplSasCh649akcfoK4zSBN1 EkG7+GNhpYWi/KG34VHJ+X0frnW0GstEtJb0URpxq3BlXajIA1jbFk4k9EGfcVNjadjf7kRXaxMT+ 75zDTO2Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rCxOP-00Awjy-0d; Tue, 12 Dec 2023 07:41:25 +0000 Date: Mon, 11 Dec 2023 23:41:25 -0800 From: Christoph Hellwig To: John Moon Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Jonathan Corbet , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, kernel@quicinc.com, Greg Kroah-Hartman , Rob Herring , Carlos O'Donell , Randy Dunlap , Arnd Bergmann , Bjorn Andersson , Todd Kjos , Matthias Maennich , Giuliano Procida , kernel-team@android.com, libabigail@sourceware.org, Dodji Seketeli , Trilok Soni , Satya Durga Srinivasu Prabhala , Jordan Crouse Subject: Re: [PATCH v7 3/3] check-module-params: Introduce check-module-params.sh Message-ID: References: <20231212020259.2451253-1-quic_johmoo@quicinc.com> <20231212020259.2451253-4-quic_johmoo@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231212020259.2451253-4-quic_johmoo@quicinc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Dec 11, 2023 at 06:02:59PM -0800, John Moon wrote: > One part of maintaining backwards compatibility with older > userspace programs is avoiding changes to module parameters. Really? I don't think module parameters are a UAPI in the traditional sense. Now if you break a heavily used one you got to fix it, but applying strict stability guarantees on module options which are not availble to normal users or even normal programs doesn't make a whole lot of sense.