From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 35BFC3858403 for ; Tue, 21 Dec 2021 15:43:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 35BFC3858403 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id D85E4302FBA8; Tue, 21 Dec 2021 16:43:41 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 96BB1425A477; Tue, 21 Dec 2021 16:43:40 +0100 (CET) Message-ID: Subject: Re: [PATCH] Replace Python 'import importlib' with 'import importlib.machinery' From: Mark Wielaard To: Dodji Seketeli , Thomas Schwinge Cc: libabigail@sourceware.org Date: Tue, 21 Dec 2021 16:43:40 +0100 In-Reply-To: <877dby80a7.fsf@seketeli.org> References: <660b800832668cba9415c01d7cf5ab49438dba98.camel@klomp.org> <20211221140432.2159710-1-thomas@codesourcery.com> <877dby80a7.fsf@seketeli.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 15:43:45 -0000 Hi, On Tue, 2021-12-21 at 16:06 +0100, Dodji Seketeli wrote: > Thomas Schwinge a =C3=A9crit: >=20 > > Fix-up for recent commit f0582fdbf1267f0f34bf3c3b6698b60026410146 > > "Replace use of deprecated Python 'imp' module with 'importlib'", > > which... > >=20 > > [...] seems to have broken something on centos7 x86_64: > >=20 > > https://builder.wildebeest.org/buildbot/#/changes/7273 > >=20 > > File "/srv/buildbot/worker/libabigail-centos- > > x86_64/build/tests/mockfedabipkgdiff", line 73, in > > fedabipkgdiff_mod =3D > > importlib.machinery.SourceFileLoader('fedabipkgdiff', > > FEDABIPKGDIFF).load_module() > > AttributeError: 'module' object has no attribute 'machinery' > >=20 > > Again, I've asked The Internet what to do about that, and this > > commit is the > > result. But beware: I'm still not a Python wizard. > >=20 > > * tests/mockfedabipkgdiff.in: Replace Python 'import importlib' > > with 'import importlib.machinery'. >=20 > Applied to master. Sadly still failing: https://builder.wildebeest.org/buildbot/#/builders/8/builds/802 Note that this is a centos7 install with just python2 and there is no python3-koji, only python2-koji, which is needed to run the runtestfedabipkgdiff.py test. Maybe this test should just be disabled for python2 only systems? Cheers, Mark