From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id 1C3C63858D1E for ; Sun, 16 Apr 2023 18:33:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C3C63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33GIR1lO020410; Sun, 16 Apr 2023 18:33:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=YL7wp5F9gHJsPxzVgAKhvgkAtSnTsZ0GBQ4miFAOGxU=; b=QOydmiq2HlRbQ1CS/Vp5cLJFZOW4pBQ4YAOCwNeF/0JUt3XSIQhElegu0VqMpeCHGMCA dX77DwIboeDunxiiMvT1M9opkPfZiyFhziOQKjn9S0GiHFCzwTAQlbnJaStGm9r4dNcY +jwgfQMKGpo3fNxejqqfKgo6XOOxgFuxqhwhu0B3Tqn8XomAcnBxPTlchSes93m4ZmG9 Vfia8z7uYSXcqi7Pc2o3BJF2aq1r8IprSI/5pXThg0dQikCuUILIWWQTlmaPDwY+LL+h 5lT8LKfvzhgqSO3l4Xxf0cJPnK6uXJUrYjx0AGWTWt98Rq6i1aYpsLHvWzyTXuagmr/w SA== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pymuu1wsf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 16 Apr 2023 18:33:36 +0000 Received: from nasanex01a.na.qualcomm.com (nasanex01a.na.qualcomm.com [10.52.223.231]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33GIXZoH021266 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 16 Apr 2023 18:33:35 GMT Received: from [10.110.70.130] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Sun, 16 Apr 2023 11:33:35 -0700 Message-ID: Date: Sun, 16 Apr 2023 11:33:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: abidiff improvements for kernel UAPI checker To: John Moon , , CC: Satya Durga Srinivasu Prabhala References: <5363161d-8167-284e-e35d-9a8ef20adea9@quicinc.com> Content-Language: en-US From: Trilok Soni In-Reply-To: <5363161d-8167-284e-e35d-9a8ef20adea9@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01a.na.qualcomm.com (10.52.223.231) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: tS1IrkYe-kBUm44cwMzzBo8aTuPLYW9_ X-Proofpoint-ORIG-GUID: tS1IrkYe-kBUm44cwMzzBo8aTuPLYW9_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-16_12,2023-04-14_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 mlxscore=0 mlxlogscore=626 impostorscore=0 malwarescore=0 suspectscore=0 clxscore=1011 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304160175 X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/10/2023 5:45 PM, John Moon wrote: > Hi all, > > As you may be aware from the Linux kernel mailing list threads I've been > CC'ing you on, we're in the process of upstreaming a shell script that > uses abidiff to compare Linux kernel userspace APIs between revisions. > Linux UAPIs are supposed to be stable forever, so we're trying to detect > when a patch breaks a UAPI. > > If you haven't been following, the latest thread is here: > https://lore.kernel.org/lkml/20230407203456.27141-1-quic_johmoo@quicinc.com/ > > At a high level, we're taking the header file before/after the patch, > building it in a dummy C file, then taking advantage of abidiff's > "--non-reachable-types" argument to compare all the symbols. > > This method works great! However, there are a couple of classes of ABI > differences that are detected but don't qualify as UAPI-breaking. > > By far the most common class of differences occur with enum expansions. > > For example, this change triggers finding: > https://github.com/torvalds/linux/commit/622f1b2fae2eea28a80b04f130e3bb54227699f8#diff-a7f82b68b3459e13934c123bda4c3a9be20eadebe938a376e39a395e5ffa825a Any inputs here from the libabigail mailing list here? ---Trilok Soni