From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
 by sourceware.org (Postfix) with ESMTPS id 3A6C43858C51
 for <libabigail@sourceware.org>; Tue, 17 May 2022 14:03:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3A6C43858C51
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl
 [83.87.18.245])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 21C00300027E;
 Tue, 17 May 2022 16:03:12 +0200 (CEST)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id C105C4001206; Tue, 17 May 2022 16:03:11 +0200 (CEST)
Message-ID: <bf71fbc4c2d174c58a8174af3608dd8dc1b33331.camel@klomp.org>
Subject: Re: [PATCH] symtab-reader: Setup aliases before checking ppc64 opd
 function entries
From: Mark Wielaard <mark@klomp.org>
To: Giuliano Procida <gprocida@google.com>
Cc: Dodji Seketeli <dodji@seketeli.org>, libabigail@sourceware.org, Matthias
 =?ISO-8859-1?Q?M=E4nnich?= <maennich@google.com>
Date: Tue, 17 May 2022 16:03:11 +0200
In-Reply-To: <CAGvU0H=Jesd6AC+Avkjv4g_o7Kmc=t5ZV6VrRc94WqcMaBEFSw@mail.gmail.com>
References: <20220516143423.097F8581C5E@localhost>
 <aecc7208ed5d4656f56d38b17b0899bee86321a7.camel@klomp.org>
 <CAGvU0H=Jesd6AC+Avkjv4g_o7Kmc=t5ZV6VrRc94WqcMaBEFSw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: libabigail@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Mailing list of the Libabigail project <libabigail.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libabigail/>
List-Help: <mailto:libabigail-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libabigail>,
 <mailto:libabigail-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 17 May 2022 14:03:15 -0000

On Tue, 2022-05-17 at 14:51 +0100, Giuliano Procida wrote:
> > > +  if (symbol_sptr->is_function() && is_ppc64)
>=20
> IIRC, someone said that this should apply to PPC32 as well, perhaps
> you, Mark?

Yes, in theory both ppc32 and ppc64 use function descriptors (and both
are big endian). But I haven't seen a real ppc32 setup in years.

If you want to support that then it should be as simple as defining a
architecture_is_ppc32 which is precisely like architecture_is_ppc64
with s/EM_PPC64/EM_PPC/

Cheers,

Mark