public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/18941] Add a warning option to libabigail tools  to report possible DWARF issues
Date: Fri, 01 Jan 2016 00:00:00 -0000	[thread overview]
Message-ID: <bug-18941-9487-R1FgDC1cM7@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-18941-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=18941

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
Many of the cases which I think need warnings are more prosaic.

If it comes along a case where the DWARF has been stripped or was never
generated, then most if not all of the ABI verification is not being done. This
should be a higher priority warning. This could also remind people to point the
libabigail utilities toward an external debuginfo file. I would say that this
is a high enough priority that it should be the default unless some --quiet
option is passed on the command line.

A lower priority warning would be a exported function entry point for a
non-static function that exists in ELF but doesn't exist in the available
DWARF. This is important because we need to know the things that we are not yet
examining. I thought the option should be something like -Wunexamined-functions

A similar situation is the one you mention where you have a forward declaration
but no information about the class. -Wunexamined-classes

I think that -Wunions probably should be there too. This would trip if
libabigail found any unions in the DWARF and emit the union's name for manual
verification. I do not recall seeing this in the release notes. We should
probably have a note saying that unions are not examined for ABI compatibility
in the release notes.

And finally because the number of these warnings will likely grow over time we
should probably have something like:
-W which turns on common problems
-Wall which turns on every single warning.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2016-01-21 16:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-01  0:00 [Bug default/18941] New: " dodji at redhat dot com
2015-01-01  0:00 ` [Bug default/18941] " dodji at redhat dot com
2015-01-01  0:00 ` dodji at redhat dot com
2016-01-01  0:00 ` woodard at redhat dot com [this message]
2016-01-01  0:00 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-18941-9487-R1FgDC1cM7@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).