public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so
  2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
                   ` (7 preceding siblings ...)
  2015-01-01  0:00 ` woodard at redhat dot com
@ 2015-01-01  0:00 ` woodard at redhat dot com
  2015-01-01  0:00 ` [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent dodji at redhat dot com
  2015-01-01  0:00 ` woodard at redhat dot com
  10 siblings, 0 replies; 12+ messages in thread
From: woodard at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
Another build of the file seems to have some entirely different ABI symmetry
problems and doesn't cause abidw to assert:

hype356@ben:~/bin/abidw --abidiff
/collab/usr/global/tools/order/spack/opt/chaos_5_x86_64_ib/gcc@4.4.7/dyninst@8.2.1-a77e6bbb/lib/libparseAPI.so
Functions changes summary: 0 Removed, 3 Changed, 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

3 functions with some indirect sub-type change:

  [C]'method std::_Rb_tree_iterator<std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> > >
std::_Rb_tree<boost::shared_ptr<Dyninst::Assignment>, std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >,
std::_Select1st<std::pair<const boost::shared_ptr<Dyninst::Assignment>,
boost::shared_ptr<Dyninst::AST> > >,
std::less<boost::shared_ptr<Dyninst::Assignment> >,
std::allocator<std::pair<const boost::shared_ptr<Dyninst::Assignment>,
boost::shared_ptr<Dyninst::AST> > > >::_M_insert_(const
std::_Rb_tree_node_base*, const std::_Rb_tree_node_base*, const std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >&)'
has some indirect sub-type changes:
    parameter 3 of type 'const std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >&' has
sub-type changes:
      in referenced type 'const std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >':
        in unqualified underlying type 'struct std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >':
          1 data member change:
           type of 'const boost::shared_ptr<Dyninst::Assignment>
std::pair<const boost::shared_ptr<Dyninst::Assignment>,
boost::shared_ptr<Dyninst::AST> >::first' changed:
             in unqualified underlying type 'class
boost::shared_ptr<Dyninst::Assignment>':
               1 data member change:
                type of 'Dyninst::Assignment*
boost::shared_ptr<Dyninst::Assignment>::px' changed:
                  in pointed to type 'class Dyninst::Assignment':
                    1 data member change:
                     type of 'Dyninst::InstructionAPI::InstructionDecoder::Ptr
Dyninst::Assignment::insn_' changed:
                       typedef name changed from
Dyninst::InstructionAPI::InstructionDecoder::Ptr to Dyninst::Assignment::Ptr





  [C]'method std::pair<std::_Rb_tree_iterator<std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> > >,
bool> std::_Rb_tree<boost::shared_ptr<Dyninst::Assignment>, std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >,
std::_Select1st<std::pair<const boost::shared_ptr<Dyninst::Assignment>,
boost::shared_ptr<Dyninst::AST> > >,
std::less<boost::shared_ptr<Dyninst::Assignment> >,
std::allocator<std::pair<const boost::shared_ptr<Dyninst::Assignment>,
boost::shared_ptr<Dyninst::AST> > > >::_M_insert_unique(const std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >&)'
has some indirect sub-type changes:
    parameter 1 of type 'const std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >&' has
sub-type changes:
      in referenced type 'const std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >':
        unqualified underlying type 'struct std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >'
changed, as reported earlier

  [C]'method std::_Rb_tree_iterator<std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> > >
std::_Rb_tree<boost::shared_ptr<Dyninst::Assignment>, std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >,
std::_Select1st<std::pair<const boost::shared_ptr<Dyninst::Assignment>,
boost::shared_ptr<Dyninst::AST> > >,
std::less<boost::shared_ptr<Dyninst::Assignment> >,
std::allocator<std::pair<const boost::shared_ptr<Dyninst::Assignment>,
boost::shared_ptr<Dyninst::AST> > >
>::_M_insert_unique_(std::_Rb_tree_const_iterator<std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> > >,
const std::pair<const boost::shared_ptr<Dyninst::Assignment>,
boost::shared_ptr<Dyninst::AST> >&)' has some indirect sub-type changes:
    parameter 2 of type 'const std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >&' has
sub-type changes:
      in referenced type 'const std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >':
        unqualified underlying type 'struct std::pair<const
boost::shared_ptr<Dyninst::Assignment>, boost::shared_ptr<Dyninst::AST> >'
changed, as reported earlier

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so
  2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
  2015-01-01  0:00 ` [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent dodji at redhat dot com
  2015-01-01  0:00 ` dodji at redhat dot com
@ 2015-01-01  0:00 ` woodard at redhat dot com
  2015-01-01  0:00 ` [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent woodard at redhat dot com
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: woodard at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
Created attachment 8649
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8649&action=edit
a different build

This is a different build of the same library but it manifests different
errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so
@ 2015-01-01  0:00 woodard at redhat dot com
  2015-01-01  0:00 ` [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent dodji at redhat dot com
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: woodard at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

            Bug ID: 19026
           Summary: ABI symmetry problems and an assert with
                    libparseAPI.so
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 8648
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8648&action=edit
reproducing ELF file.

hype356@ben:~/bin/abidw --abidiff
/collab/usr/global/tools/order/spack/opt/chaos_5_x86_64_ib/gcc@4.4.7/dyninst@8.1.2-b04
^M0c20e/lib/libparseAPI.so
Functions changes summary: 0 Removed, 19 Changed, 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

19 functions with some indirect sub-type change:

  [C]'method virtual Dyninst::ASTVisitor::ASTPtr
Dyninst::ASTVisitor::visit(Dyninst::DataflowAPI::ConstantAST*)' has some
indirect sub-type changes:
    return type changed:
      typedef name changed from Dyninst::ASTVisitor::ASTPtr to
Dyninst::DataflowAPI::BooleanVisitor::ASTPtr

<snip>

  [C]'method virtual const std::string Dyninst::DataflowAPI::RoseAST::format()'
has some indirect sub-type changes:
    return type changed:
      in unqualified underlying type 'typedef std::string':
        underlying type 'struct std::basic_string<char, std::char_traits<char>,
std::allocator<char> >' changed:
          1 data member change:
abidw: ../../src/abg-comparison.cc:10185: abigail::comparison::base_diff_sptr
abigail::comparison::compute_diff(abigail::ir::class_decl::base_spec_sptr,
abigail::ir::class_decl::base_spec_sptr,
abigail::comparison::diff_context_sptr): Assertion `first->get_environment() ==
second->get_environment()' failed.
Aborted (core dumped)

This looks like a different assert than the other one. Also some ABI
information must not be being properly stored due to the fact that there are a
lot of ABI symmetry problems.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent
  2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
                   ` (8 preceding siblings ...)
  2015-01-01  0:00 ` woodard at redhat dot com
@ 2015-01-01  0:00 ` dodji at redhat dot com
  2015-01-01  0:00 ` woodard at redhat dot com
  10 siblings, 0 replies; 12+ messages in thread
From: dodji at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ABI symmetry problems and   |ODR optimization considers
                   |an assert with              |types with same name and
                   |libparseAPI.so              |different size to be
                   |                            |equivalent

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so
  2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
                   ` (6 preceding siblings ...)
  2015-01-01  0:00 ` woodard at redhat dot com
@ 2015-01-01  0:00 ` woodard at redhat dot com
  2015-01-01  0:00 ` woodard at redhat dot com
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: woodard at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

--- Comment #5 from Ben Woodard <woodard at redhat dot com> ---
Created attachment 8720
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8720&action=edit
A new reproducer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent
  2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
                   ` (2 preceding siblings ...)
  2015-01-01  0:00 ` [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
@ 2015-01-01  0:00 ` woodard at redhat dot com
  2015-01-01  0:00 ` [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: woodard at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

--- Comment #9 from Ben Woodard <woodard at redhat dot com> ---
Created attachment 8766
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8766&action=edit
An even newer reproducer

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so
  2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
                   ` (4 preceding siblings ...)
  2015-01-01  0:00 ` [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
@ 2015-01-01  0:00 ` dodji at redhat dot com
  2015-01-01  0:00 ` woodard at redhat dot com
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: dodji at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from dodji at redhat dot com ---
This issue seems to be fixed by the fix for PR libabigail/19024

Thank you for reporting this problem!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent
  2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
@ 2015-01-01  0:00 ` dodji at redhat dot com
  2015-01-01  0:00 ` dodji at redhat dot com
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: dodji at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from dodji at redhat dot com ---
Yes, I am seeing this.  I think I introduced a thinko in the fix I proposed for
this issue.

I am thus proposing another fix, in the master branch at commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=75515395e1609000df42cf7ebfedb943ed42b547

I am tentatively closing this bug again.

Thank you very much for following up on this, it's very appreciated.

And sorry for me screwing up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent
  2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
  2015-01-01  0:00 ` [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent dodji at redhat dot com
@ 2015-01-01  0:00 ` dodji at redhat dot com
  2015-01-01  0:00 ` [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: dodji at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from dodji at redhat dot com ---
Yes, I see the issue, thanks.

Just for information, the problem in the binary attached to
https://sourceware.org/bugzilla/attachment.cgi?id=8766 is different from the
one you initially opened this bug with.

Here the issue is due to libabigail failing to propagate the "environment"
property of a class type to its base class specifiers.

This should now be fixed by commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=4a8ea96dab0195b8069e0940e86bc858a20f1f29
in the master branch.

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so
  2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
                   ` (5 preceding siblings ...)
  2015-01-01  0:00 ` dodji at redhat dot com
@ 2015-01-01  0:00 ` woodard at redhat dot com
  2015-01-01  0:00 ` woodard at redhat dot com
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: woodard at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

--- Comment #6 from Ben Woodard <woodard at redhat dot com> ---
(In reply to Ben Woodard from comment #4)
> I am still getting a few of these assertions:

I forgot to say that this was with the master branch and the last commit up
through: 09de4435ce4c3d9df2aeda6c0fa615faa2a63bb5

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so
  2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
                   ` (3 preceding siblings ...)
  2015-01-01  0:00 ` [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent woodard at redhat dot com
@ 2015-01-01  0:00 ` woodard at redhat dot com
  2015-01-01  0:00 ` dodji at redhat dot com
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: woodard at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #4 from Ben Woodard <woodard at redhat dot com> ---
I am still getting a few of these assertions:

hype356@ben:~/bin/abidw --abidiff
/collab/usr/global/tools/order/spack/opt/chaos_5_x86_64_ib/gcc@4.4.7/vtk@6.1.0-2f431570/lib/libvtkIOSQL-6.1.so.1
abidw: ../../src/abg-comparison.cc:10141: abigail::comparison::base_diff_sptr
abigail::comparison::compute_diff(abigail::ir::class_decl::base_spec_sptr,
abigail::ir::class_decl::base_spec_sptr,
abigail::comparison::diff_context_sptr): Assertion `first->get_environment() ==
second->get_environment()' failed.
Aborted (core dumped)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent
  2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
                   ` (9 preceding siblings ...)
  2015-01-01  0:00 ` [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent dodji at redhat dot com
@ 2015-01-01  0:00 ` woodard at redhat dot com
  10 siblings, 0 replies; 12+ messages in thread
From: woodard at redhat dot com @ 2015-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19026

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #8 from Ben Woodard <woodard at redhat dot com> ---
And I'm reopening it again because I'm still seeing it as of yesterday with the
master.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2015-11-09 17:46 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-01  0:00 [Bug default/19026] New: ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
2015-01-01  0:00 ` [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent dodji at redhat dot com
2015-01-01  0:00 ` dodji at redhat dot com
2015-01-01  0:00 ` [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
2015-01-01  0:00 ` [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent woodard at redhat dot com
2015-01-01  0:00 ` [Bug default/19026] ABI symmetry problems and an assert with libparseAPI.so woodard at redhat dot com
2015-01-01  0:00 ` dodji at redhat dot com
2015-01-01  0:00 ` woodard at redhat dot com
2015-01-01  0:00 ` woodard at redhat dot com
2015-01-01  0:00 ` woodard at redhat dot com
2015-01-01  0:00 ` [Bug default/19026] ODR optimization considers types with same name and different size to be equivalent dodji at redhat dot com
2015-01-01  0:00 ` woodard at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).