[Bug default/19126] New: segv when running abidw on a dwz compressed version of r300_dri.so

[Bug default/19126] New: segv when running abidw on a dwz compressed version of r300_dri.so

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

            Bug ID: 19126
           Summary: segv when running abidw on a dwz compressed version of
                    r300_dri.so
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

[ben@localhost abidiff]$ dwz --version
dwz version 0.11
Copyright (C) 2001-2012 Red Hat, Inc.
Copyright (C) 2003 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) any later version.
This program has absolutely no warranty.
[ben@localhost abidiff]$ dwz r300_dri.so
[ben@localhost abidiff]$ ls -l r300_dri.so*
-rwxr-xr-x. 1 ben ben 122792893 Oct 13 10:21 r300_dri.so
-rwx------. 1 ben ben 157634391 Oct 13 10:20 r300_dri.so.save
[ben@localhost abidiff]$ ~/bin/abidw --abidiff r300_dri.so
Segmentation fault (core dumped)

hype356@ben:gdb ../libabigail/build/tools/.libs/lt-abidw
GNU gdb (GDB) Red Hat Enterprise Linux (7.2-83.el6)
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from
/g/g0/ben/work/libabigail/build/tools/.libs/lt-abidw...done.
(gdb) set args --abidiff ~/work/find-same/r300_dri.so.dwz
(gdb) r
Starting program: /g/g0/ben/work/libabigail/build/tools/.libs/lt-abidw
--abidiff ~/work/find-same/r300_dri.so.dwz
[Thread debugging using libthread_db enabled]

Program received signal SIGSEGV, Segmentation fault.
0x00002aaaaba044f3 in std::basic_string<char, std::char_traits<char>,
std::allocator<char> >::assign(std::basic_string<char, std::char_traits<char>,
std::allocator<char> > const&) ()
   from /usr/lib64/libstdc++.so.6
Missing separate debuginfos, use: debuginfo-install
bzip2-libs-1.0.5-7.el6_0.x86_64 elfutils-libelf-0.161-3.el6.x86_64
elfutils-libs-0.161-3.el6.x86_64 libgcc-4.4.7-16.el6.x86_64
libstdc++-4.4.7-16.el6.x86_64 libxml2-2.7.6-20.el6.x86_64
xz-libs-4.999.9-0.5.beta.20091007git.el6.x86_64 zlib-1.2.3-29.el6.x86_64
(gdb) bt
#0  0x00002aaaaba044f3 in std::basic_string<char, std::char_traits<char>,
std::allocator<char> >::assign(std::basic_string<char, std::char_traits<char>,
std::allocator<char> > const&) ()
   from /usr/lib64/libstdc++.so.6
#1  0x00002aaaaadb3222 in operator= (this=<value optimized out>,
location=<value optimized out>, 
    path=<value optimized out>, line=@0x7fffffffc68c, column=<value optimized
out>)
    at
/usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../include/c++/4.4.7/bits/basic_string.h:511
#2  abigail::ir::location_manager::expand_location (this=<value optimized out>, 
    location=<value optimized out>, path=<value optimized out>,
line=@0x7fffffffc68c, 
    column=<value optimized out>) at ../../src/abg-ir.cc:231
#3  0x00002aaaaaeeb9d5 in abigail::xml_writer::write_location (decl=<value
optimized out>, o=...)
    at ../../src/abg-writer.cc:579
#4  0x00002aaaaaef2fbf in abigail::xml_writer::write_class_decl (decl=
    std::tr1::shared_ptr (count 9) 0x48be3e90, id="", ctxt=..., indent=6)
    at ../../src/abg-writer.cc:2194
#5  0x00002aaaaaef5c66 in abigail::xml_writer::write_class_decl (decl=<value
optimized out>, ctxt=..., 
    indent=6) at ../../src/abg-writer.cc:2389
#6  0x00002aaaaaef6efb in abigail::xml_writer::write_decl (
    decl=std::tr1::shared_ptr (count 9) 0x48be3ed8, ctxt=..., indent=6) at
../../src/abg-writer.cc:1017
#7  0x00002aaaaaef7358 in write_namespace_decl (decl=<value optimized out>,
ctxt=..., indent=4)
    at ../../src/abg-writer.cc:1380
#8  abigail::xml_writer::write_decl (decl=<value optimized out>, ctxt=...,
indent=4)
    at ../../src/abg-writer.cc:1017
#9  0x00002aaaaaef95de in abigail::xml_writer::write_translation_unit (tu=...,
ctxt=..., indent=2)
    at ../../src/abg-writer.cc:1195
#10 0x00002aaaaaefad97 in abigail::xml_writer::write_corpus_to_native_xml (
    corpus=std::tr1::shared_ptr (count 3) 0xbd8220, indent=0, out=...) at
../../src/abg-writer.cc:3012
#11 0x000000000040381f in main (argc=<value optimized out>, argv=<value
optimized out>)
    at ../../tools/abidw.cc:288
(gdb) 

Note: Not attaching a new version of r300_dri.so since it is already a well
known test case from other bugs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

--- Comment #5 from Ben Woodard <woodard at redhat dot com> ---
Verified that this still happens with dodji/fixes up through
7f82a37cb86df8413c0818ee45d17443bd8887c2

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

--- Comment #6 from Ben Woodard <woodard at redhat dot com> ---
err make that: 806a6a610f02e4d27d5b1c9c167c69e388465746

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
This was with the dodji/fixes branch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
Program runs to completion with the r300_dri.so which wasn't compressed by dwz.

(gdb) set args --abidiff ~/work/find-same/r300_dri.so 
(gdb) r
Starting program: /g/g0/ben/work/libabigail/build/tools/.libs/lt-abidw
--abidiff ~/work/find-same/r300_dri.so 
[Thread debugging using libthread_db enabled]
<snip>

Program exited with code 01.
(gdb)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

--- Comment #7 from Ben Woodard <woodard at redhat dot com> ---
Still crashes with the current version of libabigail up through
814a88cdfcd688467e936a09520c8246f5009148

As expected the problem appears to be with a location list:

Program received signal SIGSEGV, Segmentation fault.
0x00002aaaabcf74f3 in std::basic_string<char, std::char_traits<char>,
std::allocator<char> >::assign(std::basic_string<char, std::char_traits<char>,
std::alloc\
ator<char> > const&) () from /usr/lib64/libstdc++.so.6
(gdb) bt
#0  0x00002aaaabcf74f3 in std::basic_string<char, std::char_traits<char>,
std::allocator<char> >::assign(std::basic_string<char, std::char_traits<char>,
std::a\
llocator<char> > const&) () from /usr/lib64/libstdc++.so.6
#1  0x00002aaaaafcb055 in abigail::ir::location_manager::expand_location
(this=0x1a032720, location=..., path="", line=@0x7fffffffcd1c,
column=@0x7fffffffcd18)\
 at ../../src/abg-ir.cc:231
#2  0x00002aaaab164318 in abigail::xml_writer::write_location
(decl=std::tr1::shared_ptr (count 10) 0x4a6cf548, o=...) at
../../src/abg-writer.cc:622
#3  0x00002aaaab16c0d3 in abigail::xml_writer::write_class_decl_opening_tag
(decl=std::tr1::shared_ptr (count 10) 0x4a6cf500, id="", ctxt=..., indent=6,
prepar\
e_to_handle_members=true) at ../../src/abg-writer.cc:2319
#4  0x00002aaaab16c518 in abigail::xml_writer::write_class_decl
(decl=std::tr1::shared_ptr (count 10) 0x4a6cf500, id="", ctxt=..., indent=6) at
../../src/abg-w\
riter.cc:2376
#5  0x00002aaaab16d854 in abigail::xml_writer::write_class_decl
(decl=std::tr1::shared_ptr (count 10) 0x4a6cf500, ctxt=..., indent=6) at
../../src/abg-writer.c\
c:2560
#6  0x00002aaaab165792 in abigail::xml_writer::write_decl
(decl=std::tr1::shared_ptr (count 10) 0x4a6cf548, ctxt=..., indent=6) at
../../src/abg-writer.cc:1060
#7  0x00002aaaab167de2 in abigail::xml_writer::write_namespace_decl
(decl=std::tr1::shared_ptr (count 5) 0x1a482d40, ctxt=..., indent=4) at
../../src/abg-write\
r.cc:1480
#8  0x00002aaaab1654b3 in abigail::xml_writer::write_decl
(decl=std::tr1::shared_ptr (count 5) 0x1a482d78, ctxt=..., indent=4) at
../../src/abg-writer.cc:1060
#9  0x00002aaaab166b01 in abigail::xml_writer::write_translation_unit (tu=...,
ctxt=..., indent=2) at ../../src/abg-writer.cc:1241
#10 0x00002aaaab16fe9d in abigail::xml_writer::write_corpus_to_native_xml
(corpus=std::tr1::shared_ptr (count 3) 0xc069b0, indent=0, out=...) at
../../src/abg-\
writer.cc:3204
#11 0x00000000004057f7 in main (argc=3, argv=0x7fffffffdf28) at
../../tools/abidw.cc:323
(gdb) up
#1  0x00002aaaaafcb055 in abigail::ir::location_manager::expand_location
(this=0x1a032720, location=..., path="", line=@0x7fffffffcd1c,
column=@0x7fffffffcd18)\
 at ../../src/abg-ir.cc:231
(gdb) p location.value_
$1 = 5490
(gdb) p l
$2 = (abigail::ir::expanded_location &) @0x1a920c10: {path_ = Traceback (most
recent call last):
  File "/usr/lib64/../share/gdb/python/libstdcxx/v6/printers.py", line 558, in
to_string
    return self.val['_M_dataplus']['_M_p'].lazy_string (length = len)
RuntimeError: Cannot access memory at address 0xffffffffffffffe8
, line_ = 0, column_ = 0}

So it looks like libabigail is not storing the location list correctly when
working on a compressed binary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from dodji at redhat dot com ---
Commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=0ec24168378d2649f58f7384faa9fd2ef72276ee
in the master branch fixes the location-related issue that you correctly nailed
down.

But then, I am seeing a massive performance issue in abidw --abdiff on this
binary and I need to work on it.

Actually, abidw --abidiff on a non-dwz'ed r300_dri.so binary is slow too, as
it's taking 16 minutes on my local machine (for a non-optimized build).  I have
pushed some performance patches into master that bring that time down to under
8 minutes.

Now I'll look specifically at the performance side of things, and I'll track
that issue specifically in this separate bug:
https://sourceware.org/bugzilla/show_bug.cgi?id=19355

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

--- Comment #10 from dodji at redhat dot com ---
I am currently trying with http://ssh.bencoyote.net/~ben/r300_dri.so.gz.  It's
taking a while ... I'll keep you posted.

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

--- Comment #8 from Ben Woodard <woodard at redhat dot com> ---
apparently the class that is causing the problem is: 
pair< std::_Rb_tree_const_iterator<unsigned int>, bool>

The segv happens while emitting the class to tmp file the first time thus the
--abidiff option is not needed.

It gets down to emitting the member function:

<function-decl name='swap'
mangled-name='_ZNSt4pairISt23_Rb_tree_const_iteratorIjEbE4swapERS2_'
filepath='/collab/usr/global/tools/order/spack/opt/chaos_5_x86_64_ib/gcc@4.4.7/gcc@4.9.2-93774c82/include/c++/4.9.2/bits/stl_pair.h'
line='194' column='1' visibility='default' binding='global' size-in-bits='64'>

and then segv's

starting to dig into DWARF

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

--- Comment #3 from Ben Woodard <woodard at redhat dot com> ---
It looks like the crash is after the fact and the problem is that the location
triplet is missing a the path_ component. 

/// Given an instance of location type, return the triplet                      
/// {path,line,column} that represents the source locus.  Note that             
/// the location must have been previously created from the function            
/// location_manager::expand_location otherwise this function yields            
/// unexpected results, including possibly a crash.                             
///                                                                             
/// @param location the instance of location type to expand                     
/// @param path the resulting path of the source locus                          
/// @param line the resulting line of the source locus                          
/// @param column the resulting colum of the source locus                       
void
location_manager::expand_location(const location        location,
                                  std::string&          path,
                                  unsigned&             line,
                                  unsigned&             column) const
{
  if (location.value_ == 0)
    return;
  expanded_location &l = priv_->locs[location.value_ - 1];
=>path = l.path_;
  line = l.line_;
  column = l.column_;
}

loc=5490

The problem class appears to be:

(gdb) p ((class_decl*)decl)->get_name()
$15 = "pointer_traits<std::_Rb_tree_node<unsigned int>*>"

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

--- Comment #9 from dodji at redhat dot com ---
Hey Ben!

Could you please point me to where I could get my hands on the exact
r300_dri.so you are looking at?

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19126] segv when running abidw on a dwz compressed version of r300_dri.so

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19126

--- Comment #4 from Ben Woodard <woodard at redhat dot com> ---
Verified that this still happens with master at commit
09de4435ce4c3d9df2aeda6c0fa615faa2a63bb5

-- 
You are receiving this mail because:
You are on the CC list for the bug.