From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15008 invoked by alias); 11 Feb 2016 12:25:15 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 14984 invoked by uid 55); 11 Feb 2016 12:25:12 -0000 From: "dodji at redhat dot com" To: libabigail@sourceware.org Subject: [Bug default/19607] abidiff --stats does not report breaking change Date: Fri, 01 Jan 2016 00:00:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dodji at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2016-q1/txt/msg00089.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D19607 --- Comment #1 from dodji at redhat dot com --- Maybe I am missing something, but even when I do: abidiff dump1 dump2 (without the --stat), the output doesn't say that there is a breaking change. So it looks like the swapped virtual methods change is not present. I double checked in the regression tests and we do have regression tests in place to detect swapped virtual methods in particular, and they seem to be working: $ ./build/tools/abidiff tests/data/test-abidiff-exit/test1-voffset-change-v= 0.o tests/data/test-abidiff-exit/test1-voffset-change-v1.o=20 Functions changes summary: 0 Removed, 2 Changed, 0 Added functions Variables changes summary: 0 Removed, 0 Changed, 0 Added variable 2 functions with some indirect sub-type change: [C]'method virtual int C::virtual_func0()' at test1-voffset-change-v1.cc:= 9:1 has some indirect sub-type changes: the vtable offset of method virtual int C::virtual_func0() changed from= 0 to 1 note that this is an ABI incompatible change to the vtable of class C [C]'method virtual char C::virtual_func1()' at test1-voffset-change-v1.cc:13:1 has some indirect sub-type changes: the vtable offset of method virtual char C::virtual_func1() changed fro= m 1 to 0 note that this is an ABI incompatible change to the vtable of class C $=20 What am I missing? --=20 You are receiving this mail because: You are on the CC list for the bug.