[Bug default/19607] abidiff --stats does not report breaking change

[Bug default/19607] abidiff --stats does not report breaking change

[michi.henning at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19607

Michi Henning <michi.henning at canonical dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #3 from Michi Henning <michi.henning at canonical dot com> ---
My apologies, I made a mistake and confused dump files during testing. Eating
my words. Guten Appetit! ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19607] New: abidiff --stats does not report breaking change

[michi.henning at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19607

            Bug ID: 19607
           Summary: abidiff --stats does not report breaking change
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: michi.henning at canonical dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 8975
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8975&action=edit
Dump files

$ abidiff --stat dump1 dump2
Functions changes summary: 0 Removed, 0 Changed, 160 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
Function symbols changes summary: 0 Removed, 90 Added function symbols not
referenced by debug info
Variable symbols changes summary: 0 Removed, 2 Added variable symbols not
referenced by debug info


Note: it says "0 Changed"

But the attached dump files contain a breaking change (two swapped virtual
methods).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19607] abidiff --stats does not report breaking change

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19607

--- Comment #1 from dodji at redhat dot com ---
Maybe I am missing something, but even when I do:

 abidiff dump1 dump2

(without the --stat), the output doesn't say that there is a breaking
change.

So it looks like the swapped virtual methods change is not present.

I double checked in the regression tests and we do have regression tests
in place to detect swapped virtual methods in particular, and they seem
to be working:

$ ./build/tools/abidiff tests/data/test-abidiff-exit/test1-voffset-change-v0.o
tests/data/test-abidiff-exit/test1-voffset-change-v1.o 
Functions changes summary: 0 Removed, 2 Changed, 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

2 functions with some indirect sub-type change:

  [C]'method virtual int C::virtual_func0()' at test1-voffset-change-v1.cc:9:1
has some indirect sub-type changes:
    the vtable offset of method virtual int C::virtual_func0() changed from 0
to 1
      note that this is an ABI incompatible change to the vtable of class C

  [C]'method virtual char C::virtual_func1()' at
test1-voffset-change-v1.cc:13:1 has some indirect sub-type changes:
    the vtable offset of method virtual char C::virtual_func1() changed from 1
to 0
      note that this is an ABI incompatible change to the vtable of class C


$ 

What am I missing?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/19607] abidiff --stats does not report breaking change

[michi.henning at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19607

--- Comment #2 from Michi Henning <michi.henning at canonical dot com> ---
(In reply to dodji from comment #1)
> 
> What am I missing?

Maybe absolutely nothing, and I just made a mistake. It's possible. I'll
double-check tomorrow. I may have attached the wrong files, or worked from the
wrong directory. My apologies!

Please keep this open; I'll re-confirm or eat my words tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.