From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 0AEBB384B00F; Tue, 6 Oct 2020 20:09:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0AEBB384B00F From: "gprocida+abigail at google dot com" To: libabigail@sourceware.org Subject: [Bug default/19608] Need basic semantic checks for suppression files Date: Tue, 06 Oct 2020 20:09:45 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: gprocida+abigail at google dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2020 20:09:46 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D19608 --- Comment #3 from Giuliano Procida -= -- Updating here in case this information is useful to someone. I prepared a significant set of changes to add error handling and reporting= to the parser. Any such work has the potential to considerably bloat the code = so the changes aggressively refactored the parser to the point that, as far as possible, there was no repetition in the error handling paths. The upstream maintainer, however, doesn't favour this approach. Conversely,= I don't have the time or inclination to add error handling etc. in a way which doesn't eliminate repetition. I am abandoning this line of development. Thi= ngs might change if there is strong demand for this feature. The current version of my changes are on Github. I will continue to rebase = them onto master so long as there are no significant conflicts with other change= s to suppression parsing. The changes up to https://github.com/myxoid/libabigail/commits/suppression-parsing-error-hand= ling represent one approach to threading error status through all the parsing co= de. If someone wants to add error handling in some other way, then these commit= s at least show the extent of what needs to be done. Monadic error handling in mainstream C++? Perhaps one day. The changes up to https://github.com/myxoid/libabigail/commits/suppression-parsing-errors add error reporting (just logging to stderr). The changes to https://github.com/myxoid/libabigail/commits/suppression-parsing-warnings add warnings for some cases where user-supplied information is useless or ignored for one reason or another. The changes up to https://github.com/myxoid/libabigail/commits/suppression-parsing-speculative contain some unfinished and/or speculative changes to the suppression parsi= ng code. --=20 You are receiving this mail because: You are on the CC list for the bug.=