* [Bug default/19619] Suppressions incomplete?
2016-01-01 0:00 [Bug default/19619] New: Suppressions incomplete? michi.henning at canonical dot com
@ 2016-01-01 0:00 ` michi.henning at canonical dot com
2016-01-01 0:00 ` [Bug default/19619] New: " Dodji Seketeli
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: michi.henning at canonical dot com @ 2016-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=19619
--- Comment #2 from Michi Henning <michi.henning at canonical dot com> ---
I just tried to reproduce, but can't now. (I'm on a different machine, and it's
late. I may have made a mistake.)
Do you see the problem I described with the attached files?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Bug default/19619] New: Suppressions incomplete?
2016-01-01 0:00 [Bug default/19619] New: Suppressions incomplete? michi.henning at canonical dot com
2016-01-01 0:00 ` [Bug default/19619] " michi.henning at canonical dot com
@ 2016-01-01 0:00 ` Dodji Seketeli
2016-01-01 0:00 ` [Bug default/19619] failing to suppress added aliased function reports for C++ dodji at redhat dot com
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Dodji Seketeli @ 2016-01-01 0:00 UTC (permalink / raw)
To: michi.henning at canonical dot com; +Cc: libabigail
> I have a suppressions file like so:
>
> [suppress_function]
> name_regexp = boost::.*
> change_kind = added-function
>
> [suppress_function]
> name_regexp = std::.*
> change_kind = added-function
>
> [suppress_function]
> name_regexp = unity::scopes::testing::.*
> change_kind = added-function
[...]
> The std and unity::scopes::testing suppressions match many, but not
> all, of the functions in their respective namespaces, so the output
> still shows 33 added functions.
Before I risk getting some false explanation, could you tell me if the
suppression specificication below works?
[suppress_function]
name_regexp = boost::.*
change_kind = added-function
allow_other_aliases = false
[suppress_function]
name_regexp = std::.*
change_kind = added-function
allow_other_aliases = false
[suppress_function]
name_regexp = unity::scopes::testing::.*
change_kind = added-function
allow_other_aliases = false
(Note the new allow_other_aliases property that got added)
> It's not clear to me why.
Again, we'd have needed more feedback from the tool here :(
But then if the supressions above wortk I think I have an idea of what
the issue is.
--
Dodji
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug default/19619] failing to suppress added aliased function reports for C++
2016-01-01 0:00 [Bug default/19619] New: Suppressions incomplete? michi.henning at canonical dot com
2016-01-01 0:00 ` [Bug default/19619] " michi.henning at canonical dot com
2016-01-01 0:00 ` [Bug default/19619] New: " Dodji Seketeli
@ 2016-01-01 0:00 ` dodji at redhat dot com
2016-01-01 0:00 ` [Bug default/19619] Suppressions incomplete? dodji at seketeli dot org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2016-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=19619
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from dodji at redhat dot com ---
This is a bug, indeed.
The change report about the added function should have been suppressed by that
suppression specification that you provided.
The use of the undocumented "allow_other_aliases = false" should be considered
as a temporary workaround.
The problem should be fixed in the master branch of the git repository by
commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=1eecd89ee1fca9a5a5c4dc656c88dd9a739c5683.
The commit log of that patch does have an extensive explanation of the
underlying problem, in case you are interested.
You should thus, eventually, be able to do away with the use of the
undocumented "allow_other_aliases" property.
Sorry for the inconvenience.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug default/19619] Suppressions incomplete?
2016-01-01 0:00 [Bug default/19619] New: Suppressions incomplete? michi.henning at canonical dot com
` (2 preceding siblings ...)
2016-01-01 0:00 ` [Bug default/19619] failing to suppress added aliased function reports for C++ dodji at redhat dot com
@ 2016-01-01 0:00 ` dodji at seketeli dot org
2016-01-01 0:00 ` [Bug default/19619] failing to suppress added aliased function reports for C++ dodji at redhat dot com
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: dodji at seketeli dot org @ 2016-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=19619
--- Comment #1 from dodji at seketeli dot org ---
> I have a suppressions file like so:
>
> [suppress_function]
> name_regexp = boost::.*
> change_kind = added-function
>
> [suppress_function]
> name_regexp = std::.*
> change_kind = added-function
>
> [suppress_function]
> name_regexp = unity::scopes::testing::.*
> change_kind = added-function
[...]
> The std and unity::scopes::testing suppressions match many, but not
> all, of the functions in their respective namespaces, so the output
> still shows 33 added functions.
Before I risk getting some false explanation, could you tell me if the
suppression specificication below works?
[suppress_function]
name_regexp = boost::.*
change_kind = added-function
allow_other_aliases = false
[suppress_function]
name_regexp = std::.*
change_kind = added-function
allow_other_aliases = false
[suppress_function]
name_regexp = unity::scopes::testing::.*
change_kind = added-function
allow_other_aliases = false
(Note the new allow_other_aliases property that got added)
> It's not clear to me why.
Again, we'd have needed more feedback from the tool here :(
But then if the supressions above wortk I think I have an idea of what
the issue is.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug default/19619] failing to suppress added aliased function reports for C++
2016-01-01 0:00 [Bug default/19619] New: Suppressions incomplete? michi.henning at canonical dot com
` (3 preceding siblings ...)
2016-01-01 0:00 ` [Bug default/19619] Suppressions incomplete? dodji at seketeli dot org
@ 2016-01-01 0:00 ` dodji at redhat dot com
2016-01-01 0:00 ` [Bug default/19619] Suppressions incomplete? michi.henning at canonical dot com
2016-01-01 0:00 ` [Bug default/19619] failing to suppress added aliased function reports for C++ dodji at redhat dot com
6 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2016-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=19619
--- Comment #5 from dodji at redhat dot com ---
Created attachment 8985
--> https://sourceware.org/bugzilla/attachment.cgi?id=8985&action=edit
A version of the committed patch that fixes the issue, but without regression
tests
I am attaching a version of the committed patch, but without regression testing
material. This makes it easy to back-port the patch, without having to carry
binary content (present in the regression testing bits of the committed patch)
around.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug default/19619] Suppressions incomplete?
2016-01-01 0:00 [Bug default/19619] New: Suppressions incomplete? michi.henning at canonical dot com
` (4 preceding siblings ...)
2016-01-01 0:00 ` [Bug default/19619] failing to suppress added aliased function reports for C++ dodji at redhat dot com
@ 2016-01-01 0:00 ` michi.henning at canonical dot com
2016-01-01 0:00 ` [Bug default/19619] failing to suppress added aliased function reports for C++ dodji at redhat dot com
6 siblings, 0 replies; 8+ messages in thread
From: michi.henning at canonical dot com @ 2016-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=19619
--- Comment #3 from Michi Henning <michi.henning at canonical dot com> ---
After adding allow_other_aliases = false, the additional symbols are
suppressed, thanks!
I find this surprising though; if I say "suppress every function and the std::
namespace", that's just what should happen.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug default/19619] failing to suppress added aliased function reports for C++
2016-01-01 0:00 [Bug default/19619] New: Suppressions incomplete? michi.henning at canonical dot com
` (5 preceding siblings ...)
2016-01-01 0:00 ` [Bug default/19619] Suppressions incomplete? michi.henning at canonical dot com
@ 2016-01-01 0:00 ` dodji at redhat dot com
6 siblings, 0 replies; 8+ messages in thread
From: dodji at redhat dot com @ 2016-01-01 0:00 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=19619
dodji at redhat dot com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Suppressions incomplete? |failing to suppress added
| |aliased function reports
| |for C++
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 8+ messages in thread