public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/19658] New: Type canonicalization slow for the 2nd binary being loaded
@ 2016-01-01  0:00 dodji at redhat dot com
  2016-01-01  0:00 ` [Bug default/19658] " dodji at redhat dot com
  0 siblings, 1 reply; 2+ messages in thread
From: dodji at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19658

            Bug ID: 19658
           Summary: Type canonicalization slow for the 2nd binary being
                    loaded
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: dodji at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

This issue has first been reported downstream in Fedora at
https://bugzilla.redhat.com/show_bug.cgi?id=1309400.

Basically, the reporter does this:

abipkgdiff --d1 nss-debuginfo-3.19.1-8.el6_7.i686.rpm --d2
nss-debuginfo-3.21.0-0.1.el6_7.i686.rpm nss-3.19.1-8.el6_7.i686.rpm
nss-3.21.0-0.1.el6_7.i686.rpm

And it takes forever.

After looking into it a bit deeper, I think what takes a long time is the
comparison of the libnssckbi.so shared library embedded in that package.

In particular, it looks canonicalizing certain class types from the *second*
binary being loaded takes a lot of time.

Moreover, those class types are duplicated (present in several translation unit
of the shared library), so canonicalizing them over and over again takes even
more time.

It looks like the ODR-based optimization to speed up type canonicalization is
not effective in the scenario.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug default/19658] Type canonicalization slow for the 2nd binary being loaded
  2016-01-01  0:00 [Bug default/19658] New: Type canonicalization slow for the 2nd binary being loaded dodji at redhat dot com
@ 2016-01-01  0:00 ` dodji at redhat dot com
  0 siblings, 0 replies; 2+ messages in thread
From: dodji at redhat dot com @ 2016-01-01  0:00 UTC (permalink / raw)
  To: libabigail

https://sourceware.org/bugzilla/show_bug.cgi?id=19658

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from dodji at redhat dot com ---
This should be fixed by commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=e62901963ff1c48cfc99e0ec1b96d07af47328f4
in the master branch of the git repository.

The fix should be available in the 1.0.rc3 release to come.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-18 15:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-01  0:00 [Bug default/19658] New: Type canonicalization slow for the 2nd binary being loaded dodji at redhat dot com
2016-01-01  0:00 ` [Bug default/19658] " dodji at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).