[Bug default/19705] Can't build from HEAD without change

["michi.henning at canonical dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=19705

--- Comment #2 from Michi Henning <michi.henning at canonical dot com> ---
(In reply to dodji from comment #1)
> Thank you for taking the time to file this problem report.
>  
> > elfutils, libtool, libelf-dev, libdw-dev
> > 
> > It might be nice to mention these in the doc.
> 
> Right.  I guess you mean the COMPILING file in the source tree.  elfutils at
> least is mentioned at https://www.sourceware.org/libabigail/#compile.

No, I was looking at the instructions here:

https://www.sourceware.org/libabigail/

> As for libelf-dev and libdw-dev, they should be part of the development
> variant of elfutils, shouldn't they?  On my system, for instance, trying to
> install elfutils-devel will install the packages necessary for the libraries
> (and header files) of libelf and libdw.  Those two components are parts of
> the elfutils project anyway.

It looks like, on Ubuntu, libelf-dev doesn't drag in libdw-dev. Instead,
libdw-dev requires libelf-dev. When I tried to resolve the package
dependencies, I installed libelf-dev first and then found that I need to
install libdw-dev too.

> I am asking this just so that I can in the docs to install the development
> variants of the 'elfutils' package, without having to go into the specifics
> of how each distro splits up its things.

Yes, the different packaging for distros is a headache. It's not a big deal--I
mean, it wasn't exactly rocket science to figure out the missing dependencies
:-)

> Weird, obviously, I don't get this on my system.

I just followed the instructions on the home page and figured it would be best
to report this. There is nothing unusual in my Ubuntu installation as far as
compiler, linker, or library locations are concerned. It's all stock-standard.

> > +AM_LDFLAGS = -pthread
> 
> This hunk makes all test binaries link with pthread, even those that don't
> need it directly.  I'd rather have the tests that need pthreads *directly*
> to link with it, and only those.

Sure. I wasn't trying to provide a real fix here because I was more interested
in just getting things to compile so I could tinker with rc3. Having libabigail
link with pthreads sounds like a cleaner solution, yes.

> I have the same comment for the tools.  the only program using pthreads
> directly in the tools is abipkgdiff.  Thus, no other tool should link with
> pthreads.

Yes. I found that none of the tools linked, so I just threw -pthread in as a
global flag so I could move on.

> > -abinilint_LDFLAGS = $(abs_top_builddir)/src/libabigail.la
> > +abinilint_LDADD = $(abs_top_builddir)/src/libabigail.la
> 
> Ah, this one is a real typo.  Thanks for spotting that!

NP!

-- 
You are receiving this mail because:
You are on the CC list for the bug.