[Bug default/19706] Core dump from abidiff with suppression

["dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=19706

--- Comment #5 from dodji at redhat dot com ---
> 
> [suppress_function]
>     name_regexp = unity::scopes::internal::.*
> 
> Without this suppression, I don't get a core dump.
> 
> Is there a way to suppress all changes for absolutely everything in a
> particular namespace (preferably one that works with 1.0.rc2)?

I'd recommend to avoid using the [suppress_function] directive to suppress
change reports about function sub-types changes.
If you can, I believe it's more forward looking to use the [suppress_type]
directive.

Here is the rationale.

Usually, functions (or global variables) show up in the change report because o
one of their sub-types have changed.

If you suppress the change report about the whole function, if tomorrow another
sub-type of that function changes, you won't see it.  But it could be harmful.


> We have a strict separation of public and private APIs. In particular, we
> use the pimpl idiom for the public API, and we have tests to enforce that no
> public header mentions anything that's in the internal namespace (other than
> the opaque pointer-to-impl, which is forward-declared). 

This seems to mean that suppressing change reports about *types* that are
defined in the internal namespaces should usually be enough, e.g,

[suppress_type]
  name_regexp = ^unity::scopes::internal::.*

-- 
You are receiving this mail because:
You are on the CC list for the bug.