From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5884 invoked by alias); 23 Feb 2016 06:00:31 -0000 Mailing-List: contact libabigail-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: Sender: libabigail-owner@sourceware.org Received: (qmail 5814 invoked by uid 48); 23 Feb 2016 06:00:26 -0000 From: "michi.henning at canonical dot com" To: libabigail@sourceware.org Subject: [Bug default/19708] New: See who runs out of patience first? Date: Fri, 01 Jan 2016 00:00:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: michi.henning at canonical dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2016-q1/txt/msg00132.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D19708 Bug ID: 19708 Summary: See who runs out of patience first? Product: libabigail Version: unspecified Status: NEW Severity: normal Priority: P2 Component: default Assignee: dodji at redhat dot com Reporter: michi.henning at canonical dot com CC: libabigail at sourceware dot org Target Milestone: --- Referring to bug 19706 again. I start out with the following suppressions: [suppress_function] name_regexp =3D boost::.* change_kind =3D all allow_other_aliases =3D false [suppress_function] name_regexp =3D std::.* change_kind =3D all allow_other_aliases =3D false [suppress_function] name_regexp =3D unity::scopes::testing::.* change_kind =3D all allow_other_aliases =3D false [suppress_function] name_regexp =3D unity::scopes::internal::.* change_kind =3D all allow_other_aliases =3D false Now I run abidiff. I get (trailing lines for run_scope suppressed): 2 functions with some indirect sub-type change: [C]'method unity::scopes::ActivationQueryBase::ActivationQueryBase(const unity::scopes::Result&, const unity::scopes::ActionMetadata&)' at ActivationQueryBase.cpp:29:1 has some indirect sub-type changes: parameter 1 of type 'const unity::scopes::Result&' has sub-type changes: in referenced type 'const unity::scopes::Result': in unqualified underlying type 'class unity::scopes::Result' at Result.h:50:1: no data member change (1 filtered); [C]'method void unity::scopes::Runtime::run_scope(unity::scopes::ScopeBas= e*, const std::__cxx11::string&)' at Runtime.h:120:1 has some indirect sub-type changes: parameter 1 of type 'unity::scopes::ScopeBase*' has sub-type changes: in pointed to type 'class unity::scopes::ScopeBase' at ScopeBase.h:13= 3:1: no member function changes (6 filtered); 1 data member change: type of 'std::unique_ptr > unity::scopes::ScopeBase::p' changed: ... OK, so I add the following suppressions: [suppress_function] name =3D unity::scopes::Runtime::run_scope change_kind =3D function-subtype-change allow_other_aliases =3D false [suppress_function] name_regexp =3D unity::scopes::ActivationQueryBase::ActivationQueryBase change_kind =3D function-subtype-change allow_other_aliases =3D false This gets rid of the complaint about run_scope and the constructor, but now= I get this: 1 function with some indirect sub-type change: [C]'method unity::scopes::internal::ActivationQueryBaseImpl* unity::scopes::ActivationQueryBase::fwd()' at ActivationQueryBase.cpp:80:1 = has some indirect sub-type changes:=20 return type changed: in pointed to type 'class unity::scopes::internal::ActivationQueryBaseImpl' at ActivationQueryBaseImpl.h:36:1: 1 data member change: type of 'unity::scopes::Result unity::scopes::internal::ActivationQueryBaseImpl::result_' changed: no data member change (1 filtered); OK, fair enough, I edit the previous suppression to look like this instead = and try again. [suppress_function] name_regexp =3D unity::scopes::ActivationQueryBase::.* change_kind =3D function-subtype-change allow_other_aliases =3D false I no longer get the complaints about ActivationQueryBase, but: 1 function with some indirect sub-type change: [C]'method unity::scopes::ActivationResponse::ActivationResponse(const unity::scopes::Result&)' at ActivationResponse.h:80:1 has some indirect sub-type changes: parameter 1 of type 'const unity::scopes::Result&' has sub-type changes: in referenced type 'const unity::scopes::Result': in unqualified underlying type 'class unity::scopes::Result' at Result.h:50:1: no data member change (1 filtered); Fine, I'm getting the hang of it now and add: [suppress_function] name_regexp =3D unity::scopes::ActivationResponse::.* change_kind =3D function-subtype-change allow_other_aliases =3D false Now I get: 1 function with some indirect sub-type change: [C]'method unity::scopes::CategorisedResult::CategorisedResult(unity::scopes::Categori= sedResult&&)' at CategorisedResult.h:41:1 has some indirect sub-type changes: parameter 1 of type 'unity::scopes::CategorisedResult&&' has sub-type changes: in referenced type 'class unity::scopes::CategorisedResult' at CategorisedResult.h:41:1: no base class change (1 filtered); At that point, I lost patience. It seems like a game of whack-a-mole: every time I add a suppression, a new complaint pops up and, when I suppress that complaint, I get yet another different complaint. This isn't workable as is. Is there any way around this? (If possible, with 1.0.rc2?) --=20 You are receiving this mail because: You are on the CC list for the bug.